DO NOT REPLY [Bug 22025] - SerializerFactory requires xalan specific properties to be explicity set

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22025>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22025

SerializerFactory requires xalan specific properties to be explicity set





------- Additional Comments From minchau@ca.ibm.com  2003-07-31 17:28 -------
Hi John,
I'm leaning toward your opinion, but I'd like a little more motivation.

What you say is true, but you are already calling a Xalan specific method to 
get a serializer, so is there really a problem with setting a Xalan specific 
property when calling that method  
SerializerFactory.getSerializer(xalan_properties)?  
The code was intentionally written to force the caller to set the non-standard 
property  S_KEY_CONTENT_HANDLER.

Where did these properties that you are passing in come from? There is for 
example another Xalan factory with a method:
Properties xmlprops = OutputPropertiesFactory.getDefaultMethodProperties("xml");
that you would feed into the getSerializer() call.
Is there a reason you are getting the properties from somewhere else?

I don't think it would be good to change the properties that are passed in to 
getSerializer() via merging in any values.  I just don't like changing input 
values.  What we are trying to find out here is the classname of the serializer 
to use.  There is no standard property for this one and if caller has not 
specified its name via this non-standard property it does seem OK to me to use 
the default classname that would be found from the default properties.  Would 
that be sufficient?

Other opinions?