You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by "Alejandro Abdelnur (JIRA)" <ji...@apache.org> on 2012/05/11 15:25:44 UTC
[jira] [Created] (OOZIE-835) XTestCase Minicluster hangs when
shutting down with an exception using Hadoop 2
Alejandro Abdelnur created OOZIE-835:
----------------------------------------
Summary: XTestCase Minicluster hangs when shutting down with an exception using Hadoop 2
Key: OOZIE-835
URL: https://issues.apache.org/jira/browse/OOZIE-835
Project: Oozie
Issue Type: Bug
Components: tests
Affects Versions: trunk
Reporter: Alejandro Abdelnur
Assignee: Alejandro Abdelnur
Priority: Critical
Fix For: trunk
currently XTestCase uses a JVM shutdownHook to stop the minicluster, the problem is that minicluster uses shutdown hooks as well and a race condition gets things in hung state.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-835) XTestCase Minicluster hangs when
shutting down with an exception using Hadoop 2
Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273257#comment-13273257 ]
Alejandro Abdelnur commented on OOZIE-835:
------------------------------------------
Instead using a shutdownhook, we should use a monitor thread that detects that no testcase is running for X seconds and then triggers a shutdown of the minicluster
> XTestCase Minicluster hangs when shutting down with an exception using Hadoop 2
> -------------------------------------------------------------------------------
>
> Key: OOZIE-835
> URL: https://issues.apache.org/jira/browse/OOZIE-835
> Project: Oozie
> Issue Type: Bug
> Components: tests
> Affects Versions: trunk
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Priority: Critical
> Fix For: trunk
>
>
> currently XTestCase uses a JVM shutdownHook to stop the minicluster, the problem is that minicluster uses shutdown hooks as well and a race condition gets things in hung state.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-835) XTestCase Minicluster hangs when
shutting down with an exception using Hadoop 2
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273258#comment-13273258 ]
jiraposter@reviews.apache.org commented on OOZIE-835:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5093/
-----------------------------------------------------------
Review request for oozie.
Summary
-------
Instead using a shutdownhook, the patch uses a monitor thread that detects that no testcase is running for X seconds and then triggers a shutdown of the minicluster
This addresses bug OOZIE-835.
https://issues.apache.org/jira/browse/OOZIE-835
Diffs
-----
trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1337157
Diff: https://reviews.apache.org/r/5093/diff
Testing
-------
run all testcases with hadoop 1 and hadoop 2 and test JVM shutdown properly
Thanks,
Alejandro
> XTestCase Minicluster hangs when shutting down with an exception using Hadoop 2
> -------------------------------------------------------------------------------
>
> Key: OOZIE-835
> URL: https://issues.apache.org/jira/browse/OOZIE-835
> Project: Oozie
> Issue Type: Bug
> Components: tests
> Affects Versions: trunk
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Priority: Critical
> Fix For: trunk
>
>
> currently XTestCase uses a JVM shutdownHook to stop the minicluster, the problem is that minicluster uses shutdown hooks as well and a race condition gets things in hung state.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-835) XTestCase Minicluster hangs when
shutting down with an exception using Hadoop 2
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273519#comment-13273519 ]
jiraposter@reviews.apache.org commented on OOZIE-835:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5093/#review7810
-----------------------------------------------------------
trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java
<https://reviews.apache.org/r/5093/#comment17145>
can we create a variable for 10 second ? use variable in place of hard-coded number here.
- Mohammad
On 2012-05-11 13:43:19, Alejandro Abdelnur wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/5093/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-11 13:43:19)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Instead using a shutdownhook, the patch uses a monitor thread that detects that no testcase is running for X seconds and then triggers a shutdown of the minicluster
bq.
bq.
bq. This addresses bug OOZIE-835.
bq. https://issues.apache.org/jira/browse/OOZIE-835
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1337157
bq.
bq. Diff: https://reviews.apache.org/r/5093/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. run all testcases with hadoop 1 and hadoop 2 and test JVM shutdown properly
bq.
bq.
bq. Thanks,
bq.
bq. Alejandro
bq.
bq.
> XTestCase Minicluster hangs when shutting down with an exception using Hadoop 2
> -------------------------------------------------------------------------------
>
> Key: OOZIE-835
> URL: https://issues.apache.org/jira/browse/OOZIE-835
> Project: Oozie
> Issue Type: Bug
> Components: tests
> Affects Versions: trunk
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Priority: Critical
> Fix For: trunk
>
>
> currently XTestCase uses a JVM shutdownHook to stop the minicluster, the problem is that minicluster uses shutdown hooks as well and a race condition gets things in hung state.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-835) XTestCase Minicluster hangs when
shutting down with an exception using Hadoop 2
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273541#comment-13273541 ]
jiraposter@reviews.apache.org commented on OOZIE-835:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5093/#review7811
-----------------------------------------------------------
Ship it!
+1
- Mohammad
On 2012-05-11 19:27:34, Alejandro Abdelnur wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/5093/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-11 19:27:34)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Instead using a shutdownhook, the patch uses a monitor thread that detects that no testcase is running for X seconds and then triggers a shutdown of the minicluster
bq.
bq.
bq. This addresses bug OOZIE-835.
bq. https://issues.apache.org/jira/browse/OOZIE-835
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1337157
bq.
bq. Diff: https://reviews.apache.org/r/5093/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. run all testcases with hadoop 1 and hadoop 2 and test JVM shutdown properly
bq.
bq.
bq. Thanks,
bq.
bq. Alejandro
bq.
bq.
> XTestCase Minicluster hangs when shutting down with an exception using Hadoop 2
> -------------------------------------------------------------------------------
>
> Key: OOZIE-835
> URL: https://issues.apache.org/jira/browse/OOZIE-835
> Project: Oozie
> Issue Type: Bug
> Components: tests
> Affects Versions: trunk
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Priority: Critical
> Fix For: trunk
>
>
> currently XTestCase uses a JVM shutdownHook to stop the minicluster, the problem is that minicluster uses shutdown hooks as well and a race condition gets things in hung state.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (OOZIE-835) XTestCase Minicluster hangs when
shutting down with an exception using Hadoop 2
Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Abdelnur resolved OOZIE-835.
--------------------------------------
Resolution: Fixed
committed to trunk
> XTestCase Minicluster hangs when shutting down with an exception using Hadoop 2
> -------------------------------------------------------------------------------
>
> Key: OOZIE-835
> URL: https://issues.apache.org/jira/browse/OOZIE-835
> Project: Oozie
> Issue Type: Bug
> Components: tests
> Affects Versions: trunk
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Priority: Critical
> Fix For: trunk
>
>
> currently XTestCase uses a JVM shutdownHook to stop the minicluster, the problem is that minicluster uses shutdown hooks as well and a race condition gets things in hung state.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-835) XTestCase Minicluster hangs when
shutting down with an exception using Hadoop 2
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273532#comment-13273532 ]
jiraposter@reviews.apache.org commented on OOZIE-835:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5093/
-----------------------------------------------------------
(Updated 2012-05-11 19:27:34.298659)
Review request for oozie.
Changes
-------
Per Mohammad's suggestion, adding a system property that can modify the shutdown wait time of the monitor, defaulting to 10 seconds.
Per (IM) Virag's suggestion, the setupEmbeddedHadoop() minicluster initialization is try/catch and a shutdown is issued if an initialization error occurs.
Summary
-------
Instead using a shutdownhook, the patch uses a monitor thread that detects that no testcase is running for X seconds and then triggers a shutdown of the minicluster
This addresses bug OOZIE-835.
https://issues.apache.org/jira/browse/OOZIE-835
Diffs (updated)
-----
trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1337157
Diff: https://reviews.apache.org/r/5093/diff
Testing
-------
run all testcases with hadoop 1 and hadoop 2 and test JVM shutdown properly
Thanks,
Alejandro
> XTestCase Minicluster hangs when shutting down with an exception using Hadoop 2
> -------------------------------------------------------------------------------
>
> Key: OOZIE-835
> URL: https://issues.apache.org/jira/browse/OOZIE-835
> Project: Oozie
> Issue Type: Bug
> Components: tests
> Affects Versions: trunk
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Priority: Critical
> Fix For: trunk
>
>
> currently XTestCase uses a JVM shutdownHook to stop the minicluster, the problem is that minicluster uses shutdown hooks as well and a race condition gets things in hung state.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira