You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by gi...@apache.org on 2019/01/17 17:26:39 UTC
[incubator-druid] branch master updated: Let cachingCost balancer
strategy only consider segment replicatable nodes (#6879)
This is an automated email from the ASF dual-hosted git repository.
gian pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-druid.git
The following commit(s) were added to refs/heads/master by this push:
new b704ebf Let cachingCost balancer strategy only consider segment replicatable nodes (#6879)
b704ebf is described below
commit b704ebfa37b05af2da7485da1fda4d0c4ee43bf2
Author: Mingming Qiu <cs...@gmail.com>
AuthorDate: Fri Jan 18 01:26:33 2019 +0800
Let cachingCost balancer strategy only consider segment replicatable nodes (#6879)
---
.../coordinator/CachingCostBalancerStrategyFactory.java | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/server/src/main/java/org/apache/druid/server/coordinator/CachingCostBalancerStrategyFactory.java b/server/src/main/java/org/apache/druid/server/coordinator/CachingCostBalancerStrategyFactory.java
index a6261db..410a24d 100644
--- a/server/src/main/java/org/apache/druid/server/coordinator/CachingCostBalancerStrategyFactory.java
+++ b/server/src/main/java/org/apache/druid/server/coordinator/CachingCostBalancerStrategyFactory.java
@@ -71,14 +71,18 @@ public class CachingCostBalancerStrategyFactory implements BalancerStrategyFacto
@Override
public ServerView.CallbackAction segmentAdded(DruidServerMetadata server, DataSegment segment)
{
- clusterCostCacheBuilder.addSegment(server.getName(), segment);
+ if (server.segmentReplicatable()) {
+ clusterCostCacheBuilder.addSegment(server.getName(), segment);
+ }
return ServerView.CallbackAction.CONTINUE;
}
@Override
public ServerView.CallbackAction segmentRemoved(DruidServerMetadata server, DataSegment segment)
{
- clusterCostCacheBuilder.removeSegment(server.getName(), segment);
+ if (server.segmentReplicatable()) {
+ clusterCostCacheBuilder.removeSegment(server.getName(), segment);
+ }
return ServerView.CallbackAction.CONTINUE;
}
@@ -94,7 +98,9 @@ public class CachingCostBalancerStrategyFactory implements BalancerStrategyFacto
serverInventoryView.registerServerRemovedCallback(
executor,
server -> {
- clusterCostCacheBuilder.removeServer(server.getName());
+ if (server.segmentReplicatable()) {
+ clusterCostCacheBuilder.removeServer(server.getName());
+ }
return ServerView.CallbackAction.CONTINUE;
}
);
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org