You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/02/28 13:30:06 UTC

[GitHub] [incubator-kyuubi] yaooqinn opened a new pull request #1980: Fix race on some service during stop phase

yaooqinn opened a new pull request #1980:
URL: https://github.com/apache/incubator-kyuubi/pull/1980


   <!--
   Thanks for sending a pull request!
   
   Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
     2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
   -->
   
   ### _Why are the changes needed?_
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you add a feature, you can talk about the use case of it.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   
   ### _How was this patch tested?_
   - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
   
   - [ ] Add screenshots for manual tests if appropriate
   
   - [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1980: [KYUUBI #1969] Fix race on some service during start and stop phase

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #1980:
URL: https://github.com/apache/incubator-kyuubi/pull/1980#discussion_r816383428



##########
File path: kyuubi-common/src/main/scala/org/apache/kyuubi/service/TFrontendService.scala
##########
@@ -56,22 +56,53 @@ abstract class TFrontendService(name: String)
   protected lazy val authFactory: KyuubiAuthenticationFactory =
     new KyuubiAuthenticationFactory(conf, isServer())
 
+  /**
+   * Start the service itself(FE) and its composited (Discovery service, DS) in the order of:
+   *   Start FE ->
+   *     if (success) -> Continue starting DS
+   *       if (success) -> finish
+   *       else -> Stop DS -> Raise Error -> Stop FE -> Raise Error
+   *     else
+   *       Raise Error -> Stop FE -> Raise Error
+   *    This makes sure that the FE has started and ready to serve before exposing through DS.
+   */
   override def start(): Unit = synchronized {
-    super.start()
-    if (!started.getAndSet(true)) {
-      serverThread.start()
+    try {
+      if (started.compareAndSet(false, true)) {
+        serverThread.start()
+      }
+      super.start()
+    } catch {
+      case e: Throwable =>
+        stopInternal()
+        throw e
     }
   }
 
   protected def stopServer(): Unit
 
-  override def stop(): Unit = synchronized {
-    if (started.getAndSet(false)) {
+  /**
+   * Inner stop progress that will not stop all services composited with this.

Review comment:
       TTheadExecutor




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] SteNicholas commented on a change in pull request #1980: [KYUUBI #1969] Fix race on some service during start and stop phase

Posted by GitBox <gi...@apache.org>.
SteNicholas commented on a change in pull request #1980:
URL: https://github.com/apache/incubator-kyuubi/pull/1980#discussion_r816365251



##########
File path: kyuubi-common/src/main/scala/org/apache/kyuubi/service/TFrontendService.scala
##########
@@ -56,22 +56,53 @@ abstract class TFrontendService(name: String)
   protected lazy val authFactory: KyuubiAuthenticationFactory =
     new KyuubiAuthenticationFactory(conf, isServer())
 
+  /**
+   * Start the service itself(FE) and its composited (Discovery service, DS) in the order of:
+   *   Start FE ->
+   *     if (success) -> Continue starting DS
+   *       if (success) -> finish
+   *       else -> Stop DS -> Raise Error -> Stop FE -> Raise Error
+   *     else
+   *       Raise Error -> Stop FE -> Raise Error
+   *    This makes sure that the FE has started and ready to serve before exposing through DS.
+   */
   override def start(): Unit = synchronized {
-    super.start()
-    if (!started.getAndSet(true)) {
-      serverThread.start()
+    try {
+      if (started.compareAndSet(false, true)) {
+        serverThread.start()
+      }
+      super.start()
+    } catch {
+      case e: Throwable =>
+        stopInternal()
+        throw e
     }
   }
 
   protected def stopServer(): Unit
 
-  override def stop(): Unit = synchronized {
-    if (started.getAndSet(false)) {
+  /**
+   * Inner stop progress that will not stop all services composited with this.

Review comment:
       What does the inner nner stop progress stop? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1980: [KYUUBI #1969] Fix race on some service during stop phase

Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1980:
URL: https://github.com/apache/incubator-kyuubi/pull/1980#discussion_r815984847



##########
File path: kyuubi-common/src/main/scala/org/apache/kyuubi/service/TFrontendService.scala
##########
@@ -66,12 +66,12 @@ abstract class TFrontendService(name: String)
   protected def stopServer(): Unit
 
   override def stop(): Unit = synchronized {
+    super.stop()

Review comment:
       > Generally, the order of super.start() and super.stop() should be symmetrical
   
   What I mean **symmetrical** is, normally the pattern should be one of
   
   ```
   def start(): Unit = {
      super.start()
      self.start()
   }
   def stop(): Unit = {
      self.stop()
      super.stop()
   }
   ```
   
   ```
   def start(): Unit = {
      self.start()
      super.start()
   }
   def stop(): Unit = {
      super.stop()
      self.stop()
   }
   ```
   
   I'm just surprised that you changed it to
   ```
   def start(): Unit = {
      super.start()
      self.start()
   }
   def stop(): Unit = {
      super.stop()
      self.stop()
   }
   ```
   
    
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1980: Fix race on some service during stop phase

Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1980:
URL: https://github.com/apache/incubator-kyuubi/pull/1980#discussion_r815931734



##########
File path: kyuubi-common/src/main/scala/org/apache/kyuubi/service/TFrontendService.scala
##########
@@ -66,12 +66,12 @@ abstract class TFrontendService(name: String)
   protected def stopServer(): Unit
 
   override def stop(): Unit = synchronized {
+    super.stop()

Review comment:
       Generally, the order of `super.start()` and `super.stop()` should be symmetrical




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1980: Fix race on some service during stop phase

Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1980:
URL: https://github.com/apache/incubator-kyuubi/pull/1980#discussion_r815944807



##########
File path: kyuubi-common/src/main/scala/org/apache/kyuubi/service/TFrontendService.scala
##########
@@ -66,12 +66,12 @@ abstract class TFrontendService(name: String)
   protected def stopServer(): Unit
 
   override def stop(): Unit = synchronized {
+    super.stop()

Review comment:
       I think the lifecycle of FE should be: start server => register => serving... => unregister => stop server




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1980: Fix race on some service during stop phase

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #1980:
URL: https://github.com/apache/incubator-kyuubi/pull/1980#discussion_r815943748



##########
File path: kyuubi-common/src/main/scala/org/apache/kyuubi/service/TFrontendService.scala
##########
@@ -66,12 +66,12 @@ abstract class TFrontendService(name: String)
   protected def stopServer(): Unit
 
   override def stop(): Unit = synchronized {
+    super.stop()

Review comment:
       what actually you are trying to say about this change？




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] ulysses-you edited a comment on pull request #1980: [KYUUBI #1969] Fix race on some service during start and stop phase

Posted by GitBox <gi...@apache.org>.
ulysses-you edited a comment on pull request #1980:
URL: https://github.com/apache/incubator-kyuubi/pull/1980#issuecomment-1054927215


   thanks, merging to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #1980: [KYUUBI #1969] Fix race on some service during start and stop phase

Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #1980:
URL: https://github.com/apache/incubator-kyuubi/pull/1980#issuecomment-1054927215


   thanks, merging to master/branch-1.4


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #1980: [KYUUBI #1969] Fix race on some service during start and stop phase

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1980:
URL: https://github.com/apache/incubator-kyuubi/pull/1980#issuecomment-1054435124


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1980?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1980](https://codecov.io/gh/apache/incubator-kyuubi/pull/1980?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (efd1270) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/7faefb8203d328366266f447c6a644b5925c5e35?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7faefb8) will **increase** coverage by `0.03%`.
   > The diff coverage is `66.66%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/1980/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/1980?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1980      +/-   ##
   ============================================
   + Coverage     60.39%   60.43%   +0.03%     
     Complexity       69       69              
   ============================================
     Files           305      305              
     Lines         14858    14860       +2     
     Branches       1922     1921       -1     
   ============================================
   + Hits           8974     8980       +6     
   + Misses         5113     5111       -2     
   + Partials        771      769       -2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1980?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...rg/apache/kyuubi/engine/flink/FlinkSQLEngine.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1980/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1mbGluay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9mbGluay9GbGlua1NRTEVuZ2luZS5zY2FsYQ==) | `22.85% <ø> (-1.09%)` | :arrow_down: |
   | [...a/org/apache/kyuubi/service/TFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1980/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `94.48% <57.14%> (-0.32%)` | :arrow_down: |
   | [...he/kyuubi/events/AbstractEventLoggingService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1980/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9ldmVudHMvQWJzdHJhY3RFdmVudExvZ2dpbmdTZXJ2aWNlLnNjYWxh) | `100.00% <100.00%> (ø)` | |
   | [...cala/org/apache/kyuubi/metrics/MetricsSystem.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1980/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLW1ldHJpY3Mvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvbWV0cmljcy9NZXRyaWNzU3lzdGVtLnNjYWxh) | `83.72% <100.00%> (ø)` | |
   | [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1980/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `96.41% <0.00%> (+0.14%)` | :arrow_up: |
   | [.../org/apache/kyuubi/operation/KyuubiOperation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1980/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uLnNjYWxh) | `62.66% <0.00%> (+1.33%)` | :arrow_up: |
   | [...i/ha/client/zookeeper/ServiceDiscoveryClient.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1980/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL2NsaWVudC96b29rZWVwZXIvU2VydmljZURpc2NvdmVyeUNsaWVudC5zY2FsYQ==) | `60.57% <0.00%> (+1.92%)` | :arrow_up: |
   | [...ache/kyuubi/ha/client/EngineServiceDiscovery.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1980/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL2NsaWVudC9FbmdpbmVTZXJ2aWNlRGlzY292ZXJ5LnNjYWxh) | `80.00% <0.00%> (+6.66%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1980?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1980?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7faefb8...efd1270](https://codecov.io/gh/apache/incubator-kyuubi/pull/1980?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1980: [KYUUBI #1969] Fix race on some service during stop phase

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #1980:
URL: https://github.com/apache/incubator-kyuubi/pull/1980#discussion_r815968122



##########
File path: kyuubi-common/src/main/scala/org/apache/kyuubi/service/TFrontendService.scala
##########
@@ -66,12 +66,12 @@ abstract class TFrontendService(name: String)
   protected def stopServer(): Unit
 
   override def stop(): Unit = synchronized {
+    super.stop()

Review comment:
       that is right. BTW, can we try to make ourselves clear to the point? that is essential for the review process.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1980: [KYUUBI #1969] Fix race on some service during stop phase

Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1980:
URL: https://github.com/apache/incubator-kyuubi/pull/1980#discussion_r815984847



##########
File path: kyuubi-common/src/main/scala/org/apache/kyuubi/service/TFrontendService.scala
##########
@@ -66,12 +66,12 @@ abstract class TFrontendService(name: String)
   protected def stopServer(): Unit
 
   override def stop(): Unit = synchronized {
+    super.stop()

Review comment:
       > Generally, the order of super.start() and super.stop() should be symmetrical
   
   What I mean **symmetrical** is, normally the pattern should be one of
   
   ```
   def start(): Unit = {
      super.start()
      self.start()
   }
   def stop(): Unit = {
      self.stop()
      super.stop()
   }
   ```
   
   ```
   def start(): Unit = {
      self.start()
      super.start()
   }
   def stop(): Unit = {
      super.stop()
      self.stop()
   }
   ```
   
   I'm just surprised that you changed it to
   ```
   def start(): Unit = {
      self.start()
      super.start()
   }
   def stop(): Unit = {
      self.stop()
      super.stop()
   }
   ```
   
    
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1980: [KYUUBI #1969] Fix race on some service during stop phase

Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1980:
URL: https://github.com/apache/incubator-kyuubi/pull/1980#discussion_r815954334



##########
File path: kyuubi-common/src/main/scala/org/apache/kyuubi/service/TFrontendService.scala
##########
@@ -66,12 +66,12 @@ abstract class TFrontendService(name: String)
   protected def stopServer(): Unit
 
   override def stop(): Unit = synchronized {
+    super.stop()

Review comment:
       `super.start()` registers the FE before FE-server is ready, we should also move `super.start()` after `serverThread.start()`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1980: [KYUUBI #1969] Fix race on some service during stop phase

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #1980:
URL: https://github.com/apache/incubator-kyuubi/pull/1980#discussion_r816028081



##########
File path: kyuubi-common/src/main/scala/org/apache/kyuubi/service/TFrontendService.scala
##########
@@ -66,12 +66,12 @@ abstract class TFrontendService(name: String)
   protected def stopServer(): Unit
 
   override def stop(): Unit = synchronized {
+    super.stop()

Review comment:
       That's my fault, sorry for the weak apprehension




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1980: [KYUUBI #1969] Fix race on some service during stop phase

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #1980:
URL: https://github.com/apache/incubator-kyuubi/pull/1980#discussion_r815948030



##########
File path: kyuubi-common/src/main/scala/org/apache/kyuubi/service/TFrontendService.scala
##########
@@ -66,12 +66,12 @@ abstract class TFrontendService(name: String)
   protected def stopServer(): Unit
 
   override def stop(): Unit = synchronized {
+    super.stop()

Review comment:
       then what actually varies the order you present here,are we good to go?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #1980: [KYUUBI #1969] Fix race on some service during stop phase

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #1980:
URL: https://github.com/apache/incubator-kyuubi/pull/1980#issuecomment-1054321561


   cc @ulysses-you too


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #1980: [KYUUBI #1969] Fix race on some service during start and stop phase

Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #1980:
URL: https://github.com/apache/incubator-kyuubi/pull/1980#issuecomment-1054927883


   branch-1.4 has some conflicts, can you send a new PR for that ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] ulysses-you closed pull request #1980: [KYUUBI #1969] Fix race on some service during start and stop phase

Posted by GitBox <gi...@apache.org>.
ulysses-you closed pull request #1980:
URL: https://github.com/apache/incubator-kyuubi/pull/1980


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org