You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by jinossy <gi...@git.apache.org> on 2014/11/05 12:37:26 UTC
[GitHub] tajo pull request: TAJO-1151: Implement the ByteBuffer-based De/Se...
GitHub user jinossy opened a pull request:
https://github.com/apache/tajo/pull/228
TAJO-1151: Implement the ByteBuffer-based De/Serializer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jinossy/tajo TAJO-1151
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/228.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #228
----
commit aed406357e016e602b11dbaed3d20994dd651a17
Author: jhkim <jh...@apache.org>
Date: 2014-10-31T12:10:08Z
TAJO-1149: Implement direct read of TextFile scanner
commit f95d8dc0ef04dfb82290e23d5430eefc70f2552d
Author: jhkim <jh...@apache.org>
Date: 2014-10-31T13:42:47Z
remove the past buffer reading
commit f87e56f942b523f2bd2675d2c75484d3fea6023e
Author: jhkim <jh...@apache.org>
Date: 2014-11-01T14:47:56Z
refactor the compact buffer
commit bd15ea07a0187ff1d76bb0ba887bf899a281aa07
Author: jhkim <jh...@apache.org>
Date: 2014-11-03T08:03:30Z
rename LineDelimitedReader to DelimitedLineReader
commit 166e913be69d8ee7944d67c3fd82f015762d82b1
Author: jhkim <jh...@apache.org>
Date: 2014-11-03T09:36:38Z
rename csvfile.delimiter, csvfile.null to text.delimiter, text.null
commit 06362436c25db3a3332e8dc1eb398e4cb55c6413
Author: jhkim <jh...@apache.org>
Date: 2014-11-03T14:59:49Z
cleanup the stats
commit d84715c789a1c240862eb0368f73a99232c916b1
Author: jhkim <jh...@apache.org>
Date: 2014-11-03T16:02:26Z
fixed missing sample data
commit 36e55a6a1402b1b59d6815fffd503747d08a3154
Author: jhkim <jh...@apache.org>
Date: 2014-11-04T07:57:16Z
change the default text format to textfile
commit a9f8c183f66856ad9ca6a6f14b9269cfa9cb0c1e
Author: jhkim <jh...@apache.org>
Date: 2014-11-04T08:05:38Z
Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-1149
commit 6d3ab4f97739ddd3d6128a075eb76239ab9ddc82
Author: jhkim <jh...@apache.org>
Date: 2014-11-04T08:53:18Z
Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-1149
commit 6fedc5d1362a35b9643eb551164dcc148d59f090
Author: jhkim <jh...@apache.org>
Date: 2014-11-04T09:03:23Z
fixed compile error
commit e06acf9f523815423b67a373da90f2d561285e18
Author: jhkim <jh...@apache.org>
Date: 2014-11-05T11:36:01Z
TAJO-1151: Implement the ByteBuffer-based De/Serializer
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1151: Implement the ByteBuffer-based De/Se...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/228#discussion_r20152412
--- Diff: tajo-storage/src/main/java/org/apache/tajo/storage/text/DelimitedTextFile.java ---
@@ -136,9 +135,10 @@ public void init() throws IOException {
try {
// we need to discuss the De/Serializer interface. so custom serde is to disable
- String serdeClass = this.meta.getOption(StorageConstants.TEXTFILE_SERDE,
+ /*String serdeClass = this.meta.getOption(StorageConstants.TEXTFILE_SERDE,
--- End diff --
If we don't need this code line, please remove it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1151: Implement the ByteBuffer-based De/Se...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/228#issuecomment-62782583
+1
The patch looks great to me. This work will remove the unnecessary overheads of byte-array allocation, and it will be very helpful for zero-copy tuple in on-going ```block_iteration``` works.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1151: Implement the ByteBuffer-based De/Se...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/228
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1151: Implement the ByteBuffer-based De/Se...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/228#discussion_r20152417
--- Diff: tajo-storage/src/main/java/org/apache/tajo/storage/text/DelimitedTextFile.java ---
@@ -316,9 +316,10 @@ public void init() throws IOException {
try {
// we need to discuss the De/Serializer interface. so custom serde is to disable
- String serdeClass = this.meta.getOption(StorageConstants.TEXTFILE_SERDE,
+ /*String serdeClass = this.meta.getOption(StorageConstants.TEXTFILE_SERDE,
--- End diff --
If we don't need this code line, please remove it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1151: Implement the ByteBuffer-based De/Se...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/228#issuecomment-62554776
The patch looks good to me, but needs to be updated against the master branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1151: Implement the ByteBuffer-based De/Se...
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the pull request:
https://github.com/apache/tajo/pull/228#issuecomment-62661286
@jihoonson
I’ve remove the commented out line
Thank you for your review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---