You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Shajini Thayasingh (Code Review)" <ge...@cloudera.org> on 2021/01/05 20:52:16 UTC

[Impala-ASF-CR] IMPALA-10091: [DOCS] add REFRESH UPDATED HMS PARTITIONS query option

Shajini Thayasingh has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16925


Change subject: IMPALA-10091: [DOCS] add REFRESH_UPDATED_HMS_PARTITIONS query option
......................................................................

IMPALA-10091: [DOCS] add REFRESH_UPDATED_HMS_PARTITIONS query option

added this new query option for Impala 4.0

Change-Id: I95b31b33f99073c57752e66eaf0f34facf511fc6
---
M docs/impala.ditamap
A docs/topics/impala_refresh_updated_hms.xml
2 files changed, 73 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/16925/1
-- 
To view, visit http://gerrit.cloudera.org:8080/16925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I95b31b33f99073c57752e66eaf0f34facf511fc6
Gerrit-Change-Number: 16925
Gerrit-PatchSet: 1
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>

[Impala-ASF-CR] IMPALA-10091: [DOCS] add REFRESH UPDATED HMS PARTITIONS query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16925 )

Change subject: IMPALA-10091: [DOCS] add REFRESH_UPDATED_HMS_PARTITIONS query option
......................................................................


Patch Set 1: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/613/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/16925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I95b31b33f99073c57752e66eaf0f34facf511fc6
Gerrit-Change-Number: 16925
Gerrit-PatchSet: 1
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Jan 2021 20:59:33 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10091: [DOCS] add REFRESH UPDATED HMS PARTITIONS query option

Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16925 )

Change subject: IMPALA-10091: [DOCS] add REFRESH_UPDATED_HMS_PARTITIONS query option
......................................................................

IMPALA-10091: [DOCS] add REFRESH_UPDATED_HMS_PARTITIONS query option

remove trailing spaces
added this new query option for Impala 4.0

Change-Id: I95b31b33f99073c57752e66eaf0f34facf511fc6
Reviewed-on: http://gerrit.cloudera.org:8080/16925
Reviewed-by: Vihang Karajgaonkar <vi...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M docs/impala.ditamap
A docs/topics/impala_refresh_updated_hms.xml
2 files changed, 73 insertions(+), 0 deletions(-)

Approvals:
  Vihang Karajgaonkar: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/16925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I95b31b33f99073c57752e66eaf0f34facf511fc6
Gerrit-Change-Number: 16925
Gerrit-PatchSet: 3
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>

[Impala-ASF-CR] IMPALA-10091: [DOCS] add REFRESH UPDATED HMS PARTITIONS query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16925 )

Change subject: IMPALA-10091: [DOCS] add REFRESH_UPDATED_HMS_PARTITIONS query option
......................................................................


Patch Set 1:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/613/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/16925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I95b31b33f99073c57752e66eaf0f34facf511fc6
Gerrit-Change-Number: 16925
Gerrit-PatchSet: 1
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Jan 2021 20:52:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10091: [DOCS] add REFRESH UPDATED HMS PARTITIONS query option

Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16925 )

Change subject: IMPALA-10091: [DOCS] add REFRESH_UPDATED_HMS_PARTITIONS query option
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I95b31b33f99073c57752e66eaf0f34facf511fc6
Gerrit-Change-Number: 16925
Gerrit-PatchSet: 2
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Jan 2021 00:41:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10091: [DOCS] add REFRESH UPDATED HMS PARTITIONS query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16925 )

Change subject: IMPALA-10091: [DOCS] add REFRESH_UPDATED_HMS_PARTITIONS query option
......................................................................


Patch Set 2:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/614/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/16925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I95b31b33f99073c57752e66eaf0f34facf511fc6
Gerrit-Change-Number: 16925
Gerrit-PatchSet: 2
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Jan 2021 00:38:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10091: [DOCS] add REFRESH UPDATED HMS PARTITIONS query option

Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16925 )

Change subject: IMPALA-10091: [DOCS] add REFRESH_UPDATED_HMS_PARTITIONS query option
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16925/1/docs/topics/impala_refresh_updated_hms.xml
File docs/topics/impala_refresh_updated_hms.xml:

http://gerrit.cloudera.org:8080/#/c/16925/1/docs/topics/impala_refresh_updated_hms.xml@24
PS1, Line 24:  
Generally in the code we don't have such trailing spaces. I confirmed that other files in docs/topics also follow that convention. Can you please remove the extra trailing spaces marked in red in gerrit here? Its only to have a blank line with no spaces.



-- 
To view, visit http://gerrit.cloudera.org:8080/16925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I95b31b33f99073c57752e66eaf0f34facf511fc6
Gerrit-Change-Number: 16925
Gerrit-PatchSet: 1
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Jan 2021 00:05:27 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-10091: [DOCS] add REFRESH UPDATED HMS PARTITIONS query option

Posted by "Shajini Thayasingh (Code Review)" <ge...@cloudera.org>.
Hello Vihang Karajgaonkar, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16925

to look at the new patch set (#2).

Change subject: IMPALA-10091: [DOCS] add REFRESH_UPDATED_HMS_PARTITIONS query option
......................................................................

IMPALA-10091: [DOCS] add REFRESH_UPDATED_HMS_PARTITIONS query option

remove trailing spaces
added this new query option for Impala 4.0

Change-Id: I95b31b33f99073c57752e66eaf0f34facf511fc6
---
M docs/impala.ditamap
A docs/topics/impala_refresh_updated_hms.xml
2 files changed, 73 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/16925/2
-- 
To view, visit http://gerrit.cloudera.org:8080/16925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I95b31b33f99073c57752e66eaf0f34facf511fc6
Gerrit-Change-Number: 16925
Gerrit-PatchSet: 2
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>

[Impala-ASF-CR] IMPALA-10091: [DOCS] add REFRESH UPDATED HMS PARTITIONS query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16925 )

Change subject: IMPALA-10091: [DOCS] add REFRESH_UPDATED_HMS_PARTITIONS query option
......................................................................


Patch Set 2: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/614/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/16925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I95b31b33f99073c57752e66eaf0f34facf511fc6
Gerrit-Change-Number: 16925
Gerrit-PatchSet: 2
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Jan 2021 00:45:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10091: [DOCS] add REFRESH UPDATED HMS PARTITIONS query option

Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16925 )

Change subject: IMPALA-10091: [DOCS] add REFRESH_UPDATED_HMS_PARTITIONS query option
......................................................................


Patch Set 2:

Thanks for the update. Looks good to me.


-- 
To view, visit http://gerrit.cloudera.org:8080/16925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I95b31b33f99073c57752e66eaf0f34facf511fc6
Gerrit-Change-Number: 16925
Gerrit-PatchSet: 2
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Jan 2021 00:41:30 +0000
Gerrit-HasComments: No