You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/05/22 19:32:44 UTC

[GitHub] [incubator-pekko] mdedetrich opened a new pull request, #327: Unwrap single string interpolation syntax

mdedetrich opened a new pull request, #327:
URL: https://github.com/apache/incubator-pekko/pull/327

   Unwraps single string interpolation i.e. `s"${something}"` into `s"$something"`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

[GitHub] [incubator-pekko] mdedetrich commented on pull request #327: Unwrap single string interpolation syntax

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #327:
URL: https://github.com/apache/incubator-pekko/pull/327#issuecomment-1559596462

   @He-Pin You happy with the PR or is there anything additional?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

[GitHub] [incubator-pekko] He-Pin commented on a diff in pull request #327: Unwrap single string interpolation syntax

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #327:
URL: https://github.com/apache/incubator-pekko/pull/327#discussion_r1201447887


##########
bench-jmh/src/main/scala/org/apache/pekko/BenchRunner.scala:
##########
@@ -37,7 +37,7 @@ object BenchRunner {
         result.getParams.getParamsKeys.asScala.map(key => s"$key=${result.getParams.getParam(key)}").mkString("_")
       val score = result.getAggregatedResult.getPrimaryResult.getScore.round
       val unit = result.getAggregatedResult.getPrimaryResult.getScoreUnit
-      s"\t${bench}_${params}\t$score\t$unit"
+      s"\t${bench}_$params\t$score\t$unit"

Review Comment:
   `$bench`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

[GitHub] [incubator-pekko] He-Pin commented on a diff in pull request #327: Unwrap single string interpolation syntax

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #327:
URL: https://github.com/apache/incubator-pekko/pull/327#discussion_r1201448126


##########
bench-jmh/src/main/scala/org/apache/pekko/BenchRunner.scala:
##########
@@ -37,7 +37,7 @@ object BenchRunner {
         result.getParams.getParamsKeys.asScala.map(key => s"$key=${result.getParams.getParam(key)}").mkString("_")
       val score = result.getAggregatedResult.getPrimaryResult.getScore.round
       val unit = result.getAggregatedResult.getPrimaryResult.getScoreUnit
-      s"\t${bench}_${params}\t$score\t$unit"
+      s"\t${bench}_$params\t$score\t$unit"

Review Comment:
   `$bench`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #327: Unwrap single string interpolation syntax

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #327:
URL: https://github.com/apache/incubator-pekko/pull/327#discussion_r1201687930


##########
actor-typed-tests/src/test/scala/org/apache/pekko/actor/typed/delivery/DurableWorkPullingSpec.scala:
##########
@@ -90,7 +90,7 @@ class DurableWorkPullingSpec
       val workPullingController =
         spawn(
           WorkPullingProducerController[TestConsumer.Job](producerId, workerServiceKey, Some(durable)),
-          s"workPullingController-${idCount}")
+          s"""workPullingController-$idCount""")

Review Comment:
   Fixed and pushed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

[GitHub] [incubator-pekko] He-Pin commented on a diff in pull request #327: Unwrap single string interpolation syntax

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #327:
URL: https://github.com/apache/incubator-pekko/pull/327#discussion_r1201446461


##########
actor-typed-tests/src/test/scala/org/apache/pekko/actor/typed/delivery/DurableWorkPullingSpec.scala:
##########
@@ -90,7 +90,7 @@ class DurableWorkPullingSpec
       val workPullingController =
         spawn(
           WorkPullingProducerController[TestConsumer.Job](producerId, workerServiceKey, Some(durable)),
-          s"workPullingController-${idCount}")
+          s"""workPullingController-$idCount""")

Review Comment:
   This can be `s"workPullingController-$idCount"`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

[GitHub] [incubator-pekko] He-Pin merged pull request #327: Unwrap single string interpolation syntax

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin merged PR #327:
URL: https://github.com/apache/incubator-pekko/pull/327


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org