You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/10/01 00:02:38 UTC
[GitHub] [cloudstack] ravening opened a new pull request #4366: Consider maintenance mode as offline for prometheus stats
ravening opened a new pull request #4366:
URL: https://github.com/apache/cloudstack/pull/4366
## Description
<!--- Describe your changes in detail -->
If the resource state of hypervisor in "Maintenance" then it
should be considered as offline even though the agent state
is "Up". Since its in maintenance mode, it cant be used to
allocate VM's and hence can't be considered towards resource
allocation
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [X] Enhancement (improves an existing feature and functionality)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
Enable prometheus server
Add 127.0.0.1 as allowed Ip so that you can fetch metrics from prometheus
Now fetch the endpoint
```
# http http://127.0.0.1:9595/metrics | grep cloudstack_hosts_total
cloudstack_hosts_total{zone="mgt122-10",filter="online"} 3
cloudstack_hosts_total{zone="mgt122-10",filter="offline"} 0
cloudstack_hosts_total{zone="mgt122-10",filter="total"} 3
```
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4366: Consider maintenance mode as offline for prometheus stats
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4366:
URL: https://github.com/apache/cloudstack/pull/4366#issuecomment-705615423
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4366: Consider maintenance mode as offline for prometheus stats
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4366:
URL: https://github.com/apache/cloudstack/pull/4366#issuecomment-704216146
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4366: Consider maintenance mode as offline for prometheus stats
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4366:
URL: https://github.com/apache/cloudstack/pull/4366#issuecomment-704216482
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4366: Consider maintenance mode as offline for prometheus stats
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4366:
URL: https://github.com/apache/cloudstack/pull/4366#issuecomment-708304297
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4366: Consider maintenance mode as offline for prometheus stats
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4366:
URL: https://github.com/apache/cloudstack/pull/4366#issuecomment-705616259
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4366: Consider maintenance mode as offline for prometheus stats
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4366:
URL: https://github.com/apache/cloudstack/pull/4366
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4366: Consider maintenance mode as offline for prometheus stats
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4366:
URL: https://github.com/apache/cloudstack/pull/4366#issuecomment-705616259
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4366: Consider maintenance mode as offline for prometheus stats
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4366:
URL: https://github.com/apache/cloudstack/pull/4366#issuecomment-704170128
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4366: Consider maintenance mode as offline for prometheus stats
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4366:
URL: https://github.com/apache/cloudstack/pull/4366#issuecomment-705615423
errors don't seem related. doing a second run out of insanity:
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4366: Consider maintenance mode as offline for prometheus stats
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4366:
URL: https://github.com/apache/cloudstack/pull/4366#issuecomment-704194308
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2124
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4366: Consider maintenance mode as offline for prometheus stats
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4366:
URL: https://github.com/apache/cloudstack/pull/4366#issuecomment-704617177
<b>Trillian test result (tid-2898)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42308 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4366-t2898-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 83 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_ssvm_internals | `Failure` | 3.21 | test_ssvm.py
test_05_stop_ssvm | `Error` | 938.00 | test_ssvm.py
test_07_reboot_ssvm | `Error` | 911.62 | test_ssvm.py
test_09_destroy_ssvm | `Error` | 2.17 | test_ssvm.py
test_hostha_kvm_host_fencing | `Error` | 170.97 | test_hostha_kvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4366: Consider maintenance mode as offline for prometheus stats
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4366:
URL: https://github.com/apache/cloudstack/pull/4366#issuecomment-704169608
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4366: Consider maintenance mode as offline for prometheus stats
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4366:
URL: https://github.com/apache/cloudstack/pull/4366#issuecomment-706026557
the error below from the test failing above is addressed in #4355
```
Exception: Job failed: {jobprocstatus : 0, created : u'2020-10-09T02:03:27+0000', jobresult : {errorcode : 530, errortext : u'com.google.gson.stream.MalformedJsonException: Unterminated object near assword":"p*****},"resourcestate":"Enabl'}, cmd :
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4366: Consider maintenance mode as offline for prometheus stats
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4366:
URL: https://github.com/apache/cloudstack/pull/4366#issuecomment-705924550
<b>Trillian test result (tid-2913)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39476 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4366-t2913-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 84 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_hostha_kvm_host_fencing | `Error` | 174.95 | test_hostha_kvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4366: Consider maintenance mode as offline for prometheus stats
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4366:
URL: https://github.com/apache/cloudstack/pull/4366#issuecomment-701977488
LGTM, did not test it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org