You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "hainenber (via GitHub)" <gi...@apache.org> on 2024/09/21 09:58:55 UTC
[PR] chore(fe): uplift FE packages to latest version [superset]
hainenber opened a new pull request, #30357:
URL: https://github.com/apache/superset/pull/30357
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
chore(fe): uplift FE packages to latest version
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Changes:
- Run `npm audit fix`
- Uplift `fetch-mock` to v11 + corresponding refactoring for `superset-ui-core`
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(fe): uplift FE packages to latest version [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on PR #30357:
URL: https://github.com/apache/superset/pull/30357#issuecomment-2374335764
> - Uplift fetch-mock to v11 + corresponding refactoring for superset-ui-core.
> - Uplift following packages to latest version.
> - @testing-library/react-hooks
> - @testing-library/jest-dom
> - webpack-cli
These are dev dependencies and any breakages are detected in `frontend-build` CI. Current check is green so these uplift are safe
> Move @types/* packages in superset-ui-core to devDependencies.
Moving of `@types/*` package that are actual dependency will generate linting issue. This can be illustrated by moving `@types/json-bigint` into devDependencies in `superset-ui-core`. Current build is green so the uplift is safe.
<img width="1050" alt="image" src="https://github.com/user-attachments/assets/919fb04c-c268-4e9f-a70a-6d45a183f08c">
Only risk is with `npm audit fix` as it might bump packages not respecting semver. However, from my inspection, they're mostly version bumps of dev dependencies (this is at 95% confidence interval :D)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(fe): uplift FE packages to latest version [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #30357:
URL: https://github.com/apache/superset/pull/30357
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(fe): uplift FE packages to latest version [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on PR #30357:
URL: https://github.com/apache/superset/pull/30357#issuecomment-2368946824
@rusackas Do you think we may have a breaking change here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org