You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/05/19 14:29:29 UTC

[GitHub] [camel-k] davsclaus opened a new issue, #3291: Dependency doc is wrong about how to add camel components

davsclaus opened a new issue, #3291:
URL: https://github.com/apache/camel-k/issues/3291

   https://camel.apache.org/camel-k/1.9.x/configuration/dependencies.html
   
   It says `-d camel-mina2` but the syntax for camel is to use a colon, eg `-d camel:mina2`.
   Also mina2 is an old Camel 2.x component, that is removed in camel 3.
   
   So lets use another, can be netty or http, etc.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-k] tadayosi commented on issue #3291: Dependency doc is wrong about how to add camel components

Posted by GitBox <gi...@apache.org>.
tadayosi commented on issue #3291:
URL: https://github.com/apache/camel-k/issues/3291#issuecomment-1193489297

   Then we can choose `camel:xxx` as the standard, preferred notation and use them throughout the docs and examples. I'll mark `camel-xxx` as deprecated whereever appropriate and remove the usages from the docs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-k] davsclaus commented on issue #3291: Dependency doc is wrong about how to add camel components

Posted by GitBox <gi...@apache.org>.
davsclaus commented on issue #3291:
URL: https://github.com/apache/camel-k/issues/3291#issuecomment-1193588273

   I think 90% of end users would type `camel-xxx` as its the name of the JAR file, using `camel:xxx` can be hard on the eye to notice that using a colon instead of dash.
   
   I would support both notations, but harmonize the docs as suggested here in the PR
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-k] tadayosi closed issue #3291: Dependency doc is wrong about how to add camel components

Posted by GitBox <gi...@apache.org>.
tadayosi closed issue #3291: Dependency doc is wrong about how to add camel components
URL: https://github.com/apache/camel-k/issues/3291


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-k] squakez commented on issue #3291: Dependency doc is wrong about how to add camel components

Posted by GitBox <gi...@apache.org>.
squakez commented on issue #3291:
URL: https://github.com/apache/camel-k/issues/3291#issuecomment-1131852638

   I think that was the original way we supported the components, see the `kamel run --help`:
   ```
     -d, --dependency stringArray         A dependency that should be included, e.g., "-d camel-mail" for a Camel component, or "-d mvn:org.my:app:1.0" for a Maven dependency
   ```
   I remind we were converting the `camel-xxx` to `camel:xxx` or viceversa, so I'm marking this as a bug as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-k] tadayosi commented on issue #3291: Dependency doc is wrong about how to add camel components

Posted by GitBox <gi...@apache.org>.
tadayosi commented on issue #3291:
URL: https://github.com/apache/camel-k/issues/3291#issuecomment-1191076734

   @davsclaus @squakez I recently fixed the discrepancy issue between `kamel run -d` and `kamel local run -d` #2213, and now both commands support both `camel-amqp` and `camel:amqp` notations. And as Pasquale said internally `camel-xxx` is converted to `camel:xxx` on an Integration's status.
   
   So, the question is which notation do we prefer as the standard notation for dependencies in the docs?  `camel-xxx` or `camel:xxx`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-k] squakez commented on issue #3291: Dependency doc is wrong about how to add camel components

Posted by GitBox <gi...@apache.org>.
squakez commented on issue #3291:
URL: https://github.com/apache/camel-k/issues/3291#issuecomment-1191126941

   I like it more `camel:xxx` as we also have `mvn:yyy` approach. I think we need to harmonize the way we reference camel components/dependencies and use always the same way. However, if we decide to drop `camel-xxx` approach, we'll need a period of deprecation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org