You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/04/30 19:13:10 UTC

Review Request 20898: Updated the 'contains' method in stout IntervalSet to support more types.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20898/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.


Repository: mesos-git


Description
-------

See summary.


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp b219605 
  3rdparty/libprocess/3rdparty/stout/tests/interval_tests.cpp 83a580b 

Diff: https://reviews.apache.org/r/20898/diff/


Testing
-------

make check

repeated 100 times.


Thanks,

Jie Yu


Re: Review Request 20898: Updated the 'contains' method in stout IntervalSet to support more types.

Posted by Jie Yu <yu...@gmail.com>.

> On April 30, 2014, 6:41 p.m., Vinod Kone wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp, line 164
> > <https://reviews.apache.org/r/20898/diff/1/?file=571693#file571693line164>
> >
> >     Can X be different than T?

Yes, it can. X can be T, Interval<T>, IntervalSet<T>. See tests for examples.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20898/#review41867
-----------------------------------------------------------


On April 30, 2014, 6:28 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20898/
> -----------------------------------------------------------
> 
> (Updated April 30, 2014, 6:28 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Dominic Hamon, and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp b219605 
>   3rdparty/libprocess/3rdparty/stout/tests/interval_tests.cpp 83a580b 
> 
> Diff: https://reviews.apache.org/r/20898/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> repeated 100 times.
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Re: Review Request 20898: Updated the 'contains' method in stout IntervalSet to support more types.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20898/#review41867
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp
<https://reviews.apache.org/r/20898/#comment75528>

    Can X be different than T?


- Vinod Kone


On April 30, 2014, 6:28 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20898/
> -----------------------------------------------------------
> 
> (Updated April 30, 2014, 6:28 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Dominic Hamon, and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp b219605 
>   3rdparty/libprocess/3rdparty/stout/tests/interval_tests.cpp 83a580b 
> 
> Diff: https://reviews.apache.org/r/20898/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> repeated 100 times.
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Re: Review Request 20898: Updated the 'contains' method in stout IntervalSet to support more types.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20898/#review41878
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On April 30, 2014, 7:41 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20898/
> -----------------------------------------------------------
> 
> (Updated April 30, 2014, 7:41 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Dominic Hamon, and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp b219605 
>   3rdparty/libprocess/3rdparty/stout/tests/interval_tests.cpp 83a580b 
> 
> Diff: https://reviews.apache.org/r/20898/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> repeated 100 times.
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Re: Review Request 20898: Updated the 'contains' method in stout IntervalSet to support more types.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20898/
-----------------------------------------------------------

(Updated April 30, 2014, 7:41 p.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, Dominic Hamon, and Vinod Kone.


Changes
-------

Discussed with Vinod offline. Now, instead of using template, we only provide overload for T, Interval<T> and IntervalSet<T>.


Repository: mesos-git


Description
-------

See summary.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp b219605 
  3rdparty/libprocess/3rdparty/stout/tests/interval_tests.cpp 83a580b 

Diff: https://reviews.apache.org/r/20898/diff/


Testing
-------

make check

repeated 100 times.


Thanks,

Jie Yu


Re: Review Request 20898: Updated the 'contains' method in stout IntervalSet to support more types.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20898/
-----------------------------------------------------------

(Updated April 30, 2014, 6:28 p.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, Dominic Hamon, and Vinod Kone.


Changes
-------

+ Dominic


Repository: mesos-git


Description
-------

See summary.


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp b219605 
  3rdparty/libprocess/3rdparty/stout/tests/interval_tests.cpp 83a580b 

Diff: https://reviews.apache.org/r/20898/diff/


Testing
-------

make check

repeated 100 times.


Thanks,

Jie Yu