You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2015/04/23 22:13:21 UTC

Review Request 33491: Set the supplementary groups list when switching users.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33491/
-----------------------------------------------------------

Review request for mesos.


Bugs: MESOS-719
    https://issues.apache.org/jira/browse/MESOS-719


Repository: mesos


Description
-------

Make sure we call initgroups(3) after calling setgid(2) so that the
auxiliary groups for the su'd user are set.

This is particularly important for docker support because it lets
you add your mesos user to the docker group so it can talk to docker
through /var/run/docker.sock (which is owned by a docker group by
default in most installations.) Without initgroups, the Mesos user
only has its primary GID set.


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 02db3c587e3f9a40282405e9496bde30e251f8bb 

Diff: https://reviews.apache.org/r/33491/diff/


Testing
-------

Ran "make check" on CentOS 7 & and OS X 10.10.3.


Thanks,

James Peach