[GitHub] wu-sheng closed pull request #1100: Add trace doc and fix logback doc error

[GitBox <gi...@apache.org>]

wu-sheng closed pull request #1100: Add trace doc and fix logback doc error
URL: https://github.com/apache/incubator-skywalking/pull/1100
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/docs/cn/Application-toolkit-trace-CN.md b/docs/cn/Application-toolkit-trace-CN.md
index 84695938b..c0f58c73f 100644
--- a/docs/cn/Application-toolkit-trace-CN.md
+++ b/docs/cn/Application-toolkit-trace-CN.md
@@ -17,3 +17,7 @@ modelAndView.addObject("traceId", TraceContext.traceId());
 _示例代码，仅供参考_
 
 * 对任何需要追踪的方法，使用 `@Trace` 标注，则此方法会被加入到追踪链中。
+* 在被追踪的方法中自定义 tag.
+```java
+ActiveSpan.tag("my_tag", "my_value");
+```
diff --git a/docs/en/Application-toolkit-logback-1.x.md b/docs/en/Application-toolkit-logback-1.x.md
index 82228e74d..86611b452 100644
--- a/docs/en/Application-toolkit-logback-1.x.md
+++ b/docs/en/Application-toolkit-logback-1.x.md
@@ -1,10 +1,10 @@
 * Dependency the toolkit, such as using maven or gradle
 ```xml
-   <dependency>
-      <groupId>org.apache.skywalking</groupId>
-      <artifactId>skywalking-toolkit-logback-1.x</artifactId>
-      <version>{project.release.version}</version>
-   </dependency>
+    <dependency>
+         <groupId>org.apache.skywalking</groupId>
+         <artifactId>apm-toolkit-logback-1.x</artifactId>
+         <version>{project.release.version}</version>
+     </dependency>
 ```
 
 * set `%tid` in `Pattern` section of logback.xml
diff --git a/docs/en/Application-toolkit-trace.md b/docs/en/Application-toolkit-trace.md
index 4f195de41..bbd8df6de 100644
--- a/docs/en/Application-toolkit-trace.md
+++ b/docs/en/Application-toolkit-trace.md
@@ -17,3 +17,7 @@ modelAndView.addObject("traceId", TraceContext.traceId());
 _Sample codes only_
 
 * Add `@Trace` to any method you want to trace. After that, you can see the span in the Stack.
+* Add custom tag in  the context of traced method .
+```java
+ActiveSpan.tag("my_tag", "my_value");
+```


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services