You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/02/18 16:55:45 UTC
[GitHub] [maven-dependency-analyzer] michael-o commented on a change in pull request #51: Require Maven 3.2.5+
michael-o commented on a change in pull request #51:
URL: https://github.com/apache/maven-dependency-analyzer/pull/51#discussion_r810176113
##########
File path: pom.xml
##########
@@ -59,51 +59,50 @@
</distributionManagement>
<properties>
- <mavenVersion>2.0.5</mavenVersion>
- <surefire.version>2.22.2</surefire.version>
+ <mavenVersion>3.2.5</mavenVersion>
<javaVersion>8</javaVersion>
<project.build.outputTimestamp>2022-01-24T19:57:26Z</project.build.outputTimestamp>
</properties>
<dependencies>
+
Review comment:
They don't end with an empty line as well; inconsistent
##########
File path: src/main/java/org/apache/maven/shared/dependency/analyzer/DefaultProjectDependencyAnalyzer.java
##########
@@ -94,7 +97,7 @@ public ProjectDependencyAnalysis analyze( MavenProject project )
Set<Artifact> testArtifactsWithNonTestScope = getTestArtifactsWithNonTestScope( testOnlyArtifacts );
return new ProjectDependencyAnalysis( usedDeclaredArtifacts, usedUndeclaredArtifactsWithClasses,
- unusedDeclaredArtifacts, testArtifactsWithNonTestScope );
+ unusedDeclaredArtifacts, testArtifactsWithNonTestScope );
Review comment:
Contradicts our style
##########
File path: src/main/java/org/apache/maven/shared/dependency/analyzer/DefaultProjectDependencyAnalyzer.java
##########
@@ -263,7 +266,7 @@ else if ( file != null && file.isDirectory() )
}
private Map<Artifact, Set<String>> buildUsedArtifacts( Map<Artifact, Set<String>> artifactClassMap,
- Set<String> dependencyClasses )
+ Set<String> dependencyClasses )
Review comment:
Same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org