You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by "Virag Kothari (Created) (JIRA)" <ji...@apache.org> on 2012/02/03 19:19:57 UTC
[jira] [Created] (OOZIE-677) Add Filter API for status on
coordinator actions
Add Filter API for status on coordinator actions
------------------------------------------------
Key: OOZIE-677
URL: https://issues.apache.org/jira/browse/OOZIE-677
Project: Oozie
Issue Type: Improvement
Reporter: Virag Kothari
Currently the filter option is only supported for 'oozie jobs'.
In some cases, they are also required for 'oozie job'. E.g to filter coordinator actions for a coordinator job, filter coordinator jobs for a bundle etc.
This jira proposes to provide status filters for coordinator actions on a coordinator job
E.g oozie job -info coordjobid -filter status=RUNNING;status=KILLED
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-677) Add Filter API for status on
coordinator actions
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204822#comment-13204822 ]
jiraposter@reviews.apache.org commented on OOZIE-677:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3756/#review4987
-----------------------------------------------------------
trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java
<https://reviews.apache.org/r/3756/#comment10960>
k.. seems better..thxs
trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java
<https://reviews.apache.org/r/3756/#comment10962>
k
trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java
<https://reviews.apache.org/r/3756/#comment10961>
k
trunk/core/src/main/java/org/apache/oozie/ErrorCode.java
<https://reviews.apache.org/r/3756/#comment10963>
that is for the jobs command
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java
<https://reviews.apache.org/r/3756/#comment10964>
k
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java
<https://reviews.apache.org/r/3756/#comment10965>
k
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java
<https://reviews.apache.org/r/3756/#comment10966>
yes..it wont be used
- Virag
On 2012-02-09 01:38:25, Virag Kothari wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3756/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-09 01:38:25)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. https://issues.apache.org/jira/browse/OOZIE-677
bq.
bq.
bq. This addresses bug oozie-677.
bq. https://issues.apache.org/jira/browse/oozie-677
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1242197
bq. trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1242197
bq. trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1242197
bq. trunk/core/src/main/java/org/apache/oozie/BaseEngine.java 1242197
bq. trunk/core/src/main/java/org/apache/oozie/BundleEngine.java 1242197
bq. trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1242197
bq. trunk/core/src/main/java/org/apache/oozie/DagEngine.java 1242197
bq. trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1242197
bq. trunk/core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 1242197
bq. trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java 1242197
bq. trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1242197
bq. trunk/core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java 1242197
bq. trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 1242197
bq. trunk/core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 1242197
bq. trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1242197
bq.
bq. Diff: https://reviews.apache.org/r/3756/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Test cases added
bq. Checked filter option thru. command line after running cron example
bq.
bq.
bq. Thanks,
bq.
bq. Virag
bq.
bq.
> Add Filter API for status on coordinator actions
> ------------------------------------------------
>
> Key: OOZIE-677
> URL: https://issues.apache.org/jira/browse/OOZIE-677
> Project: Oozie
> Issue Type: Improvement
> Reporter: Virag Kothari
>
> Currently the filter option is only supported for 'oozie jobs'.
> In some cases, they are also required for 'oozie job'. E.g to filter coordinator actions for a coordinator job, filter coordinator jobs for a bundle etc.
> This jira proposes to provide status filters for coordinator actions on a coordinator job
> E.g oozie job -info coordjobid -filter status=RUNNING;status=KILLED
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-677) Add Filter API for status on
coordinator actions
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204815#comment-13204815 ]
jiraposter@reviews.apache.org commented on OOZIE-677:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3756/#review4982
-----------------------------------------------------------
Some more comments.
trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java
<https://reviews.apache.org/r/3756/#comment10957>
This needs to be updated since the arguments have changed.
trunk/core/src/main/java/org/apache/oozie/ErrorCode.java
<https://reviews.apache.org/r/3756/#comment10958>
How did the fork/join error messages creep into this patch?
trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java
<https://reviews.apache.org/r/3756/#comment10945>
Can you change this to status=<S1>[;status=<S2>]* ?
trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java
<https://reviews.apache.org/r/3756/#comment10950>
Move the catch to the previous line to conform to Java coding standards.
trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java
<https://reviews.apache.org/r/3756/#comment10948>
Can this be rephrased as "The only valid filter is 'status'" ?
trunk/core/src/main/java/org/apache/oozie/ErrorCode.java
<https://reviews.apache.org/r/3756/#comment10952>
How is this error different from E0420 ?
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java
<https://reviews.apache.org/r/3756/#comment10953>
Can this be changed to filterList ?
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java
<https://reviews.apache.org/r/3756/#comment10954>
Can you change filter to filterList or filters ?
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java
<https://reviews.apache.org/r/3756/#comment10956>
Minor comment - I am assuming that this method will not be used by another method since the assertions are very specific. In particular, as the comment on line #114 states, its assumed that only RUNNING jobs are returned
- Santhosh
On 2012-02-09 01:38:25, Virag Kothari wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3756/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-09 01:38:25)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. https://issues.apache.org/jira/browse/OOZIE-677
bq.
bq.
bq. This addresses bug oozie-677.
bq. https://issues.apache.org/jira/browse/oozie-677
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1242197
bq. trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1242197
bq. trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1242197
bq. trunk/core/src/main/java/org/apache/oozie/BaseEngine.java 1242197
bq. trunk/core/src/main/java/org/apache/oozie/BundleEngine.java 1242197
bq. trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1242197
bq. trunk/core/src/main/java/org/apache/oozie/DagEngine.java 1242197
bq. trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1242197
bq. trunk/core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 1242197
bq. trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java 1242197
bq. trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1242197
bq. trunk/core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java 1242197
bq. trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 1242197
bq. trunk/core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 1242197
bq. trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1242197
bq.
bq. Diff: https://reviews.apache.org/r/3756/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Test cases added
bq. Checked filter option thru. command line after running cron example
bq.
bq.
bq. Thanks,
bq.
bq. Virag
bq.
bq.
> Add Filter API for status on coordinator actions
> ------------------------------------------------
>
> Key: OOZIE-677
> URL: https://issues.apache.org/jira/browse/OOZIE-677
> Project: Oozie
> Issue Type: Improvement
> Reporter: Virag Kothari
>
> Currently the filter option is only supported for 'oozie jobs'.
> In some cases, they are also required for 'oozie job'. E.g to filter coordinator actions for a coordinator job, filter coordinator jobs for a bundle etc.
> This jira proposes to provide status filters for coordinator actions on a coordinator job
> E.g oozie job -info coordjobid -filter status=RUNNING;status=KILLED
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-677) Add Filter API for status on
coordinator actions
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204182#comment-13204182 ]
jiraposter@reviews.apache.org commented on OOZIE-677:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3756/
-----------------------------------------------------------
(Updated 2012-02-09 01:38:25.845285)
Review request for oozie.
Changes
-------
Integrating Santhosh's comments
Summary
-------
https://issues.apache.org/jira/browse/OOZIE-677
This addresses bug oozie-677.
https://issues.apache.org/jira/browse/oozie-677
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1242197
trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1242197
trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1242197
trunk/core/src/main/java/org/apache/oozie/BaseEngine.java 1242197
trunk/core/src/main/java/org/apache/oozie/BundleEngine.java 1242197
trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1242197
trunk/core/src/main/java/org/apache/oozie/DagEngine.java 1242197
trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1242197
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 1242197
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java 1242197
trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1242197
trunk/core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java 1242197
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 1242197
trunk/core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 1242197
trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1242197
Diff: https://reviews.apache.org/r/3756/diff
Testing
-------
Test cases added
Checked filter option thru. command line after running cron example
Thanks,
Virag
> Add Filter API for status on coordinator actions
> ------------------------------------------------
>
> Key: OOZIE-677
> URL: https://issues.apache.org/jira/browse/OOZIE-677
> Project: Oozie
> Issue Type: Improvement
> Reporter: Virag Kothari
>
> Currently the filter option is only supported for 'oozie jobs'.
> In some cases, they are also required for 'oozie job'. E.g to filter coordinator actions for a coordinator job, filter coordinator jobs for a bundle etc.
> This jira proposes to provide status filters for coordinator actions on a coordinator job
> E.g oozie job -info coordjobid -filter status=RUNNING;status=KILLED
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-677) Add Filter API for status on
coordinator actions
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203057#comment-13203057 ]
jiraposter@reviews.apache.org commented on OOZIE-677:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3756/#review4883
-----------------------------------------------------------
Comments on consistency in coding, more helpful error messages and test coverage.
trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java
<https://reviews.apache.org/r/3756/#comment10784>
The message is very terse without any information on the ability to specify a list. I noticed that the twiki has the details. I am expecting few people to refer to the twiki and more people will refer to the command line message. Can we improve on the message here?
trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java
<https://reviews.apache.org/r/3756/#comment10757>
Shouldn't the list of arguments be (jobId, null, 0, 0) ?
trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java
<https://reviews.apache.org/r/3756/#comment10758>
Shouldn't this be (jobId, filter, start, len) ?
trunk/core/src/main/java/org/apache/oozie/BundleEngine.java
<https://reviews.apache.org/r/3756/#comment10759>
Why are you using filterStr instead of filter - its not consistent with your usage in other methods.
trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java
<https://reviews.apache.org/r/3756/#comment10760>
Why are you using filterStr instead of filter - its not consistent with your usage in other methods.
trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java
<https://reviews.apache.org/r/3756/#comment10761>
Can you make this filterList - between filterStr and filter - there is no way to figure out the data types
trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java
<https://reviews.apache.org/r/3756/#comment10774>
Can you add detailed comments on the expectation of this method - there are several assumptions here in the code that need to be called out.
trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java
<https://reviews.apache.org/r/3756/#comment10762>
Can you include the pair to help the user with the remedial measure?
trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java
<https://reviews.apache.org/r/3756/#comment10764>
What are the valid values?
trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java
<https://reviews.apache.org/r/3756/#comment10765>
Is status the only filter?
trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java
<https://reviews.apache.org/r/3756/#comment10766>
What are the valid filter keys?
trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java
<https://reviews.apache.org/r/3756/#comment10767>
What happens if the token does not contain "=" ? The error handling is not robust
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java
<https://reviews.apache.org/r/3756/#comment10770>
Can you change this to filterList?
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java
<https://reviews.apache.org/r/3756/#comment10771>
Can you change this to filterList?
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java
<https://reviews.apache.org/r/3756/#comment10773>
Can you change this to filterList?
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java
<https://reviews.apache.org/r/3756/#comment10772>
Can you change this to filterList?
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java
<https://reviews.apache.org/r/3756/#comment10778>
Add a brief note about the method and change the name to getStatusClause or something more meaningful
trunk/core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java
<https://reviews.apache.org/r/3756/#comment10781>
Can you add a check for the following too:
1. empty filter list (if possible)
2. filter list with the '=' missing
3. filter list with nothing after '='
trunk/core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java
<https://reviews.apache.org/r/3756/#comment10779>
Can you separate the checks for error code and error message?
trunk/core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java
<https://reviews.apache.org/r/3756/#comment10780>
Can you separate the checks for error code and error message?
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java
<https://reviews.apache.org/r/3756/#comment10782>
Can you please use more descriptive variable names - for example, filterList?
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java
<https://reviews.apache.org/r/3756/#comment10783>
What is the advantage of having this private method? Can it be reused by other methods?
If the method is retained, please add comments on what is expected of this method?
trunk/docs/src/site/twiki/DG_CommandLineTool.twiki
<https://reviews.apache.org/r/3756/#comment10785>
This line is too technical for an application developer. Can it be simplified to state that when multiple filters are specified, all coordinator actions that satisfy any one of the filters will be retrieved?
- Santhosh
On 2012-02-03 18:45:55, Virag Kothari wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3756/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-03 18:45:55)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. https://issues.apache.org/jira/browse/OOZIE-677
bq.
bq.
bq. This addresses bug oozie-677.
bq. https://issues.apache.org/jira/browse/oozie-677
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1240247
bq. trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1240247
bq. trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1240247
bq. trunk/core/src/main/java/org/apache/oozie/BaseEngine.java 1240247
bq. trunk/core/src/main/java/org/apache/oozie/BundleEngine.java 1240247
bq. trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1240247
bq. trunk/core/src/main/java/org/apache/oozie/DagEngine.java 1240247
bq. trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1240247
bq. trunk/core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 1240247
bq. trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java 1240247
bq. trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1240247
bq. trunk/core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java 1240247
bq. trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 1240247
bq. trunk/core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 1240247
bq. trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1240247
bq.
bq. Diff: https://reviews.apache.org/r/3756/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Test cases added
bq. Checked filter option thru. command line after running cron example
bq.
bq.
bq. Thanks,
bq.
bq. Virag
bq.
bq.
> Add Filter API for status on coordinator actions
> ------------------------------------------------
>
> Key: OOZIE-677
> URL: https://issues.apache.org/jira/browse/OOZIE-677
> Project: Oozie
> Issue Type: Improvement
> Reporter: Virag Kothari
>
> Currently the filter option is only supported for 'oozie jobs'.
> In some cases, they are also required for 'oozie job'. E.g to filter coordinator actions for a coordinator job, filter coordinator jobs for a bundle etc.
> This jira proposes to provide status filters for coordinator actions on a coordinator job
> E.g oozie job -info coordjobid -filter status=RUNNING;status=KILLED
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OOZIE-677) Add Filter API for status on
coordinator actions
Posted by "Alejandro Abdelnur (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Abdelnur updated OOZIE-677:
-------------------------------------
Fix Version/s: 3.2.0
> Add Filter API for status on coordinator actions
> ------------------------------------------------
>
> Key: OOZIE-677
> URL: https://issues.apache.org/jira/browse/OOZIE-677
> Project: Oozie
> Issue Type: Improvement
> Reporter: Virag Kothari
> Fix For: 3.2.0
>
>
> Currently the filter option is only supported for 'oozie jobs'.
> In some cases, they are also required for 'oozie job'. E.g to filter coordinator actions for a coordinator job, filter coordinator jobs for a bundle etc.
> This jira proposes to provide status filters for coordinator actions on a coordinator job
> E.g oozie job -info coordjobid -filter status=RUNNING;status=KILLED
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-677) Add Filter API for status on
coordinator actions
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204849#comment-13204849 ]
jiraposter@reviews.apache.org commented on OOZIE-677:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3756/
-----------------------------------------------------------
(Updated 2012-02-09 20:53:48.865482)
Review request for oozie.
Changes
-------
Integrating Santhosh's comments. Fork/join came in the diff as the trunk was updated between diff1/diff2
Summary
-------
https://issues.apache.org/jira/browse/OOZIE-677
This addresses bug oozie-677.
https://issues.apache.org/jira/browse/oozie-677
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1242416
trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1242416
trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1242416
trunk/core/src/main/java/org/apache/oozie/BaseEngine.java 1242416
trunk/core/src/main/java/org/apache/oozie/BundleEngine.java 1242416
trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1242416
trunk/core/src/main/java/org/apache/oozie/DagEngine.java 1242416
trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1242416
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 1242416
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java 1242416
trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1242416
trunk/core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java 1242416
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 1242416
trunk/core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 1242416
trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1242416
Diff: https://reviews.apache.org/r/3756/diff
Testing
-------
Test cases added
Checked filter option thru. command line after running cron example
Thanks,
Virag
> Add Filter API for status on coordinator actions
> ------------------------------------------------
>
> Key: OOZIE-677
> URL: https://issues.apache.org/jira/browse/OOZIE-677
> Project: Oozie
> Issue Type: Improvement
> Reporter: Virag Kothari
>
> Currently the filter option is only supported for 'oozie jobs'.
> In some cases, they are also required for 'oozie job'. E.g to filter coordinator actions for a coordinator job, filter coordinator jobs for a bundle etc.
> This jira proposes to provide status filters for coordinator actions on a coordinator job
> E.g oozie job -info coordjobid -filter status=RUNNING;status=KILLED
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-677) Add Filter API for status on
coordinator actions
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204863#comment-13204863 ]
jiraposter@reviews.apache.org commented on OOZIE-677:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3756/#review4990
-----------------------------------------------------------
Ship it!
+1
- Santhosh
On 2012-02-09 20:53:48, Virag Kothari wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3756/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-09 20:53:48)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. https://issues.apache.org/jira/browse/OOZIE-677
bq.
bq.
bq. This addresses bug oozie-677.
bq. https://issues.apache.org/jira/browse/oozie-677
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1242416
bq. trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1242416
bq. trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1242416
bq. trunk/core/src/main/java/org/apache/oozie/BaseEngine.java 1242416
bq. trunk/core/src/main/java/org/apache/oozie/BundleEngine.java 1242416
bq. trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1242416
bq. trunk/core/src/main/java/org/apache/oozie/DagEngine.java 1242416
bq. trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1242416
bq. trunk/core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 1242416
bq. trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java 1242416
bq. trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1242416
bq. trunk/core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java 1242416
bq. trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 1242416
bq. trunk/core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 1242416
bq. trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1242416
bq.
bq. Diff: https://reviews.apache.org/r/3756/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Test cases added
bq. Checked filter option thru. command line after running cron example
bq.
bq.
bq. Thanks,
bq.
bq. Virag
bq.
bq.
> Add Filter API for status on coordinator actions
> ------------------------------------------------
>
> Key: OOZIE-677
> URL: https://issues.apache.org/jira/browse/OOZIE-677
> Project: Oozie
> Issue Type: Improvement
> Reporter: Virag Kothari
>
> Currently the filter option is only supported for 'oozie jobs'.
> In some cases, they are also required for 'oozie job'. E.g to filter coordinator actions for a coordinator job, filter coordinator jobs for a bundle etc.
> This jira proposes to provide status filters for coordinator actions on a coordinator job
> E.g oozie job -info coordjobid -filter status=RUNNING;status=KILLED
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-677) Add Filter API for status on
coordinator actions
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199931#comment-13199931 ]
jiraposter@reviews.apache.org commented on OOZIE-677:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3756/
-----------------------------------------------------------
Review request for oozie.
Summary
-------
https://issues.apache.org/jira/browse/OOZIE-677
This addresses bug oozie-677.
https://issues.apache.org/jira/browse/oozie-677
Diffs
-----
trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1240247
trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1240247
trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1240247
trunk/core/src/main/java/org/apache/oozie/BaseEngine.java 1240247
trunk/core/src/main/java/org/apache/oozie/BundleEngine.java 1240247
trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1240247
trunk/core/src/main/java/org/apache/oozie/DagEngine.java 1240247
trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1240247
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 1240247
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java 1240247
trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1240247
trunk/core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java 1240247
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 1240247
trunk/core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 1240247
trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1240247
Diff: https://reviews.apache.org/r/3756/diff
Testing
-------
Test cases added
Checked filter option thru. command line after running cron example
Thanks,
Virag
> Add Filter API for status on coordinator actions
> ------------------------------------------------
>
> Key: OOZIE-677
> URL: https://issues.apache.org/jira/browse/OOZIE-677
> Project: Oozie
> Issue Type: Improvement
> Reporter: Virag Kothari
>
> Currently the filter option is only supported for 'oozie jobs'.
> In some cases, they are also required for 'oozie job'. E.g to filter coordinator actions for a coordinator job, filter coordinator jobs for a bundle etc.
> This jira proposes to provide status filters for coordinator actions on a coordinator job
> E.g oozie job -info coordjobid -filter status=RUNNING;status=KILLED
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OOZIE-677) Add Filter API for status on
coordinator actions
Posted by "Virag Kothari (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Virag Kothari updated OOZIE-677:
--------------------------------
For the patch committed in trunk with this JIRA ID (also available under the same JIRA ID in Apache ReviewBoard system), I grant license to ASF for inclusion in ASF works (as per the Apache License ยง5)
> Add Filter API for status on coordinator actions
> ------------------------------------------------
>
> Key: OOZIE-677
> URL: https://issues.apache.org/jira/browse/OOZIE-677
> Project: Oozie
> Issue Type: Improvement
> Reporter: Virag Kothari
> Assignee: Virag Kothari
> Fix For: 3.2.0
>
>
> Currently the filter option is only supported for 'oozie jobs'.
> In some cases, they are also required for 'oozie job'. E.g to filter coordinator actions for a coordinator job, filter coordinator jobs for a bundle etc.
> This jira proposes to provide status filters for coordinator actions on a coordinator job
> E.g oozie job -info coordjobid -filter status=RUNNING;status=KILLED
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (OOZIE-677) Add Filter API for status on
coordinator actions
Posted by "Virag Kothari (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Virag Kothari resolved OOZIE-677.
---------------------------------
Resolution: Fixed
> Add Filter API for status on coordinator actions
> ------------------------------------------------
>
> Key: OOZIE-677
> URL: https://issues.apache.org/jira/browse/OOZIE-677
> Project: Oozie
> Issue Type: Improvement
> Reporter: Virag Kothari
>
> Currently the filter option is only supported for 'oozie jobs'.
> In some cases, they are also required for 'oozie job'. E.g to filter coordinator actions for a coordinator job, filter coordinator jobs for a bundle etc.
> This jira proposes to provide status filters for coordinator actions on a coordinator job
> E.g oozie job -info coordjobid -filter status=RUNNING;status=KILLED
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira