You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/01 11:34:52 UTC
[GitHub] [superset] andreas-eberle opened a new pull request #12862: feat: Make initial user configurable in helm chart
andreas-eberle opened a new pull request #12862:
URL: https://github.com/apache/superset/pull/12862
### SUMMARY
This PR updates the helm chart to allow easy configuration of the initial user via helm properties. At the moment, to not use the default admin/admin user, you have to download and modify the chart or to set a the complete init script. With these changes, username/password and the other user details can be set via normal helm properties.
The default behavior does not change.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [x] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #12862: feat: Make initial user configurable in helm chart
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12862:
URL: https://github.com/apache/superset/pull/12862#issuecomment-770832306
# [Codecov](https://codecov.io/gh/apache/superset/pull/12862?src=pr&el=h1) Report
> Merging [#12862](https://codecov.io/gh/apache/superset/pull/12862?src=pr&el=desc) (c66288d) into [master](https://codecov.io/gh/apache/superset/commit/9a7fba810e5bc3a94746117937163c1bfaea19ee?el=desc) (9a7fba8) will **decrease** coverage by `3.64%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12862?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12862 +/- ##
==========================================
- Coverage 67.04% 63.40% -3.65%
==========================================
Files 1022 489 -533
Lines 50186 30193 -19993
Branches 5204 0 -5204
==========================================
- Hits 33647 19143 -14504
+ Misses 16404 11050 -5354
+ Partials 135 0 -135
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.40% <ø> (-0.69%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12862?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12862/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12862/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12862/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-17.31%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12862/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12862/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12862/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `84.31% <0.00%> (-6.28%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12862/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12862/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `84.78% <0.00%> (-4.35%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12862/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `86.20% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12862/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.59% <0.00%> (-3.27%)` | :arrow_down: |
| ... and [543 more](https://codecov.io/gh/apache/superset/pull/12862/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12862?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12862?src=pr&el=footer). Last update [9a7fba8...c66288d](https://codecov.io/gh/apache/superset/pull/12862?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] amitmiran137 merged pull request #12862: feat: Make initial user configurable in helm chart
Posted by GitBox <gi...@apache.org>.
amitmiran137 merged pull request #12862:
URL: https://github.com/apache/superset/pull/12862
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12862: feat: Make initial user configurable in helm chart
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12862:
URL: https://github.com/apache/superset/pull/12862#issuecomment-770832306
# [Codecov](https://codecov.io/gh/apache/superset/pull/12862?src=pr&el=h1) Report
> Merging [#12862](https://codecov.io/gh/apache/superset/pull/12862?src=pr&el=desc) (7e89259) into [master](https://codecov.io/gh/apache/superset/commit/9a7fba810e5bc3a94746117937163c1bfaea19ee?el=desc) (9a7fba8) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 7e89259 differs from pull request most recent head 5e9c222. Consider uploading reports for the commit 5e9c222 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/12862?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12862 +/- ##
==========================================
- Coverage 67.04% 66.98% -0.06%
==========================================
Files 1022 1022
Lines 50186 50186
Branches 5204 5204
==========================================
- Hits 33647 33618 -29
- Misses 16404 16433 +29
Partials 135 135
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.82% <ø> (+<0.01%)` | :arrow_up: |
| javascript | `61.93% <ø> (ø)` | |
| python | `63.98% <ø> (-0.10%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12862?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12862/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.25% <0.00%> (-6.28%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12862/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.58% <0.00%> (-0.28%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/12862/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `93.65% <0.00%> (+1.58%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12862?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12862?src=pr&el=footer). Last update [9a7fba8...5e9c222](https://codecov.io/gh/apache/superset/pull/12862?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] amitmiran137 commented on a change in pull request #12862: feat: Make initial user configurable in helm chart
Posted by GitBox <gi...@apache.org>.
amitmiran137 commented on a change in pull request #12862:
URL: https://github.com/apache/superset/pull/12862#discussion_r597944296
##########
File path: helm/superset/values.yaml
##########
@@ -144,11 +150,12 @@ init:
superset init
echo "Creating admin user..."
superset fab create-admin \
- --username admin \
- --firstname Superset \
- --lastname Admin \
- --email admin@superset.com \
- --password admin || true
+ --username {{ .Values.init.user.username }} \
+ --firstname {{ .Values.init.user.firstname }} \
+ --lastname {{ .Values.init.user.lastname }} \
+ --email {{ .Values.init.user.email }} \
+ --password {{ .Values.init.user.password }} \
+ || true
Review comment:
```suggestion
--username {{ .Values.init.adminUser.username }} \
--firstname {{ .Values.init.adminUser.firstname }} \
--lastname {{ .Values.init.adminUser.lastname }} \
--email {{ .Values.init.adminUser.email }} \
--password {{ .Values.init.adminUser.password }} \
|| true
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] amitmiran137 commented on a change in pull request #12862: feat: Make initial user configurable in helm chart
Posted by GitBox <gi...@apache.org>.
amitmiran137 commented on a change in pull request #12862:
URL: https://github.com/apache/superset/pull/12862#discussion_r597944064
##########
File path: helm/superset/values.yaml
##########
@@ -128,6 +128,12 @@ init:
- ". {{ .Values.configMountPath }}/superset_bootstrap.sh; . {{ .Values.configMountPath }}/superset_init.sh"
enabled: true
loadExamples: false
+ user:
Review comment:
```suggestion
adminUser:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org