You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/12/10 16:42:41 UTC
[GitHub] [cloudstack] GabrielBrascher opened a new pull request #5763: Increase the length for parameters that expect a list of domain IDs.
GabrielBrascher opened a new pull request #5763:
URL: https://github.com/apache/cloudstack/pull/5763
### Description
This PR proposes setting a length for domain id parameters that allow passing a list of UUIDs separated by a comma. Allowing to run the API command in use-cases where there are many domain admins.
Currently when calling API command with multiple domain ids (for example `updateServiceOffering`) it leads to the following API error:
```
Error: (HTTP 431, error code 9999) Unable to execute API command updateserviceoffering due to invalid value.
Value greater than max allowed length 255 for param: domainIds"
```
I am targeting this implementation at 4.16.1.0 and considering it a bug due to the fact that we could not relly on the API to execute a few critical updates.
Admins end up either calling multiple times the API or (:warning: don't go this way) doing DB changes.
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [X] Trivial
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] wido commented on pull request #5763: Increase the length for parameters that expect a list of domain IDs.
Posted by GitBox <gi...@apache.org>.
wido commented on pull request #5763:
URL: https://github.com/apache/cloudstack/pull/5763#issuecomment-991317481
Aren't these calls also affected?
- https://cloudstack.apache.org/api/apidocs-4.16/apis/updateDiskOffering.html
- https://cloudstack.apache.org/api/apidocs-4.16/apis/updateNetworkOffering.html
- https://cloudstack.apache.org/api/apidocs-4.16/apis/updateBackupOffering.html
- https://cloudstack.apache.org/api/apidocs-4.16/apis/updateVPCOffering.html
They all have the 'domainid' parameter which probably needs to be updated as well.
These can all be assigned to multiple domains.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher closed pull request #5763: Increase the length for parameters that expect a list of domain IDs.
Posted by GitBox <gi...@apache.org>.
GabrielBrascher closed pull request #5763:
URL: https://github.com/apache/cloudstack/pull/5763
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5763: Increase the length for parameters that expect a list of domain IDs.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5763:
URL: https://github.com/apache/cloudstack/pull/5763#issuecomment-993893355
<b>Trillian test result (tid-2656)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32392 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5763-t2656-kvm-centos7.zip
Smoke tests completed. 90 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_08_arping_in_ssvm | `Failure` | 5.18 | test_diagnostics.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti merged pull request #5763: Increase the length for parameters that expect a list of domain IDs.
Posted by GitBox <gi...@apache.org>.
sureshanaparti merged pull request #5763:
URL: https://github.com/apache/cloudstack/pull/5763
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5763: Increase the length for parameters that expect a list of domain IDs.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5763:
URL: https://github.com/apache/cloudstack/pull/5763#issuecomment-993358273
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #5763: Increase the length for parameters that expect a list of domain IDs.
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #5763:
URL: https://github.com/apache/cloudstack/pull/5763#issuecomment-992451109
@wido you are right.
This PR already added the proposed change to the following API commands:
- https://cloudstack.apache.org/api/apidocs-4.16/apis/updateServiceOffering.html
- https://cloudstack.apache.org/api/apidocs-4.16/apis/updateDiskOffering.html
- https://cloudstack.apache.org/api/apidocs-4.16/apis/updateNetworkOffering.html
- https://cloudstack.apache.org/api/apidocs-4.16/apis/updateBackupOffering.html
- https://cloudstack.apache.org/api/apidocs-4.16/apis/updateVPCOffering.html
However, I did not add the parameter changes in:
- https://cloudstack.apache.org/api/apidocs-4.16/apis/updateBackupOffering.html
I will update the PR adding for this call as well.
Thanks for double-checking!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5763: Increase the length for parameters that expect a list of domain IDs.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5763:
URL: https://github.com/apache/cloudstack/pull/5763#issuecomment-993204751
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5763: Increase the length for parameters that expect a list of domain IDs.
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5763:
URL: https://github.com/apache/cloudstack/pull/5763#issuecomment-993357497
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5763: Increase the length for parameters that expect a list of domain IDs.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5763:
URL: https://github.com/apache/cloudstack/pull/5763#issuecomment-993276242
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #5763: Increase the length for parameters that expect a list of domain IDs.
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #5763:
URL: https://github.com/apache/cloudstack/pull/5763#issuecomment-992623675
@wido just updating that [updateBackupOffering](https://cloudstack.apache.org/api/apidocs-4.16/apis/updateBackupOffering.html) does not have domain IDs; therefore, so it does not need changes there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] wido commented on pull request #5763: Increase the length for parameters that expect a list of domain IDs.
Posted by GitBox <gi...@apache.org>.
wido commented on pull request #5763:
URL: https://github.com/apache/cloudstack/pull/5763#issuecomment-991317481
Aren't these calls also affected?
- https://cloudstack.apache.org/api/apidocs-4.16/apis/updateDiskOffering.html
- https://cloudstack.apache.org/api/apidocs-4.16/apis/updateNetworkOffering.html
- https://cloudstack.apache.org/api/apidocs-4.16/apis/updateBackupOffering.html
- https://cloudstack.apache.org/api/apidocs-4.16/apis/updateVPCOffering.html
They all have the 'domainid' parameter which probably needs to be updated as well.
These can all be assigned to multiple domains.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher edited a comment on pull request #5763: Increase the length for parameters that expect a list of domain IDs.
Posted by GitBox <gi...@apache.org>.
GabrielBrascher edited a comment on pull request #5763:
URL: https://github.com/apache/cloudstack/pull/5763#issuecomment-992623675
@wido just updating that [updateBackupOffering](https://cloudstack.apache.org/api/apidocs-4.16/apis/updateBackupOffering.html) does not have domain IDs; therefore, it does not need changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5763: Increase the length for parameters that expect a list of domain IDs.
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5763:
URL: https://github.com/apache/cloudstack/pull/5763#issuecomment-993204411
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5763: Increase the length for parameters that expect a list of domain IDs.
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5763:
URL: https://github.com/apache/cloudstack/pull/5763#issuecomment-994408397
code LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5763: Increase the length for parameters that expect a list of domain IDs.
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5763:
URL: https://github.com/apache/cloudstack/pull/5763#issuecomment-994472561
> Trillian test result (tid-2656) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 32392 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5763-t2656-kvm-centos7.zip Smoke tests completed. 90 look OK, 1 have errors Only failed tests results shown below:
>
> Test Result Time (s) Test File
> test_08_arping_in_ssvm `Failure` 5.18 test_diagnostics.py
Test failure ^^^ is not related to the changes in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org