[GitHub] knight9999 commented on a change in pull request #271: CB-7179 (iOS): Add WKWebView support for iOS

[GitBox <gi...@apache.org>]

knight9999 commented on a change in pull request #271: CB-7179 (iOS): Add WKWebView support for iOS
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/271#discussion_r225763050
 
 

 ##########
 File path: tests/plugin.xml
 ##########
 @@ -29,5 +29,12 @@
     <js-module src="tests.js" name="tests">
     </js-module>
 
+    <platform name="ios">
+      <!-- The WKWebView implementation for inappbrowser requires the presence of this plugin  -->
+      <dependency id="cordova-plugin-wkwebview-engine" />
+      <dependency id="cordova-plugin-wkwebview-engine-allowfileaccess" url="https://github.com/knight9999/cordova-plugin-wkwebview-engine-allowfileaccess.git" />
 
 Review comment:
   Now I have updated my plugin to change author 'Apache Cordova` and license `Apache-2.0`.
   But I think it is better to change github repository before publishing to npm. Now I am asking this to cordova members.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org