You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by "Alan Cabrera (Created) (JIRA)" <ji...@apache.org> on 2012/02/20 19:03:36 UTC
[jira] [Created] (OPENEJB-1783) Sometimes the list of URLs is too
large when searching for annotated classes.
Sometimes the list of URLs is too large when searching for annotated classes.
-----------------------------------------------------------------------------
Key: OPENEJB-1783
URL: https://issues.apache.org/jira/browse/OPENEJB-1783
Project: OpenEJB
Issue Type: Bug
Reporter: Alan Cabrera
Assignee: Alan Cabrera
There's no need to search the Java libraries and OpenEJB jars for user CLI extensions.
Create {{URLs.cullSystemAndOpenEJBJars(urls)}} and {{URLs.cullSystemJars(urls)}} which can be shared by other bits of code which seem to be cookie cutting this logic.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OPENEJB-1783) Sometimes the list of URLs is too
large when searching for annotated classes.
Posted by "Romain Manni-Bucau (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212014#comment-13212014 ]
Romain Manni-Bucau commented on OPENEJB-1783:
---------------------------------------------
it can easily be done adding to default.exclusions the good string or hardcoded in org.apache.openejb.config.NewLoaderLogic#applyBuiltinExcludes
> Sometimes the list of URLs is too large when searching for annotated classes.
> -----------------------------------------------------------------------------
>
> Key: OPENEJB-1783
> URL: https://issues.apache.org/jira/browse/OPENEJB-1783
> Project: OpenEJB
> Issue Type: Bug
> Reporter: Alan Cabrera
> Assignee: Alan Cabrera
>
> There's no need to search the Java libraries and OpenEJB jars for user CLI extensions. Some of the system jars are *huge* and causes an OOM error when scanning is performed.
> Create {{URLs.cullSystemAndOpenEJBJars(urls)}} and {{URLs.cullSystemJars(urls)}} which can be shared by other bits of code which seem to be cookie cutting this logic.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OPENEJB-1783) Sometimes the list of URLs is too
large when searching for annotated classes.
Posted by "Alan Cabrera (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212016#comment-13212016 ]
Alan Cabrera commented on OPENEJB-1783:
---------------------------------------
defualt.exclusions cannot handle:
urls = urls.exclude(ClassLoader.getSystemClassLoader().getParent());
urls = urls.excludeJavaExtDirs();
urls = urls.excludeJavaEndorsedDirs();
urls = urls.excludeJavaHome();
urls = urls.excludePaths(System.getProperty("sun.boot.class.path", ""));
> Sometimes the list of URLs is too large when searching for annotated classes.
> -----------------------------------------------------------------------------
>
> Key: OPENEJB-1783
> URL: https://issues.apache.org/jira/browse/OPENEJB-1783
> Project: OpenEJB
> Issue Type: Bug
> Reporter: Alan Cabrera
> Assignee: Alan Cabrera
>
> There's no need to search the Java libraries and OpenEJB jars for user CLI extensions. Some of the system jars are *huge* and causes an OOM error when scanning is performed.
> Create {{URLs.cullSystemAndOpenEJBJars(urls)}} and {{URLs.cullSystemJars(urls)}} which can be shared by other bits of code which seem to be cookie cutting this logic.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OPENEJB-1783) Sometimes the list of URLs is too
large when searching for annotated classes.
Posted by "Alan Cabrera (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan Cabrera updated OPENEJB-1783:
----------------------------------
Description:
There's no need to search the Java libraries and OpenEJB jars for user CLI extensions. Some of the system jars are *huge* and causes an OOM error when scanning is performed.
Create {{URLs.cullSystemAndOpenEJBJars(urls)}} and {{URLs.cullSystemJars(urls)}} which can be shared by other bits of code which seem to be cookie cutting this logic.
was:
There's no need to search the Java libraries and OpenEJB jars for user CLI extensions.
Create {{URLs.cullSystemAndOpenEJBJars(urls)}} and {{URLs.cullSystemJars(urls)}} which can be shared by other bits of code which seem to be cookie cutting this logic.
> Sometimes the list of URLs is too large when searching for annotated classes.
> -----------------------------------------------------------------------------
>
> Key: OPENEJB-1783
> URL: https://issues.apache.org/jira/browse/OPENEJB-1783
> Project: OpenEJB
> Issue Type: Bug
> Reporter: Alan Cabrera
> Assignee: Alan Cabrera
>
> There's no need to search the Java libraries and OpenEJB jars for user CLI extensions. Some of the system jars are *huge* and causes an OOM error when scanning is performed.
> Create {{URLs.cullSystemAndOpenEJBJars(urls)}} and {{URLs.cullSystemJars(urls)}} which can be shared by other bits of code which seem to be cookie cutting this logic.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OPENEJB-1783) Sometimes the list of URLs is too
large when searching for annotated classes.
Posted by "Alan Cabrera (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan Cabrera updated OPENEJB-1783:
----------------------------------
Attachment: urls.diff
This is my current thinking.
> Sometimes the list of URLs is too large when searching for annotated classes.
> -----------------------------------------------------------------------------
>
> Key: OPENEJB-1783
> URL: https://issues.apache.org/jira/browse/OPENEJB-1783
> Project: OpenEJB
> Issue Type: Bug
> Reporter: Alan Cabrera
> Assignee: Alan Cabrera
> Attachments: urls.diff
>
>
> There's no need to search the Java libraries and OpenEJB jars for user CLI extensions. Some of the system jars are *huge* and causes an OOM error when scanning is performed.
> Create {{URLs.cullSystemAndOpenEJBJars(urls)}} and {{URLs.cullSystemJars(urls)}} which can be shared by other bits of code which seem to be cookie cutting this logic.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work started] (OPENEJB-1783) Sometimes the list of URLs is
too large when searching for annotated classes.
Posted by "Alan Cabrera (Work started) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on OPENEJB-1783 started by Alan Cabrera.
> Sometimes the list of URLs is too large when searching for annotated classes.
> -----------------------------------------------------------------------------
>
> Key: OPENEJB-1783
> URL: https://issues.apache.org/jira/browse/OPENEJB-1783
> Project: OpenEJB
> Issue Type: Bug
> Reporter: Alan Cabrera
> Assignee: Alan Cabrera
>
> There's no need to search the Java libraries and OpenEJB jars for user CLI extensions. Some of the system jars are *huge* and causes an OOM error when scanning is performed.
> Create {{URLs.cullSystemAndOpenEJBJars(urls)}} and {{URLs.cullSystemJars(urls)}} which can be shared by other bits of code which seem to be cookie cutting this logic.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OPENEJB-1783) Sometimes the list of URLs is too
large when searching for annotated classes.
Posted by "David Blevins (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212033#comment-13212033 ]
David Blevins commented on OPENEJB-1783:
----------------------------------------
Let's call the util calls UrlSets for consistency and s/cull/exclude/.
Note that the default.exclusions doesn't use regexs, so we can't use that to exclude ".*/Library/Java.*". The previous version of the code did use regexs and turned out to be many times slower. The cost of the excludes practically erased the benefit from a pure speed perspective.
> Sometimes the list of URLs is too large when searching for annotated classes.
> -----------------------------------------------------------------------------
>
> Key: OPENEJB-1783
> URL: https://issues.apache.org/jira/browse/OPENEJB-1783
> Project: OpenEJB
> Issue Type: Bug
> Reporter: Alan Cabrera
> Assignee: Alan Cabrera
> Fix For: 4.0, 4.0.0-beta-3
>
> Attachments: urls.diff
>
>
> There's no need to search the Java libraries and OpenEJB jars for user CLI extensions. Some of the system jars are *huge* and causes an OOM error when scanning is performed.
> Create {{URLs.cullSystemAndOpenEJBJars(urls)}} and {{URLs.cullSystemJars(urls)}} which can be shared by other bits of code which seem to be cookie cutting this logic.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OPENEJB-1783) Sometimes the list of URLs is too
large when searching for annotated classes.
Posted by "David Blevins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264855#comment-13264855 ]
David Blevins commented on OPENEJB-1783:
----------------------------------------
2012-02-20 - http://svn.apache.org/viewvc?view=revision&revision=1291412 - adc
> Sometimes the list of URLs is too large when searching for annotated classes.
> -----------------------------------------------------------------------------
>
> Key: OPENEJB-1783
> URL: https://issues.apache.org/jira/browse/OPENEJB-1783
> Project: OpenEJB
> Issue Type: Bug
> Reporter: Alan Cabrera
> Assignee: Alan Cabrera
> Fix For: 4.0, 4.0.0
>
> Attachments: urls.diff
>
>
> There's no need to search the Java libraries and OpenEJB jars for user CLI extensions. Some of the system jars are *huge* and causes an OOM error when scanning is performed.
> Create {{URLs.cullSystemAndOpenEJBJars(urls)}} and {{URLs.cullSystemJars(urls)}} which can be shared by other bits of code which seem to be cookie cutting this logic.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OPENEJB-1783) Sometimes the list of URLs is too
large when searching for annotated classes.
Posted by "Alan Cabrera (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan Cabrera updated OPENEJB-1783:
----------------------------------
Fix Version/s: 4.0.0-beta-3
4.0
> Sometimes the list of URLs is too large when searching for annotated classes.
> -----------------------------------------------------------------------------
>
> Key: OPENEJB-1783
> URL: https://issues.apache.org/jira/browse/OPENEJB-1783
> Project: OpenEJB
> Issue Type: Bug
> Reporter: Alan Cabrera
> Assignee: Alan Cabrera
> Fix For: 4.0, 4.0.0-beta-3
>
> Attachments: urls.diff
>
>
> There's no need to search the Java libraries and OpenEJB jars for user CLI extensions. Some of the system jars are *huge* and causes an OOM error when scanning is performed.
> Create {{URLs.cullSystemAndOpenEJBJars(urls)}} and {{URLs.cullSystemJars(urls)}} which can be shared by other bits of code which seem to be cookie cutting this logic.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira