You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2019/06/27 19:40:32 UTC

[GitHub] [storm] krichter722 commented on a change in pull request #3037: STORM-3420: Fix checkstyle violations in storm-mqtt

krichter722 commented on a change in pull request #3037: STORM-3420: Fix checkstyle violations in storm-mqtt
URL: https://github.com/apache/storm/pull/3037#discussion_r298338698
 
 

 ##########
 File path: external/storm-mqtt/src/main/java/org/apache/storm/mqtt/common/MqttOptions.java
 ##########
 @@ -88,7 +87,7 @@ public String getWillTopic() {
      * If set the server will publish the client's Will message to the specified topics if the client has an unexpected
      * disconnection.
      *
-     * @param willTopic
+     * @param willTopic the will topic
 
 Review comment:
   Good catch. I though that parameters would be enforced as soon as Javadoc is present. I agree 110% that those are pointless.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services