You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Mladen Turk <mt...@apache.org> on 2014/02/26 09:45:14 UTC
[VOTE] Release Apache Tomcat Connectors 1.2.38
Hi,
Apache Tomcat Connectors 1.2.38 release candidate is ready
for vote at [1]. This version fixes few bugs found in released
version 1.2.37 and adds some new features like IPV6 support.
The VOTE will remain open for at least 48 hours.
The Apache Tomcat Connectors 1.2.38 is
[ ] Stable, go ahead and release
[ ] Broken because of ...
[1] http://people.apache.org/~mturk/tomcat-connectors/jk-1.2.38/
Regards
--
^TM
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat Connectors 1.2.38
Posted by Mladen Turk <mt...@apache.org>.
On 02/26/2014 02:30 PM, Rainer Jung wrote:
> On 26.02.2014 11:48, Mladen Turk wrote:
>
> native/nt_service/jk_nt_service.c still uses jk_resolve() with
> sockaddr_in instead of tne new jk struct. Should we remove
> native/nt_service or apply the probably simple fix to make it compatible
> with the new jk structs? I'd say we can drop it but should add it to
> changes and news. I don't remember anyone having askes about it for many
> years and I'm not even convinced it worked in 1.2.37.
>
Yes. We should have drop this a long time ago.
I'll axe the code and add the changelog entry.
> JK_INET / JK_INET6: it looks a bit confusing to me.
> - JK_INET is set to APR_INET in the APR case
> - JK_INET6 is always set to AF_INET6 in the IPv6 case,
> even when APR is used
Fixed that. Although all the same since APR_INET6 is always AF_INET6
>
> There are two places in common/jk_connect.c which use APR_HAVE_IPV6 and
> not JK_HAVE_IPV6. is this intentional?
>
Yes, both APR_HAVE_IPV6 and APR_INET/APR_INET6 usage is intentional to have
clarity inside strictly APR code. Those flags are the same anyhow.
Regards
--
^TM
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat Connectors 1.2.38
Posted by Rainer Jung <ra...@kippdata.de>.
On 26.02.2014 11:48, Mladen Turk wrote:
> On 02/26/2014 11:18 AM, Rainer Jung wrote:
>>
>> No other finding currently, but still checking some stuff. Just wanted
>> to let you know quickly.
>>
>
> OK. Give it a try. I'll just retag 1.2.39 with all the "polishing" stuff
> found. It's been a while since last release, so I was prepared for few
> runs :)
NP.
A few polishing items and questions:
You might want to add something about your IPV6 improvements to the
change log. There's the prefer flag and also the possibility to use IPv6
addresses in the config, right? More?
configure.in now checks for netdb.h and netinet/in.h but I couldn't find
any use of those in the final code (except for old use in Netware case
which doesn't rely on configure detection). Should we remove the new
detection code for those two headers?
native/nt_service/jk_nt_service.c still uses jk_resolve() with
sockaddr_in instead of tne new jk struct. Should we remove
native/nt_service or apply the probably simple fix to make it compatible
with the new jk structs? I'd say we can drop it but should add it to
changes and news. I don't remember anyone having askes about it for many
years and I'm not even convinced it worked in 1.2.37.
JK_INET / JK_INET6: it looks a bit confusing to me.
- JK_INET is set to APR_INET in the APR case
- JK_INET6 is always set to AF_INET6 in the IPv6 case,
even when APR is used
- jk_connect.c uses JK_INET / JK_INET6 in the non-APR case,
but a mixture pf APR_INET / APR_INET6 and JK_INET / JK_INET6
in the APR case. I didn't find a functional problem due to
the JK and APR stuff at the end being the same,
but it looks confusing. Shouldn't we replace all APR_INET and
APR_INET6 by JK_INET resp. JK_INET6 in teh code and set JK_INET6
similar to JK_INET depending on APR (=APR_INET6) or non-APR
(=AF_INET6)?
There are two places in common/jk_connect.c which use APR_HAVE_IPV6 and
not JK_HAVE_IPV6. is this intentional?
Regards,
Rainer
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat Connectors 1.2.38
Posted by Mladen Turk <mt...@apache.org>.
On 02/26/2014 11:18 AM, Rainer Jung wrote:
>
> No other finding currently, but still checking some stuff. Just wanted
> to let you know quickly.
>
OK. Give it a try. I'll just retag 1.2.39 with all the "polishing" stuff
found. It's been a while since last release, so I was prepared for few runs :)
Regards
--
^TM
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat Connectors 1.2.38
Posted by Rainer Jung <ra...@kippdata.de>.
On 26.02.2014 09:45, Mladen Turk wrote:
> Hi,
>
> Apache Tomcat Connectors 1.2.38 release candidate is ready
> for vote at [1]. This version fixes few bugs found in released
> version 1.2.37 and adds some new features like IPV6 support.
>
>
> The VOTE will remain open for at least 48 hours.
>
> The Apache Tomcat Connectors 1.2.38 is
> [ ] Stable, go ahead and release
> [ ] Broken because of ...
>
>
>
> [1] http://people.apache.org/~mturk/tomcat-connectors/jk-1.2.38/
In jk_version.h the define for JK_VERISRELEASE is 0, which means the
version strings will say 1.2.38-rc-0 instead of 1.2.38.
No other finding currently, but still checking some stuff. Just wanted
to let you know quickly.
Regards,
Rainer
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat Connectors 1.2.38
Posted by Mladen Turk <mt...@apache.org>.
On 02/26/2014 09:55 AM, jean-frederic clere wrote:
> On 02/26/2014 09:45 AM, Mladen Turk wrote:
> +++
> /home/jfclere/APACHE-2.2.21/build/libtool --silent --mode=compile gcc -I/home/jfclere/APACHE-2.2.21/include -DHAVE_CONFIG_H -ansi -pedantic -Wno-long-long -Wall -pthread -DHAVE_APR -I/home/jfclere/APACHE-2.2.21/include
> -I/home/jfclere/APACHE-2.2.21/include -DHAVE_CONFIG_H -D_REENTRANT -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -c jk_lb_worker.c -o jk_lb_worker.lo
> jk_lb_worker.c: In function ‘get_sessionid’:
> jk_lb_worker.c:516:5: error: expected expression before ‘/’ token
> // set session_path
> ^
> jk_lb_worker.c:519:5: error: expected expression before ‘/’ token
> // set session_cookie
> ^
> make[1]: *** [jk_lb_worker.lo] Error 1
> +++
>
get rid of '-pedentic' compiler flag.
This was applied by Rainer back in 2011
so we had few releases with that code already.
Regards
--
^TM
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat Connectors 1.2.38
Posted by jean-frederic clere <jf...@gmail.com>.
On 02/26/2014 09:45 AM, Mladen Turk wrote:
> Hi,
>
> Apache Tomcat Connectors 1.2.38 release candidate is ready
> for vote at [1]. This version fixes few bugs found in released
> version 1.2.37 and adds some new features like IPV6 support.
>
>
> The VOTE will remain open for at least 48 hours.
>
> The Apache Tomcat Connectors 1.2.38 is
> [ ] Stable, go ahead and release
> [ ] Broken because of ...
>
With httpd-2.2.21 on fedora20:
+++
/home/jfclere/APACHE-2.2.21/build/libtool --silent --mode=compile gcc
-I/home/jfclere/APACHE-2.2.21/include -DHAVE_CONFIG_H -ansi -pedantic
-Wno-long-long -Wall -pthread -DHAVE_APR
-I/home/jfclere/APACHE-2.2.21/include
-I/home/jfclere/APACHE-2.2.21/include -DHAVE_CONFIG_H -D_REENTRANT
-D_GNU_SOURCE -D_LARGEFILE64_SOURCE -c jk_lb_worker.c -o jk_lb_worker.lo
jk_lb_worker.c: In function ‘get_sessionid’:
jk_lb_worker.c:516:5: error: expected expression before ‘/’ token
// set session_path
^
jk_lb_worker.c:519:5: error: expected expression before ‘/’ token
// set session_cookie
^
make[1]: *** [jk_lb_worker.lo] Error 1
+++
Cheers
Jean-Frederic
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [CANCELED] Was: [VOTE] Release Apache Tomcat Connectors 1.2.38
Posted by Mladen Turk <mt...@apache.org>.
On 02/26/2014 06:10 PM, Rainer Jung wrote:
> On 26.02.2014 17:19, Mladen Turk wrote:
>> Due to some issues found this vote is canceled
>>
>> Should I retag 1.2.38 or create 1.2.39?
>
> I'd slightly prefer we switch to 1.2.39 to ensure noone is using the
> obsolete 1.2.38 instead of the released code.
>
>> If later can we use the
>> section name="Changes between 1.2.37 and 1.2.39"
>> in the changelog since 1.2.38 was not released?
>
> OK for me. We should note the "missing" 1.2.38 in the release
> announcement though.
>
... and in the STATUS as 'not released'
Regards
--
^TM
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [CANCELED] Was: [VOTE] Release Apache Tomcat Connectors 1.2.38
Posted by Rainer Jung <ra...@kippdata.de>.
On 26.02.2014 17:19, Mladen Turk wrote:
> Due to some issues found this vote is canceled
>
> Should I retag 1.2.38 or create 1.2.39?
I'd slightly prefer we switch to 1.2.39 to ensure noone is using the
obsolete 1.2.38 instead of the released code.
> If later can we use the
> section name="Changes between 1.2.37 and 1.2.39"
> in the changelog since 1.2.38 was not released?
OK for me. We should note the "missing" 1.2.38 in the release
announcement though.
Thanks!
Rainer
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[CANCELED] Was: [VOTE] Release Apache Tomcat Connectors 1.2.38
Posted by Mladen Turk <mt...@apache.org>.
Due to some issues found this vote is canceled
Should I retag 1.2.38 or create 1.2.39?
If later can we use the
section name="Changes between 1.2.37 and 1.2.39"
in the changelog since 1.2.38 was not released?
On 02/26/2014 09:45 AM, Mladen Turk wrote:
> Hi,
>
> Apache Tomcat Connectors 1.2.38 release candidate is ready
> for vote at [1]. This version fixes few bugs found in released
> version 1.2.37 and adds some new features like IPV6 support.
>
Regards
--
^TM
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org