You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/08/02 07:44:04 UTC
[GitHub] [incubator-eventmesh] walterlife opened a new pull request, #1067: [ISSUE #1064]Fix NullPointException Of ClientManageControllerTest
walterlife opened a new pull request, #1067:
URL: https://github.com/apache/incubator-eventmesh/pull/1067
Fixes ISSUE #1064 .
### Motivation
When running the ClientManageController unit test, NPE will appear. The reason is that due to the new Webhook feature, it is necessary to add related Mock adaptations.
### Modifications
add AdminWebHookConfigOperationManage mock logic in ClientManageController unit test file.
### Documentation
modify unit test,no need to add new documents
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 merged pull request #1067: [ISSUE #1064]Fix NullPointException Of ClientManageControllerTest
Posted by GitBox <gi...@apache.org>.
xwm1992 merged PR #1067:
URL: https://github.com/apache/incubator-eventmesh/pull/1067
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov[bot] commented on pull request #1067: [ISSUE #1064]Fix NullPointException Of ClientManageControllerTest
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #1067:
URL: https://github.com/apache/incubator-eventmesh/pull/1067#issuecomment-1202234450
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/1067?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1067](https://codecov.io/gh/apache/incubator-eventmesh/pull/1067?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (80dd6e8) into [master](https://codecov.io/gh/apache/incubator-eventmesh/commit/e7ba6e2dcc2e0bce787b3bbb2b678f07b1032e44?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e7ba6e2) will **decrease** coverage by `0.06%`.
> The diff coverage is `4.44%`.
```diff
@@ Coverage Diff @@
## master #1067 +/- ##
===========================================
- Coverage 9.72% 9.65% -0.07%
+ Complexity 614 613 -1
===========================================
Files 363 374 +11
Lines 23130 23302 +172
Branches 2551 2582 +31
===========================================
+ Hits 2249 2250 +1
- Misses 20677 20845 +168
- Partials 204 207 +3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/1067?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/eventmesh/common/config/CommonConfiguration.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1067/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9jb25maWcvQ29tbW9uQ29uZmlndXJhdGlvbi5qYXZh) | `79.68% <0.00%> (-1.27%)` | :arrow_down: |
| [.../eventmesh/common/config/ConfigurationWrapper.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1067/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9jb25maWcvQ29uZmlndXJhdGlvbldyYXBwZXIuamF2YQ==) | `38.88% <0.00%> (-11.12%)` | :arrow_down: |
| [.../protocol/http/WebhookProtocolTransportObject.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1067/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL1dlYmhvb2tQcm90b2NvbFRyYW5zcG9ydE9iamVjdC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../common/protocol/http/common/EventMeshRetCode.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1067/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2NvbW1vbi9FdmVudE1lc2hSZXRDb2RlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...che/eventmesh/runtime/boot/AbstractHTTPServer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1067/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2Jvb3QvQWJzdHJhY3RIVFRQU2VydmVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...he/eventmesh/runtime/boot/EventMeshHTTPServer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1067/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2Jvb3QvRXZlbnRNZXNoSFRUUFNlcnZlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...che/eventmesh/runtime/boot/EventMeshTCPServer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1067/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2Jvb3QvRXZlbnRNZXNoVENQU2VydmVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...a/org/apache/eventmesh/runtime/boot/HTTPTrace.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1067/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2Jvb3QvSFRUUFRyYWNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...time/configuration/EventMeshHTTPConfiguration.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1067/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvbmZpZ3VyYXRpb24vRXZlbnRNZXNoSFRUUENvbmZpZ3VyYXRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...me/core/protocol/grpc/push/WebhookPushRequest.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1067/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvZ3JwYy9wdXNoL1dlYmhvb2tQdXNoUmVxdWVzdC5qYXZh) | `0.00% <0.00%> (ø)` | |
| ... and [40 more](https://codecov.io/gh/apache/incubator-eventmesh/pull/1067/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org