[PATCH] mod_deflate.c

[André Malo <nd...@perlig.de>]

The current behaviour of mod_deflate is to set the Vary: Accept-Encoding 
header dependant on the fact, whether the client sent Accept-Encoding: gzip 
or not.

However, I think, that behaviour is not correct. At the time, the DEFLATE 
filter is activated, the resource actually /does/ vary on Accept-Encoding. 
Independant from what the client accepts or not. The attached patch moves 
the Vary header setting to the time before the filter checks the supplied 
Accept-Encoding but after the time, it checks whether the stream is already 
compressed (and probably already correct labeled with a Vary header).

nd
-- 
die (eval q-qq:Just Another Perl Hacker
:-)

# André Malo, <http://www.perlig.de/> #

Re: [PATCH] mod_deflate.c

[Justin Erenkrantz <je...@apache.org>]

--On Sunday, November 10, 2002 12:24 AM +0100 André Malo 
<nd...@perlig.de> wrote:

> The current behaviour of mod_deflate is to set the Vary:
> Accept-Encoding  header dependant on the fact, whether the client
> sent Accept-Encoding: gzip  or not.
>
> However, I think, that behaviour is not correct. At the time, the

Fair enough - I'm convinced.  =)

Committed.  Thanks!  -- justin