You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by pe...@apache.org on 2021/12/20 16:30:28 UTC
[pulsar] 17/19: remove unnecessary string operation (#12719)
This is an automated email from the ASF dual-hosted git repository.
penghui pushed a commit to branch branch-2.9
in repository https://gitbox.apache.org/repos/asf/pulsar.git
commit 502f1431b5cecf5a19330473a0ebb67918c5b0b1
Author: gaozhangmin <ga...@qq.com>
AuthorDate: Mon Nov 15 08:53:21 2021 +0800
remove unnecessary string operation (#12719)
(cherry picked from commit 4cf4b85a353c726725673201bdc9cce5f5442e53)
---
.../src/main/java/org/apache/pulsar/broker/cache/BundlesQuotas.java | 2 +-
.../main/java/org/apache/pulsar/client/admin/internal/TopicsImpl.java | 2 +-
.../src/main/java/org/apache/pulsar/admin/cli/CmdSchemas.java | 4 ++--
.../src/main/java/org/apache/pulsar/admin/cli/PulsarAdminTool.java | 2 +-
.../src/main/java/org/apache/pulsar/common/net/ServiceURI.java | 2 +-
.../java/org/apache/pulsar/testclient/DefaultMessageFormatter.java | 2 +-
6 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/pulsar-broker/src/main/java/org/apache/pulsar/broker/cache/BundlesQuotas.java b/pulsar-broker/src/main/java/org/apache/pulsar/broker/cache/BundlesQuotas.java
index 251203e..88ddaf1 100644
--- a/pulsar-broker/src/main/java/org/apache/pulsar/broker/cache/BundlesQuotas.java
+++ b/pulsar-broker/src/main/java/org/apache/pulsar/broker/cache/BundlesQuotas.java
@@ -73,7 +73,7 @@ public class BundlesQuotas {
}
public CompletableFuture<ResourceQuota> getResourceQuota(String bundle) {
- return resourceQuotaCache.get(RESOURCE_QUOTA_ROOT + "/" + bundle.toString())
+ return resourceQuotaCache.get(RESOURCE_QUOTA_ROOT + "/" + bundle)
.thenCompose(optResourceQuota -> {
if (optResourceQuota.isPresent()) {
return CompletableFuture.completedFuture(optResourceQuota.get());
diff --git a/pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/TopicsImpl.java b/pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/TopicsImpl.java
index caf32e4..57f3699 100644
--- a/pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/TopicsImpl.java
+++ b/pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/TopicsImpl.java
@@ -1602,7 +1602,7 @@ public class TopicsImpl extends BaseResource implements Topics {
} else {
brokerEntryMetadata = new BrokerEntryMetadata();
if (brokerEntryTimestamp != null) {
- brokerEntryMetadata.setBrokerTimestamp(DateFormatter.parse(brokerEntryTimestamp.toString()));
+ brokerEntryMetadata.setBrokerTimestamp(DateFormatter.parse(brokerEntryTimestamp));
}
if (brokerEntryIndex != null) {
diff --git a/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSchemas.java b/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSchemas.java
index 302f6e2..9575ec6 100644
--- a/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSchemas.java
+++ b/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSchemas.java
@@ -139,10 +139,10 @@ public class CmdSchemas extends CmdBase {
.withPojo(cls)
.withAlwaysAllowNull(alwaysAllowNull)
.build();
- if (type.toLowerCase().equalsIgnoreCase("avro")) {
+ if (type.equalsIgnoreCase("avro")) {
input.setType("AVRO");
input.setSchema(SchemaExtractor.getAvroSchemaInfo(schemaDefinition));
- } else if (type.toLowerCase().equalsIgnoreCase("json")){
+ } else if (type.equalsIgnoreCase("json")){
input.setType("JSON");
input.setSchema(SchemaExtractor.getJsonSchemaInfo(schemaDefinition));
}
diff --git a/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/PulsarAdminTool.java b/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/PulsarAdminTool.java
index a41f444..d0f514d 100644
--- a/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/PulsarAdminTool.java
+++ b/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/PulsarAdminTool.java
@@ -317,7 +317,7 @@ public class PulsarAdminTool {
}
++cmdPos;
- boolean isLocalRun = cmdPos < args.length && "localrun".equals(args[cmdPos].toLowerCase());
+ boolean isLocalRun = cmdPos < args.length && "localrun".equalsIgnoreCase(args[cmdPos]);
Function<PulsarAdminBuilder, ? extends PulsarAdmin> adminFactory;
if (isLocalRun) {
diff --git a/pulsar-common/src/main/java/org/apache/pulsar/common/net/ServiceURI.java b/pulsar-common/src/main/java/org/apache/pulsar/common/net/ServiceURI.java
index 16a070d..f52afbc 100644
--- a/pulsar-common/src/main/java/org/apache/pulsar/common/net/ServiceURI.java
+++ b/pulsar-common/src/main/java/org/apache/pulsar/common/net/ServiceURI.java
@@ -219,7 +219,7 @@ public class ServiceURI {
case BINARY_SERVICE:
if (serviceInfos.length == 0) {
port = BINARY_PORT;
- } else if (serviceInfos.length == 1 && serviceInfos[0].toLowerCase().equals(SSL_SERVICE)) {
+ } else if (serviceInfos.length == 1 && serviceInfos[0].equalsIgnoreCase(SSL_SERVICE)) {
port = BINARY_TLS_PORT;
} else {
throw new IllegalArgumentException("Invalid pulsar service : " + serviceName + "+"
diff --git a/pulsar-testclient/src/main/java/org/apache/pulsar/testclient/DefaultMessageFormatter.java b/pulsar-testclient/src/main/java/org/apache/pulsar/testclient/DefaultMessageFormatter.java
index e619a00..bf183a6 100644
--- a/pulsar-testclient/src/main/java/org/apache/pulsar/testclient/DefaultMessageFormatter.java
+++ b/pulsar-testclient/src/main/java/org/apache/pulsar/testclient/DefaultMessageFormatter.java
@@ -50,7 +50,7 @@ public class DefaultMessageFormatter implements IMessageFormatter {
break;
}
if (i != 1) {
- size = Float.valueOf(new String(sMessage.substring(idx+1,idx+i)));
+ size = Float.parseFloat(sMessage.substring(idx + 1, idx + i));
}
String sub = sMessage.substring(idx, idx+i+1);