[GitHub] [cassandra-dtest] maedhroz commented on a change in pull request #149: Update timer metrics assertion for Cassandra-16760

[GitBox <gi...@apache.org>]

maedhroz commented on a change in pull request #149:
URL: https://github.com/apache/cassandra-dtest/pull/149#discussion_r664833508



##########
File path: client_request_metrics_test.py
##########
@@ -777,6 +783,11 @@ def is_histo_list(k, l):
     assert len(l) == 165, k
     assert all(isinstance(i, int) for i in l), k
 
+def is_timer_histo_list(k, l):

Review comment:
       nit: Maybe we could just add a named parameter to `is_histo_list` (ex. `is_histo_list(k, l, len)`) and use `partial()` above at the call site? (see https://docs.python.org/3/library/functools.html#functools.partial)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org