[GitHub] [orc] mystic-lama commented on a diff in pull request #1574: Fix zero copy read bugs

["mystic-lama (via GitHub)" <gi...@apache.org>]

mystic-lama commented on code in PR #1574:
URL: https://github.com/apache/orc/pull/1574#discussion_r1287200808


##########
java/core/src/java/org/apache/orc/DataReader.java:
##########
@@ -52,10 +52,9 @@ BufferChunkList readFileData(BufferChunkList range,
   boolean isTrackingDiskRanges();
 
   /**
-   * Releases buffers created by readFileData. See readFileData javadoc.
-   * @param toRelease The buffer to release.
+   * Releases all buffers created by readFileData. See readFileData javadoc.
    */
-  void releaseBuffer(ByteBuffer toRelease);
+  void releaseAllBuffers();

Review Comment:
   This will be a breaking change, do we need to remove the public API?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org