You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2018/05/31 00:03:18 UTC
[Impala-ASF-CR] IMPALA-5380: [DOCS] Added additional filesystems supported in URI
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10551
Change subject: IMPALA-5380: [DOCS] Added additional filesystems supported in URI
......................................................................
IMPALA-5380: [DOCS] Added additional filesystems supported in URI
Change-Id: I11d57efd564fb5779539a88d7b209cee93d313c6
---
M docs/topics/impala_authorization.xml
1 file changed, 9 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/10551/1
--
To view, visit http://gerrit.cloudera.org:8080/10551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I11d57efd564fb5779539a88d7b209cee93d313c6
Gerrit-Change-Number: 10551
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
[Impala-ASF-CR] IMPALA-5380: [DOCS] Added additional filesystems supported in URI
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10551 )
Change subject: IMPALA-5380: [DOCS] Added additional filesystems supported in URI
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10551/2/docs/topics/impala_authorization.xml
File docs/topics/impala_authorization.xml:
http://gerrit.cloudera.org:8080/#/c/10551/2/docs/topics/impala_authorization.xml@923
PS2, Line 923: URIs for HDFS, you must also specify the NameNode. For example: <codeblock>data_read = server=server1->uri=file:///path/to/dir, \
> nit: can you wrap the lines?
Done
--
To view, visit http://gerrit.cloudera.org:8080/10551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11d57efd564fb5779539a88d7b209cee93d313c6
Gerrit-Change-Number: 10551
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Jun 2018 17:59:26 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5380: [DOCS] Added additional filesystems supported in URI
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10551 )
Change subject: IMPALA-5380: [DOCS] Added additional filesystems supported in URI
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10551/3/docs/topics/impala_authorization.xml
File docs/topics/impala_authorization.xml:
http://gerrit.cloudera.org:8080/#/c/10551/3/docs/topics/impala_authorization.xml@921
PS3, Line 921: If a URI starts with anything else, it will
: cause an exception
> I don't think this is correct. If a URI starts with an absolute path, it wi
The sentence was updated.
--
To view, visit http://gerrit.cloudera.org:8080/10551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11d57efd564fb5779539a88d7b209cee93d313c6
Gerrit-Change-Number: 10551
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Jun 2018 18:46:35 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5380: [DOCS] Added additional filesystems supported in URI
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10551 )
Change subject: IMPALA-5380: [DOCS] Added additional filesystems supported in URI
......................................................................
IMPALA-5380: [DOCS] Added additional filesystems supported in URI
Change-Id: I11d57efd564fb5779539a88d7b209cee93d313c6
---
M docs/topics/impala_authorization.xml
1 file changed, 9 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/10551/2
--
To view, visit http://gerrit.cloudera.org:8080/10551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I11d57efd564fb5779539a88d7b209cee93d313c6
Gerrit-Change-Number: 10551
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
[Impala-ASF-CR] IMPALA-5380: [DOCS] Added additional filesystems supported in URI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10551 )
Change subject: IMPALA-5380: [DOCS] Added additional filesystems supported in URI
......................................................................
IMPALA-5380: [DOCS] Added additional filesystems supported in URI
Change-Id: I11d57efd564fb5779539a88d7b209cee93d313c6
Reviewed-on: http://gerrit.cloudera.org:8080/10551
Reviewed-by: Lars Volker <lv...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M docs/topics/impala_authorization.xml
1 file changed, 33 insertions(+), 12 deletions(-)
Approvals:
Lars Volker: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/10551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I11d57efd564fb5779539a88d7b209cee93d313c6
Gerrit-Change-Number: 10551
Gerrit-PatchSet: 7
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] IMPALA-5380: [DOCS] Added additional filesystems supported in URI
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10551 )
Change subject: IMPALA-5380: [DOCS] Added additional filesystems supported in URI
......................................................................
Patch Set 2:
Hi Lars,
Could you review the patch and approve the changes?
Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/10551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11d57efd564fb5779539a88d7b209cee93d313c6
Gerrit-Change-Number: 10551
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Jun 2018 20:33:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5380: [DOCS] Added additional filesystems supported in URI
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Lars Volker, Fredy Wijaya, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10551
to look at the new patch set (#6).
Change subject: IMPALA-5380: [DOCS] Added additional filesystems supported in URI
......................................................................
IMPALA-5380: [DOCS] Added additional filesystems supported in URI
Change-Id: I11d57efd564fb5779539a88d7b209cee93d313c6
---
M docs/topics/impala_authorization.xml
1 file changed, 33 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/10551/6
--
To view, visit http://gerrit.cloudera.org:8080/10551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I11d57efd564fb5779539a88d7b209cee93d313c6
Gerrit-Change-Number: 10551
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] IMPALA-5380: [DOCS] Added additional filesystems supported in URI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10551 )
Change subject: IMPALA-5380: [DOCS] Added additional filesystems supported in URI
......................................................................
Patch Set 6: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/10551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11d57efd564fb5779539a88d7b209cee93d313c6
Gerrit-Change-Number: 10551
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Jun 2018 21:30:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5380: [DOCS] Added additional filesystems supported in URI
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Lars Volker, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10551
to look at the new patch set (#3).
Change subject: IMPALA-5380: [DOCS] Added additional filesystems supported in URI
......................................................................
IMPALA-5380: [DOCS] Added additional filesystems supported in URI
Change-Id: I11d57efd564fb5779539a88d7b209cee93d313c6
---
M docs/topics/impala_authorization.xml
1 file changed, 11 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/10551/3
--
To view, visit http://gerrit.cloudera.org:8080/10551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I11d57efd564fb5779539a88d7b209cee93d313c6
Gerrit-Change-Number: 10551
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] IMPALA-5380: [DOCS] Added additional filesystems supported in URI
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10551 )
Change subject: IMPALA-5380: [DOCS] Added additional filesystems supported in URI
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10551/5/docs/topics/impala_authorization.xml
File docs/topics/impala_authorization.xml:
http://gerrit.cloudera.org:8080/#/c/10551/5/docs/topics/impala_authorization.xml@924
PS5, Line 924: will be automatically appended
> nit: It seems to be prepended, no? You could also rephrase as "If..., it wi
You could even include the example from Fredy's comment.
--
To view, visit http://gerrit.cloudera.org:8080/10551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11d57efd564fb5779539a88d7b209cee93d313c6
Gerrit-Change-Number: 10551
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Jun 2018 18:57:41 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5380: [DOCS] Added additional filesystems supported in URI
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10551 )
Change subject: IMPALA-5380: [DOCS] Added additional filesystems supported in URI
......................................................................
Patch Set 5:
Lars,
Could you +2 this? I try not to +2 my own commits.
Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/10551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11d57efd564fb5779539a88d7b209cee93d313c6
Gerrit-Change-Number: 10551
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Jun 2018 18:49:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5380: [DOCS] Added additional filesystems supported in URI
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10551 )
Change subject: IMPALA-5380: [DOCS] Added additional filesystems supported in URI
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10551/5/docs/topics/impala_authorization.xml
File docs/topics/impala_authorization.xml:
http://gerrit.cloudera.org:8080/#/c/10551/5/docs/topics/impala_authorization.xml@924
PS5, Line 924: will be automatically appended
nit: It seems to be prepended, no? You could also rephrase as "If..., it will be appended to the default filesystem prefix."
--
To view, visit http://gerrit.cloudera.org:8080/10551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11d57efd564fb5779539a88d7b209cee93d313c6
Gerrit-Change-Number: 10551
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Jun 2018 18:56:54 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5380: [DOCS] Added additional filesystems supported in URI
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Lars Volker, Fredy Wijaya, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10551
to look at the new patch set (#5).
Change subject: IMPALA-5380: [DOCS] Added additional filesystems supported in URI
......................................................................
IMPALA-5380: [DOCS] Added additional filesystems supported in URI
Change-Id: I11d57efd564fb5779539a88d7b209cee93d313c6
---
M docs/topics/impala_authorization.xml
1 file changed, 24 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/10551/5
--
To view, visit http://gerrit.cloudera.org:8080/10551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I11d57efd564fb5779539a88d7b209cee93d313c6
Gerrit-Change-Number: 10551
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] IMPALA-5380: [DOCS] Added additional filesystems supported in URI
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Lars Volker, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10551
to look at the new patch set (#4).
Change subject: IMPALA-5380: [DOCS] Added additional filesystems supported in URI
......................................................................
IMPALA-5380: [DOCS] Added additional filesystems supported in URI
Change-Id: I11d57efd564fb5779539a88d7b209cee93d313c6
---
M docs/topics/impala_authorization.xml
1 file changed, 13 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/10551/4
--
To view, visit http://gerrit.cloudera.org:8080/10551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I11d57efd564fb5779539a88d7b209cee93d313c6
Gerrit-Change-Number: 10551
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] IMPALA-5380: [DOCS] Added additional filesystems supported in URI
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10551 )
Change subject: IMPALA-5380: [DOCS] Added additional filesystems supported in URI
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10551/3/docs/topics/impala_authorization.xml
File docs/topics/impala_authorization.xml:
http://gerrit.cloudera.org:8080/#/c/10551/3/docs/topics/impala_authorization.xml@921
PS3, Line 921: If a URI starts with anything else, it will
: cause an exception
I don't think this is correct. If a URI starts with an absolute path, it will automatically append the default prefix filesystem. For example:
> grant all on uri '/tmp' to role test_role;
> show grant role test_role;
Query: show grant role test_role
+-------+----------+-------+--------+------------------------------------------------------+-----------+--------------+-------------------------------+
| scope | database | table | column | uri | privilege | grant_option | create_time |
+-------+----------+-------+--------+------------------------------------------------------+-----------+--------------+-------------------------------+
| uri | | | | hdfs://localhost:20500/tmp | all | false | Wed, Jun 06 2018 11:22:26.283 |
--
To view, visit http://gerrit.cloudera.org:8080/10551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11d57efd564fb5779539a88d7b209cee93d313c6
Gerrit-Change-Number: 10551
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Jun 2018 18:24:39 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5380: [DOCS] Added additional filesystems supported in URI
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10551 )
Change subject: IMPALA-5380: [DOCS] Added additional filesystems supported in URI
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
LGTM but someone with more expertise in Authorization should look at it, too
http://gerrit.cloudera.org:8080/#/c/10551/3/docs/topics/impala_authorization.xml
File docs/topics/impala_authorization.xml:
http://gerrit.cloudera.org:8080/#/c/10551/3/docs/topics/impala_authorization.xml@934
PS3, Line 934: <codeblock>data_read = server=server1->uri=file:///path/to/dir,\ server=server1->uri=hdfs://ha-nn-uri/path/to/dir
nit: here, too?
--
To view, visit http://gerrit.cloudera.org:8080/10551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11d57efd564fb5779539a88d7b209cee93d313c6
Gerrit-Change-Number: 10551
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Jun 2018 18:08:34 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5380: [DOCS] Added additional filesystems supported in URI
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10551 )
Change subject: IMPALA-5380: [DOCS] Added additional filesystems supported in URI
......................................................................
Patch Set 5:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/10551/5/docs/topics/impala_authorization.xml
File docs/topics/impala_authorization.xml:
http://gerrit.cloudera.org:8080/#/c/10551/5/docs/topics/impala_authorization.xml@924
PS5, Line 924: will be automatically appended
> nit: It seems to be prepended, no? You could also rephrase as "If..., it wi
Done
http://gerrit.cloudera.org:8080/#/c/10551/5/docs/topics/impala_authorization.xml@924
PS5, Line 924: will be automatically appended
> You could even include the example from Fredy's comment.
Done
--
To view, visit http://gerrit.cloudera.org:8080/10551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11d57efd564fb5779539a88d7b209cee93d313c6
Gerrit-Change-Number: 10551
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Jun 2018 19:16:19 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5380: [DOCS] Added additional filesystems supported in URI
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10551 )
Change subject: IMPALA-5380: [DOCS] Added additional filesystems supported in URI
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11d57efd564fb5779539a88d7b209cee93d313c6
Gerrit-Change-Number: 10551
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Jun 2018 19:22:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5380: [DOCS] Added additional filesystems supported in URI
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10551 )
Change subject: IMPALA-5380: [DOCS] Added additional filesystems supported in URI
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10551/2/docs/topics/impala_authorization.xml
File docs/topics/impala_authorization.xml:
http://gerrit.cloudera.org:8080/#/c/10551/2/docs/topics/impala_authorization.xml@923
PS2, Line 923: URIs for HDFS, you must also specify the NameNode. For example: <codeblock>data_read = server=server1->uri=file:///path/to/dir, \
nit: can you wrap the lines?
--
To view, visit http://gerrit.cloudera.org:8080/10551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11d57efd564fb5779539a88d7b209cee93d313c6
Gerrit-Change-Number: 10551
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Jun 2018 17:51:47 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5380: [DOCS] Added additional filesystems supported in URI
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10551 )
Change subject: IMPALA-5380: [DOCS] Added additional filesystems supported in URI
......................................................................
Patch Set 5: Code-Review+1
LGTM.
--
To view, visit http://gerrit.cloudera.org:8080/10551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11d57efd564fb5779539a88d7b209cee93d313c6
Gerrit-Change-Number: 10551
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Jun 2018 18:48:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5380: [DOCS] Added additional filesystems supported in URI
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10551 )
Change subject: IMPALA-5380: [DOCS] Added additional filesystems supported in URI
......................................................................
Patch Set 3:
(1 comment)
Who do you recommend to review in Authorization?
http://gerrit.cloudera.org:8080/#/c/10551/3/docs/topics/impala_authorization.xml
File docs/topics/impala_authorization.xml:
http://gerrit.cloudera.org:8080/#/c/10551/3/docs/topics/impala_authorization.xml@934
PS3, Line 934: <codeblock>data_read = server=server1->uri=file:///path/to/dir,\ server=server1->uri=hdfs://ha-nn-uri/path/to/dir
> nit: here, too?
Done
--
To view, visit http://gerrit.cloudera.org:8080/10551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11d57efd564fb5779539a88d7b209cee93d313c6
Gerrit-Change-Number: 10551
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Jun 2018 18:13:49 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5380: [DOCS] Added additional filesystems supported in URI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10551 )
Change subject: IMPALA-5380: [DOCS] Added additional filesystems supported in URI
......................................................................
Patch Set 6:
Build started: https://jenkins.impala.io/job/gerrit-docs-submit/310/
--
To view, visit http://gerrit.cloudera.org:8080/10551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11d57efd564fb5779539a88d7b209cee93d313c6
Gerrit-Change-Number: 10551
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Jun 2018 21:06:46 +0000
Gerrit-HasComments: No