You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/07/07 14:07:48 UTC
[GitHub] [maven-archetype] elharo opened a new pull request #65: [ARCHETYPE-584] don't normalize whitespace in tests so we can test for whitespace
elharo opened a new pull request #65:
URL: https://github.com/apache/maven-archetype/pull/65
@newur @Tibor17
Passes in Java 8. I want to see if this fails in Java 11.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetype] elharo commented on pull request #65: [ARCHETYPE-584] don't normalize whitespace in tests so we can test for whitespace
Posted by GitBox <gi...@apache.org>.
elharo commented on pull request #65:
URL: https://github.com/apache/maven-archetype/pull/65#issuecomment-876356620
I think you've identified the likely cause of the bug. I do not, however, agree with the proposed fix. There's nothing about this bug that suggests we should be adding schema processing. I'll be quite surprised if that turns out to be necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetype] newur edited a comment on pull request #65: [ARCHETYPE-584] don't normalize whitespace in tests so we can test for whitespace
Posted by GitBox <gi...@apache.org>.
newur edited a comment on pull request #65:
URL: https://github.com/apache/maven-archetype/pull/65#issuecomment-875833742
@elharo
I don't see what you try to achieve or what your reasoning is here. However, the call to `.normalizeWhitespace()` is rather new and I assume it was added to 'get the test green'. So undoing the normalize is bringing the test back to the status quo - which was a stronger test anyway!
You can see it here: https://github.com/apache/maven-archetype/commit/bf7961805ea56cdad7e138f47098aacccb314db8#diff-db4ddee9a40aadf3fab866c350ca950397f69b630de05a126f0265e2136cc070
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetype] elharo commented on pull request #65: [ARCHETYPE-584] don't normalize whitespace in tests so we can test for whitespace
Posted by GitBox <gi...@apache.org>.
elharo commented on pull request #65:
URL: https://github.com/apache/maven-archetype/pull/65#issuecomment-875650892
Yep:
```
Expected: Expected text value '
' but was '
' - comparing <project ...>
</project> at /project[1]/text()[1] to <project ...>
</project> at /project[1]/text()[1]:
<project>
<packaging>pom</packaging>
<modules> <module>myArtifactId1</module>
</modules>
</project>
but: result was:
<project>
<packaging>pom</packaging>
<modules>
<module>myArtifactId1</module>
</modules>
</project>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetype] newur commented on pull request #65: [ARCHETYPE-584] don't normalize whitespace in tests so we can test for whitespace
Posted by GitBox <gi...@apache.org>.
newur commented on pull request #65:
URL: https://github.com/apache/maven-archetype/pull/65#issuecomment-876355233
> I'm trying to understand what's going on here, and how it fails.
Right, that is always a good approach to solve a bug.
I would hope that the [existing PR](https://github.com/apache/maven-archetype/pull/35) is a reasonable starting point on how to fix the bug and my [comment in JIRA](https://issues.apache.org/jira/browse/ARCHETYPE-584?focusedCommentId=17374207&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17374207) points to the commit that most likely causes the bug.
Anyway, I wish you good luck with the approach you apply to the problem. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetype] newur commented on pull request #65: [ARCHETYPE-584] don't normalize whitespace in tests so we can test for whitespace
Posted by GitBox <gi...@apache.org>.
newur commented on pull request #65:
URL: https://github.com/apache/maven-archetype/pull/65#issuecomment-875650552
Looks like it fails on JDK 11+
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-archetype/job/linebreak/1/testReport/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetype] elharo commented on pull request #65: [ARCHETYPE-584] don't normalize whitespace in tests so we can test for whitespace
Posted by GitBox <gi...@apache.org>.
elharo commented on pull request #65:
URL: https://github.com/apache/maven-archetype/pull/65#issuecomment-876005412
I'm trying to understand what's going on here, and how it fails. This is easier to do one change at a time. This test isn't very well factored to start with, and might need some cleanup before the issue can be fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetype] elharo commented on pull request #65: [ARCHETYPE-584] don't normalize whitespace in tests so we can test for whitespace
Posted by GitBox <gi...@apache.org>.
elharo commented on pull request #65:
URL: https://github.com/apache/maven-archetype/pull/65#issuecomment-875699923
It might make sense to create a new Java 11 test rather than changing this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetype] newur commented on pull request #65: [ARCHETYPE-584] don't normalize whitespace in tests so we can test for whitespace
Posted by GitBox <gi...@apache.org>.
newur commented on pull request #65:
URL: https://github.com/apache/maven-archetype/pull/65#issuecomment-875833742
@elharo
I don't see what you try to achieve or what your reasoning is here. However, the call to `.normalizeWhitespace()` is rather new and I assume it was added to 'get the test green'. So undoing the change is bringing the test back to the status quo - which was a stronger test anyway!
You can see it here: https://github.com/apache/maven-archetype/commit/bf7961805ea56cdad7e138f47098aacccb314db8#diff-db4ddee9a40aadf3fab866c350ca950397f69b630de05a126f0265e2136cc070
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org