You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/20 21:11:46 UTC

[GitHub] [airflow] XD-DENG opened a new pull request #14917: Multiple minor doc fixes

XD-DENG opened a new pull request #14917:
URL: https://github.com/apache/airflow/pull/14917


   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil merged pull request #14917: Multiple minor doc fixes

Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #14917:
URL: https://github.com/apache/airflow/pull/14917


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] XD-DENG commented on a change in pull request #14917: Multiple minor doc fixes

Posted by GitBox <gi...@apache.org>.
XD-DENG commented on a change in pull request #14917:
URL: https://github.com/apache/airflow/pull/14917#discussion_r598160507



##########
File path: docs/apache-airflow/macros-ref.rst
##########
@@ -62,7 +62,7 @@ Variable                                Description
 ``{{ ti }}``                            same as ``{{ task_instance }}``
 ``{{ params }}``                        a reference to the user-defined params dictionary which can be overridden by
                                         the dictionary passed through ``trigger_dag -c`` if you enabled
-                                        ``dag_run_conf_overrides_params` in ``airflow.cfg``

Review comment:
       Currently how this is rendered, which is obviously wrong
   
   <img width="779" alt="Macros_reference_—_Airflow_Documentation" src="https://user-images.githubusercontent.com/11539188/111885647-67553000-89c9-11eb-822f-77d7de4fb212.png">
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org