You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by jsirois <gi...@git.apache.org> on 2016/02/10 18:32:15 UTC
[GitHub] thrift pull request: lib/cpp/test/SecurityTest is flaky in jenkins...
GitHub user jsirois opened a pull request:
https://github.com/apache/thrift/pull/841
lib/cpp/test/SecurityTest is flaky in jenkins Thrift-precommit build.
Previously, the server socket might not be fully closed from a prior
test, leading to flaky port bind failures in CI. Avoid the issue
altogether by binding an ephemeral port.
Add a TODO to TestPortFixture.h to warn folks away from its usage
and link THRIFT-3609 to track the work of removing or replacing it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jsirois/thrift THRIFT-3608
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/841.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #841
----
commit d26dc7a655456c26c604cae55c42ea2770254460
Author: John Sirois <js...@apache.org>
Date: 2016-02-10T17:14:51Z
Fixup SecurityTest to use ephemeral ports.
Previously, the server socket might not be fully closed from a prior
test, leading to flaky port bind failures in CI. Avoid the issue
altogether by binding an ephemeral port.
Add a TODO to TestPortFixture.h to warn folks away from its usage
and link THRIFT-3609 to track the work of removing or replacing it.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #841: lib/cpp/test/SecurityTest is flaky in jenkins Thrift-prec...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/thrift/pull/841
[](https://coveralls.io/builds/15328429)
Coverage remained the same at ?% when pulling **e71f20cd3ee9e812a064e492a7e692e2f2f98d35 on jsirois:THRIFT-3608** into **e71f20cd3ee9e812a064e492a7e692e2f2f98d35 on apache:master**.
---
[GitHub] thrift pull request: lib/cpp/test/SecurityTest is flaky in jenkins...
Posted by jsirois <gi...@git.apache.org>.
Github user jsirois commented on the pull request:
https://github.com/apache/thrift/pull/841#issuecomment-182506462
Hrm, although it looks like Travis-CI will go green with this change, Jenkins still flaked out. More investigation needed. This PR will get a bit noisy with debug attempts and I may close it after debugging the issue and start a fresh PR + patch with the ultimate fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: lib/cpp/test/SecurityTest is flaky in jenkins...
Posted by jsirois <gi...@git.apache.org>.
Github user jsirois closed the pull request at:
https://github.com/apache/thrift/pull/841
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---