You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mxnet.apache.org by István Fehérvári <go...@gmail.com> on 2019/01/03 17:52:23 UTC

Tensorflow contrib loss functions ported to mxnet

Hello developers,



I am working on metric learning currently and so I ported all tensorflow
metric learning loss functions to mxnet (gluon) (
https://www.tensorflow.org/api_docs/python/tf/contrib/losses/metric_learning
).

Before I put some work into making it PR-able, is there any interest in an
mxnet (contrib) loss module or I should not bother trying to merge it?



The reason I ask is that I see that we have a LOT of open PRs that get 0
attention and I do not want to invest time into a feature that will never
make it. E.g. my last PR on a new operator was opened ~3 weeks ago and
still no review or comment.



Thanks a lot,

Istvan

Re: Tensorflow contrib loss functions ported to mxnet

Posted by István Fehérvári <go...@gmail.com>.

Thanks for the feedback, I was planning to add an example as well for each
loss, possibly an extension to the current embedding learning gluon example.

The forgotten PR is https://github.com/apache/incubator-mxnet/pull/13632

On Thu, Jan 10, 2019 at 12:40 AM Hagay Lupesko <lu...@gmail.com> wrote:

> Istavan,
>
> This sounds useful to me, and would encourage you to contribute it.
> It's always helpful if you describe one or two use cases for the
> contribution (e.g. models/problems where these loss functions are useful) -
> this stimulates interest.
>
> Can you share the link to the PR that got zero attention? I'm happy to
> help.
>
> Hagay
>
> On Thu, Jan 3, 2019 at 9:52 AM István Fehérvári <go...@gmail.com> wrote:
>
> > Hello developers,
> >
> >
> >
> > I am working on metric learning currently and so I ported all tensorflow
> > metric learning loss functions to mxnet (gluon) (
> >
> >
> https://www.tensorflow.org/api_docs/python/tf/contrib/losses/metric_learning
> > ).
> >
> > Before I put some work into making it PR-able, is there any interest in
> an
> > mxnet (contrib) loss module or I should not bother trying to merge it?
> >
> >
> >
> > The reason I ask is that I see that we have a LOT of open PRs that get 0
> > attention and I do not want to invest time into a feature that will never
> > make it. E.g. my last PR on a new operator was opened ~3 weeks ago and
> > still no review or comment.
> >
> >
> >
> > Thanks a lot,
> >
> > Istvan
> >
>

Re: Tensorflow contrib loss functions ported to mxnet

Posted by Hagay Lupesko <lu...@gmail.com>.

Istavan,

This sounds useful to me, and would encourage you to contribute it.
It's always helpful if you describe one or two use cases for the
contribution (e.g. models/problems where these loss functions are useful) -
this stimulates interest.

Can you share the link to the PR that got zero attention? I'm happy to help.

Hagay

On Thu, Jan 3, 2019 at 9:52 AM István Fehérvári <go...@gmail.com> wrote:

> Hello developers,
>
>
>
> I am working on metric learning currently and so I ported all tensorflow
> metric learning loss functions to mxnet (gluon) (
>
> https://www.tensorflow.org/api_docs/python/tf/contrib/losses/metric_learning
> ).
>
> Before I put some work into making it PR-able, is there any interest in an
> mxnet (contrib) loss module or I should not bother trying to merge it?
>
>
>
> The reason I ask is that I see that we have a LOT of open PRs that get 0
> attention and I do not want to invest time into a feature that will never
> make it. E.g. my last PR on a new operator was opened ~3 weeks ago and
> still no review or comment.
>
>
>
> Thanks a lot,
>
> Istvan
>