You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "lhotari (via GitHub)" <gi...@apache.org> on 2024/02/08 18:32:38 UTC
[PR] [fix][broker] Sanitize values before logging in apply-config-from-env.py script [pulsar]
lhotari opened a new pull request, #22044:
URL: https://github.com/apache/pulsar/pull/22044
Fixes #22043
### Motivation
See #22043
### Modifications
- add value sanitization logic to `apply-config-from-env.py` script
- refactor the script
- add support for passing the prefix so that there isn't a need for code duplication in the apply-config-from-env-with-prefix.py script. That can be deprecated.
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][broker] Sanitize values before logging in apply-config-from-env.py script [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari merged PR #22044:
URL: https://github.com/apache/pulsar/pull/22044
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][broker] Sanitize values before logging in apply-config-from-env.py script [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #22044:
URL: https://github.com/apache/pulsar/pull/22044#issuecomment-1934740569
Tested on command line in this way:
```
cp conf/broker.conf /tmp
brokerInterceptors=foo PULSAR_PREFIX_brokerClientAuthenticationParameters=SECRET_VALUE ./docker/pulsar/scripts/apply-config-from-env.py /tmp/broker.conf
brokerInterceptors=foo brokerClientAuthenticationParameters=SECRET_VALUE ./docker/pulsar/scripts/apply-config-from-env.py /tmp/broker.conf
# also tested the new --prefix parameter that replaces the duplicate script apply-config-from-env-with-prefix.py (used in Pulsar SQL)
FOO_brokerInterceptors=foo brokerClientAuthenticationParameters=SECRET_VALUE ./docker/pulsar/scripts/apply-config-from-env.py --prefix FOO_ /tmp/broker.conf
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org