You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucy.apache.org by nw...@apache.org on 2013/06/07 18:10:23 UTC
[lucy-commits] [08/16] git commit: refs/heads/separate-clownfish-wip4 - Include
headers from included parcels in generated XS
Include headers from included parcels in generated XS
The hand-rolled XS code might need additional includes.
TODO: Don't include headers for parcels the source parcels don't depend
on.
Project: http://git-wip-us.apache.org/repos/asf/lucy/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucy/commit/9b8bbe3f
Tree: http://git-wip-us.apache.org/repos/asf/lucy/tree/9b8bbe3f
Diff: http://git-wip-us.apache.org/repos/asf/lucy/diff/9b8bbe3f
Branch: refs/heads/separate-clownfish-wip4
Commit: 9b8bbe3f1d95834e4bb95054c907f7fbf75a046b
Parents: 782693e
Author: Nick Wellnhofer <we...@aevum.de>
Authored: Thu Jun 6 22:15:35 2013 +0200
Committer: Nick Wellnhofer <we...@aevum.de>
Committed: Fri Jun 7 17:40:38 2013 +0200
----------------------------------------------------------------------
clownfish/compiler/src/CFCPerl.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/lucy/blob/9b8bbe3f/clownfish/compiler/src/CFCPerl.c
----------------------------------------------------------------------
diff --git a/clownfish/compiler/src/CFCPerl.c b/clownfish/compiler/src/CFCPerl.c
index 7c171cf..13dd0ee 100644
--- a/clownfish/compiler/src/CFCPerl.c
+++ b/clownfish/compiler/src/CFCPerl.c
@@ -356,9 +356,6 @@ S_xs_file_contents(CFCPerl *self, const char *generated_xs,
"#include \"XSBind.h\"\n"
"#include \"boot.h\"\n"
"\n"
- "#include \"Clownfish/Util/Memory.h\"\n"
- "#include \"Clownfish/Util/StringHelper.h\"\n"
- "\n"
"%s\n"
"\n"
"MODULE = %s PACKAGE = %s\n"
@@ -406,7 +403,8 @@ CFCPerl_write_bindings(CFCPerl *self) {
// Pound-includes for generated headers.
for (size_t i = 0; ordered[i] != NULL; i++) {
CFCClass *klass = ordered[i];
- if (CFCClass_included(klass)) { continue; }
+ // TODO: Don't include headers for parcels the source parcels don't
+ // depend on.
const char *include_h = CFCClass_include_h(klass);
generated_xs = CFCUtil_cat(generated_xs, "#include \"", include_h,
"\"\n", NULL);