You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@singa.apache.org by GitBox <gi...@apache.org> on 2020/03/03 09:13:58 UTC
[GitHub] [singa] moazreyad opened a new pull request #620: SINGA-508 Add
licence check with Apache Rat in Travis
moazreyad opened a new pull request #620: SINGA-508 Add licence check with Apache Rat in Travis
URL: https://github.com/apache/singa/pull/620
Currently it fails because:
1. It dose not use [rat-excludes](https://github.com/apache/singa/blob/master/rat-excludes). Also this file is not complete. There are many files and directories that must be excluded because they are mentioned in [LICENSE](https://github.com/apache/singa/blob/master/LICENSE). We may use the [excludes option](https://creadur.apache.org/rat/apache-rat-plugin/rat-mojo.html#excludes) to fix this.
2. It executes after `git submodule update ` which downloads Rafiki code. The code has no licence header. We can add the licence to Rafiki, add Rafiki to the excluded directories from check, or run the check before downloading Rafiki code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [singa] moazreyad commented on issue #620: SINGA-508 Add licence
check with Apache Rat in Travis
Posted by GitBox <gi...@apache.org>.
moazreyad commented on issue #620: SINGA-508 Add licence check with Apache Rat in Travis
URL: https://github.com/apache/singa/pull/620#issuecomment-595623752
The RAT test pass now after fixing with "exculdes" option.
This PR can be merged, although I think it is better to combine the RAT test with the linting tests of #599 in one "Static Analysis" test to reduce TravisCI check time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [singa] moazreyad commented on issue #620: SINGA-508 Add licence
check with Apache Rat in Travis
Posted by GitBox <gi...@apache.org>.
moazreyad commented on issue #620: SINGA-508 Add licence check with Apache Rat in Travis
URL: https://github.com/apache/singa/pull/620#issuecomment-597159824
How can I update the dev? should I create a temporary branch at the apache repository for this patch?
I tried to make this PR from moazreyad:SINGA-508 to apache:dev but there are conflicts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [singa] nudles commented on issue #620: SINGA-508 Add licence check
with Apache Rat in Travis
Posted by GitBox <gi...@apache.org>.
nudles commented on issue #620: SINGA-508 Add licence check with Apache Rat in Travis
URL: https://github.com/apache/singa/pull/620#issuecomment-596934850
the linting PR is already merged into dev..
can you cancel this PR, update the linting script in dev and submit the PR to dev?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [singa] nudles commented on issue #620: SINGA-508 Add Apache RAT
licence check with Github Actions
Posted by GitBox <gi...@apache.org>.
nudles commented on issue #620: SINGA-508 Add Apache RAT licence check with Github Actions
URL: https://github.com/apache/singa/pull/620#issuecomment-598181428
I think a better way is to
1. checkout from the latest dev
2. copy the updated files from the master to the dev
3. commit.
Otherwise, the commits would be mixed.
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [singa] nudles commented on a change in pull request #620:
SINGA-508 Add licence check with Apache Rat in Travis
Posted by GitBox <gi...@apache.org>.
nudles commented on a change in pull request #620: SINGA-508 Add licence check with Apache Rat in Travis
URL: https://github.com/apache/singa/pull/620#discussion_r390982251
##########
File path: .travis.yml
##########
@@ -37,6 +37,12 @@ matrix:
dist: bionic
compiler: gcc
name: "Ubuntu 18.04 (C++)"
+ - os: linux
+ dist: bionic
Review comment:
I think we can remove the travis check since .github/workflows/rat.yml already does the check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [singa] moazreyad commented on issue #620: SINGA-508 Add licence
check with Apache Rat in Travis
Posted by GitBox <gi...@apache.org>.
moazreyad commented on issue #620: SINGA-508 Add licence check with Apache Rat in Travis
URL: https://github.com/apache/singa/pull/620#issuecomment-596180220
I am not sure how to combine the two pull requests together. May be we can merge one of them first, then we update and merge the second later.
For example, we may merge this PR with apache master, then update the apache dev branch from the master and merge the linting PR. or do you propose a better way?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [singa] nudles commented on issue #620: SINGA-508 Add licence check
with Apache Rat in Travis
Posted by GitBox <gi...@apache.org>.
nudles commented on issue #620: SINGA-508 Add licence check with Apache Rat in Travis
URL: https://github.com/apache/singa/pull/620#issuecomment-597960795
I think it is better to move it into dev first.
we will merge dev into master before we release the next version.
On Wed, Mar 11, 2020 at 10:50 PM Moaz Reyad <no...@github.com>
wrote:
> *@moazreyad* commented on this pull request.
> ------------------------------
>
> In .travis.yml
> <https://github.com/apache/singa/pull/620#discussion_r391026637>:
>
> > @@ -37,6 +37,12 @@ matrix:
> dist: bionic
> compiler: gcc
> name: "Ubuntu 18.04 (C++)"
> + - os: linux
> + dist: bionic
>
> Yes, travis check is removed. This PR can be a first step in moving from
> travis to github actions. Then later we can move linting and other scripts
> also.
> Can we merge it directly to master? or we still need to merge it with dev
> first?
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/singa/pull/620#discussion_r391026637>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AA47DR6BTPF72XGFTY3NOKTRG6QHRANCNFSM4LAF7NCA>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [singa] moazreyad closed pull request #620: SINGA-508 Add Apache
RAT licence check with Github Actions
Posted by GitBox <gi...@apache.org>.
moazreyad closed pull request #620: SINGA-508 Add Apache RAT licence check with Github Actions
URL: https://github.com/apache/singa/pull/620
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [singa] moazreyad commented on issue #620: SINGA-508 Add licence
check with Apache Rat in Travis
Posted by GitBox <gi...@apache.org>.
moazreyad commented on issue #620: SINGA-508 Add licence check with Apache Rat in Travis
URL: https://github.com/apache/singa/pull/620#issuecomment-597285285
> Are you going to move combine it with the linting test?
Let's not combine RAT with lint now because it may take some time to make the correct PRs and this issue is small and not urgent now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [singa] moazreyad commented on a change in pull request #620:
SINGA-508 Add licence check with Apache Rat in Travis
Posted by GitBox <gi...@apache.org>.
moazreyad commented on a change in pull request #620: SINGA-508 Add licence check with Apache Rat in Travis
URL: https://github.com/apache/singa/pull/620#discussion_r391026637
##########
File path: .travis.yml
##########
@@ -37,6 +37,12 @@ matrix:
dist: bionic
compiler: gcc
name: "Ubuntu 18.04 (C++)"
+ - os: linux
+ dist: bionic
Review comment:
Yes, travis check is removed. This PR can be a first step in moving from travis to github actions. Then later we can move linting and other scripts also.
Can we merge it directly to master? or we still need to merge it with dev first?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [singa] nudles commented on issue #620: SINGA-508 Add licence check
with Apache Rat in Travis
Posted by GitBox <gi...@apache.org>.
nudles commented on issue #620: SINGA-508 Add licence check with Apache Rat in Travis
URL: https://github.com/apache/singa/pull/620#issuecomment-596173512
Are you going to move combine it with the linting test?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [singa] moazreyad commented on issue #620: SINGA-508 Add Apache RAT
licence check with Github Actions
Posted by GitBox <gi...@apache.org>.
moazreyad commented on issue #620: SINGA-508 Add Apache RAT licence check with Github Actions
URL: https://github.com/apache/singa/pull/620#issuecomment-598091559
Ok. I changed the branch to dev. I hope it is fine now and can be merged.
In this PR, I only changed:
.github/workflows/rat.yml
java/pom.xml
tool/rat.sh
rat-excludes
test/python/cuda_helper.py
test/python/test_memoryPool.py
The other files in PR are not modified for this PR, but they are added by git due to the merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services