You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Karl Heinz Marbaise <kh...@gmx.de> on 2015/11/28 19:14:05 UTC
Maven Source Plugin 3.0.0 Question
Hi,
at the moment the maven-source-plugin creates archives (source archives)
which do not contain a maven descriptor ...
/META-INF/maven/..../../pom.xml
/META-INF/maven/..../../pom.properties
I would like to change the default behaviour to produce this maven
descriptor...in source archives ...
I would think it would make maven-source-plugin to behave the same way
as other plugins aleady do ...and this change would be reasonable for a
major version change...
WDYT ?
Kind regards
Karl Heinz Marbaise
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Maven Source Plugin 3.0.0 Question
Posted by Michael Osipov <mi...@apache.org>.
Am 2015-11-28 um 19:56 schrieb Karl Heinz Marbaise:
> Hi Michael,
>
> On 11/28/15 7:43 PM, Michael Osipov wrote:
>> Am 2015-11-28 um 19:14 schrieb Karl Heinz Marbaise:
>>> Hi,
>>>
>>> at the moment the maven-source-plugin creates archives (source archives)
>>> which do not contain a maven descriptor ...
>>>
>>> /META-INF/maven/..../../pom.xml
>>> /META-INF/maven/..../../pom.properties
>>>
>>> I would like to change the default behaviour to produce this maven
>>> descriptor...in source archives ...
>>>
>>> I would think it would make maven-source-plugin to behave the same way
>>> as other plugins aleady do ...and this change would be reasonable for a
>>> major version change...
>>>
>>> WDYT ?
>>
>> Why not take the same approach as in MJAVADOC-431? Opt-in for the dev.
>
> Cause at the moment it is exactly so implemented..but i would like to
> change that to the default if it makes sense...
That is exactly the issue, just because it might make sense to you, it
doesn't make to the rest. Personally, I do not see any added value to
have then by default filled up in Central because those are always
accompanied by the main artifact. If a project needs to have those by
default, they can turn it on with a switch.
Do you see general usecases having them by default in the JAR?
Michael
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Maven Source Plugin 3.0.0 Question
Posted by Karl Heinz Marbaise <kh...@gmx.de>.
Hi Michael,
On 11/28/15 7:43 PM, Michael Osipov wrote:
> Am 2015-11-28 um 19:14 schrieb Karl Heinz Marbaise:
>> Hi,
>>
>> at the moment the maven-source-plugin creates archives (source archives)
>> which do not contain a maven descriptor ...
>>
>> /META-INF/maven/..../../pom.xml
>> /META-INF/maven/..../../pom.properties
>>
>> I would like to change the default behaviour to produce this maven
>> descriptor...in source archives ...
>>
>> I would think it would make maven-source-plugin to behave the same way
>> as other plugins aleady do ...and this change would be reasonable for a
>> major version change...
>>
>> WDYT ?
>
> Why not take the same approach as in MJAVADOC-431? Opt-in for the dev.
Cause at the moment it is exactly so implemented..but i would like to
change that to the default if it makes sense...
Kind regards
Karl Heinz Marbaise
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Maven Source Plugin 3.0.0 Question
Posted by Michael Osipov <mi...@apache.org>.
Am 2015-11-28 um 19:14 schrieb Karl Heinz Marbaise:
> Hi,
>
> at the moment the maven-source-plugin creates archives (source archives)
> which do not contain a maven descriptor ...
>
> /META-INF/maven/..../../pom.xml
> /META-INF/maven/..../../pom.properties
>
> I would like to change the default behaviour to produce this maven
> descriptor...in source archives ...
>
> I would think it would make maven-source-plugin to behave the same way
> as other plugins aleady do ...and this change would be reasonable for a
> major version change...
>
> WDYT ?
Why not take the same approach as in MJAVADOC-431? Opt-in for the dev.
Michael
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Maven Source Plugin 3.0.0 Question
Posted by Michael Osipov <mi...@apache.org>.
Am 2015-11-28 um 23:35 schrieb Tibor Digana:
> For me the descriptor was always useless. Do you Karl, Michael mean that
> this cofiguration does not work?
> <archive
> <http://maven.apache.org/shared/maven-archiver/index.html#class_archive>>
> <addMavenDescriptor/>
It does not help because it is disabled (hardcoded) in Javadoc Plugin:
https://github.com/apache/maven-plugins/blob/trunk/maven-javadoc-plugin/src/main/java/org/apache/maven/plugin/javadoc/JavadocJar.java#L299
> On Sat, Nov 28, 2015 at 11:15 PM, Michael Osipov <mi...@apache.org>
> wrote:
>
>> Am 2015-11-28 um 21:36 schrieb Tibor Digana:
>>
>>> ..but I don't understand why you want to have the descriptor in sources
>>> jar?
>>> Is the plugin buggy or something or it is just arbitrary some reason found
>>> for a release?
>>>
>>
>> Please see MJAVADOC-431 and the PR but I consider them as special cases
>> and not worthy being of general use.
>>
>> Michael
>>
>>
>> On Sat, Nov 28, 2015 at 7:14 PM, Karl Heinz Marbaise <kh...@gmx.de>
>>> wrote:
>>>
>>> Hi,
>>>>
>>>> at the moment the maven-source-plugin creates archives (source archives)
>>>> which do not contain a maven descriptor ...
>>>>
>>>> /META-INF/maven/..../../pom.xml
>>>> /META-INF/maven/..../../pom.properties
>>>>
>>>> I would like to change the default behaviour to produce this maven
>>>> descriptor...in source archives ...
>>>>
>>>> I would think it would make maven-source-plugin to behave the same way as
>>>> other plugins aleady do ...and this change would be reasonable for a
>>>> major
>>>> version change...
>>>>
>>>> WDYT ?
>>>>
>>>> Kind regards
>>>> Karl Heinz Marbaise
>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>
>>>>
>>>>
>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Maven Source Plugin 3.0.0 Question
Posted by Tibor Digana <ti...@googlemail.com>.
For me the descriptor was always useless. Do you Karl, Michael mean that
this cofiguration does not work?
<archive
<http://maven.apache.org/shared/maven-archiver/index.html#class_archive>>
<addMavenDescriptor/>
You did not mention Jira # in maven-source-plugin.
On Sat, Nov 28, 2015 at 11:15 PM, Michael Osipov <mi...@apache.org>
wrote:
> Am 2015-11-28 um 21:36 schrieb Tibor Digana:
>
>> ..but I don't understand why you want to have the descriptor in sources
>> jar?
>> Is the plugin buggy or something or it is just arbitrary some reason found
>> for a release?
>>
>
> Please see MJAVADOC-431 and the PR but I consider them as special cases
> and not worthy being of general use.
>
> Michael
>
>
> On Sat, Nov 28, 2015 at 7:14 PM, Karl Heinz Marbaise <kh...@gmx.de>
>> wrote:
>>
>> Hi,
>>>
>>> at the moment the maven-source-plugin creates archives (source archives)
>>> which do not contain a maven descriptor ...
>>>
>>> /META-INF/maven/..../../pom.xml
>>> /META-INF/maven/..../../pom.properties
>>>
>>> I would like to change the default behaviour to produce this maven
>>> descriptor...in source archives ...
>>>
>>> I would think it would make maven-source-plugin to behave the same way as
>>> other plugins aleady do ...and this change would be reasonable for a
>>> major
>>> version change...
>>>
>>> WDYT ?
>>>
>>> Kind regards
>>> Karl Heinz Marbaise
>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>
>>>
>>>
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
--
Cheers
Tibor
Re: Maven Source Plugin 3.0.0 Question
Posted by Michael Osipov <mi...@apache.org>.
Am 2015-11-28 um 21:36 schrieb Tibor Digana:
> ..but I don't understand why you want to have the descriptor in sources jar?
> Is the plugin buggy or something or it is just arbitrary some reason found
> for a release?
Please see MJAVADOC-431 and the PR but I consider them as special cases
and not worthy being of general use.
Michael
> On Sat, Nov 28, 2015 at 7:14 PM, Karl Heinz Marbaise <kh...@gmx.de>
> wrote:
>
>> Hi,
>>
>> at the moment the maven-source-plugin creates archives (source archives)
>> which do not contain a maven descriptor ...
>>
>> /META-INF/maven/..../../pom.xml
>> /META-INF/maven/..../../pom.properties
>>
>> I would like to change the default behaviour to produce this maven
>> descriptor...in source archives ...
>>
>> I would think it would make maven-source-plugin to behave the same way as
>> other plugins aleady do ...and this change would be reasonable for a major
>> version change...
>>
>> WDYT ?
>>
>> Kind regards
>> Karl Heinz Marbaise
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Maven Source Plugin 3.0.0 Question
Posted by Karl Heinz Marbaise <kh...@gmx.de>.
Hi Tibor,
On 11/28/15 9:36 PM, Tibor Digana wrote:
> ..but I don't understand why you want to have the descriptor in sources jar?
So we could discuss why a site archive needs a descriptor? Why does a
javadoc archive should have a descriptor
(https://issues.apache.org/jira/browse/MJAVADOC-431)...at all?
The ideas is that all plugins are behaving in the same
way...(conventions...)...
> Is the plugin buggy or something or it is just arbitrary some reason
> found for a release?
The reason for a new release is this:
https://issues.apache.org/jira/issues/?jql=project%20%3D%20MSOURCES%20AND%20fixVersion%20%3D%203.0.0
Kind regards
Karl Heinz Marbaise
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Maven Source Plugin 3.0.0 Question
Posted by Tibor Digana <ti...@googlemail.com>.
..but I don't understand why you want to have the descriptor in sources jar?
Is the plugin buggy or something or it is just arbitrary some reason found
for a release?
On Sat, Nov 28, 2015 at 7:14 PM, Karl Heinz Marbaise <kh...@gmx.de>
wrote:
> Hi,
>
> at the moment the maven-source-plugin creates archives (source archives)
> which do not contain a maven descriptor ...
>
> /META-INF/maven/..../../pom.xml
> /META-INF/maven/..../../pom.properties
>
> I would like to change the default behaviour to produce this maven
> descriptor...in source archives ...
>
> I would think it would make maven-source-plugin to behave the same way as
> other plugins aleady do ...and this change would be reasonable for a major
> version change...
>
> WDYT ?
>
> Kind regards
> Karl Heinz Marbaise
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
--
Cheers
Tibor