You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@storm.apache.org by bo...@apache.org on 2016/01/05 16:09:49 UTC

[1/3] storm git commit: remove unused variables for tests

Repository: storm
Updated Branches:
  refs/heads/master ba02f1eec -> dd8523121


remove unused variables for tests


Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/452aca81
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/452aca81
Diff: http://git-wip-us.apache.org/repos/asf/storm/diff/452aca81

Branch: refs/heads/master
Commit: 452aca81120708c9847d697f08acdc34409fea3b
Parents: b41f450
Author: Xin Wang <be...@163.com>
Authored: Thu Dec 24 21:59:12 2015 +0800
Committer: vesense <be...@163.com>
Committed: Thu Dec 24 22:09:18 2015 +0800

----------------------------------------------------------------------
 .../test/jvm/backtype/storm/blobstore/BlobStoreTest.java     | 1 -
 .../test/jvm/backtype/storm/localizer/LocalizerTest.java     | 8 +-------
 2 files changed, 1 insertion(+), 8 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/storm/blob/452aca81/storm-core/test/jvm/backtype/storm/blobstore/BlobStoreTest.java
----------------------------------------------------------------------
diff --git a/storm-core/test/jvm/backtype/storm/blobstore/BlobStoreTest.java b/storm-core/test/jvm/backtype/storm/blobstore/BlobStoreTest.java
index 7549ae9..86c802c 100644
--- a/storm-core/test/jvm/backtype/storm/blobstore/BlobStoreTest.java
+++ b/storm-core/test/jvm/backtype/storm/blobstore/BlobStoreTest.java
@@ -149,7 +149,6 @@ public class BlobStoreTest {
     Map conf = Utils.readStormConfig();
     conf.put(Config.STORM_LOCAL_DIR, baseFile.getAbsolutePath());
     conf.put(Config.STORM_PRINCIPAL_TO_LOCAL_PLUGIN,"backtype.storm.security.auth.DefaultPrincipalToLocal");
-    ArrayList<String> zookeeper_list = new ArrayList<>();
     spy.prepare(conf, null, null);
     return spy;
   }

http://git-wip-us.apache.org/repos/asf/storm/blob/452aca81/storm-core/test/jvm/backtype/storm/localizer/LocalizerTest.java
----------------------------------------------------------------------
diff --git a/storm-core/test/jvm/backtype/storm/localizer/LocalizerTest.java b/storm-core/test/jvm/backtype/storm/localizer/LocalizerTest.java
index 2b84f23..4eba3ab 100644
--- a/storm-core/test/jvm/backtype/storm/localizer/LocalizerTest.java
+++ b/storm-core/test/jvm/backtype/storm/localizer/LocalizerTest.java
@@ -56,7 +56,7 @@ public class LocalizerTest {
   private final String user2 = "user2";
   private final String user3 = "user3";
 
-  ClientBlobStore mockblobstore = mock(ClientBlobStore.class);
+  private ClientBlobStore mockblobstore = mock(ClientBlobStore.class);
 
 
   class TestLocalizer extends Localizer {
@@ -73,10 +73,6 @@ public class LocalizerTest {
 
   class TestInputStreamWithMeta extends InputStreamWithMeta {
     private InputStream iostream;
-    private byte[] buffer = null;
-    private int offset = 0;
-    private int end = 0;
-    private boolean eof = false;
 
     public TestInputStreamWithMeta() {
       iostream = IOUtils.toInputStream("some test data for my input stream");
@@ -118,7 +114,6 @@ public class LocalizerTest {
     if (!baseDir.mkdir()) {
       throw new IOException("failed to create base directory");
     }
-    ClientBlobStore mockblobstore = mock(ClientBlobStore.class);
   }
 
   @After
@@ -339,7 +334,6 @@ public class LocalizerTest {
 
   }
 
-
   @Test
   public void testBasic() throws Exception {
     Map conf = new HashMap();


[2/3] storm git commit: Merge branch 'patch-21' of https://github.com/vesense/storm into STORM-1413

Posted by bo...@apache.org.
Merge branch 'patch-21' of https://github.com/vesense/storm into STORM-1413

STORM-1413: remove unused variables for some tests


Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/2012a8b9
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/2012a8b9
Diff: http://git-wip-us.apache.org/repos/asf/storm/diff/2012a8b9

Branch: refs/heads/master
Commit: 2012a8b9bc47f117454b98dffdac88facd7f4631
Parents: ba02f1e 452aca8
Author: Robert (Bobby) Evans <ev...@yahoo-inc.com>
Authored: Tue Jan 5 08:57:14 2016 -0600
Committer: Robert (Bobby) Evans <ev...@yahoo-inc.com>
Committed: Tue Jan 5 08:57:14 2016 -0600

----------------------------------------------------------------------
 .../test/jvm/backtype/storm/blobstore/BlobStoreTest.java     | 1 -
 .../test/jvm/backtype/storm/localizer/LocalizerTest.java     | 8 +-------
 2 files changed, 1 insertion(+), 8 deletions(-)
----------------------------------------------------------------------



[3/3] storm git commit: Added STORM-1413 to Changelog

Posted by bo...@apache.org.
Added STORM-1413 to Changelog


Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/dd852312
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/dd852312
Diff: http://git-wip-us.apache.org/repos/asf/storm/diff/dd852312

Branch: refs/heads/master
Commit: dd8523121708d058f641fdbc4db005c49b42fce1
Parents: 2012a8b
Author: Robert (Bobby) Evans <ev...@yahoo-inc.com>
Authored: Tue Jan 5 08:57:39 2016 -0600
Committer: Robert (Bobby) Evans <ev...@yahoo-inc.com>
Committed: Tue Jan 5 08:57:39 2016 -0600

----------------------------------------------------------------------
 CHANGELOG.md | 1 +
 1 file changed, 1 insertion(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/storm/blob/dd852312/CHANGELOG.md
----------------------------------------------------------------------
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 31de910..e17621b 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,4 +1,5 @@
 ## 0.11.0
+ * STORM-1413: remove unused variables for some tests
  * STORM-1412: null check should be done in the first place
  * STORM-1210: Set Output Stream id in KafkaSpout
  * STORM-1397: Merge conflict from Pacemaker merge