[GitHub] [superset] mbcsa commented on pull request #20760: fix(csv): Do not coerce persisted data integer columns to float

[GitBox <gi...@apache.org>]

mbcsa commented on PR #20760:
URL: https://github.com/apache/superset/pull/20760#issuecomment-1199781738

   Hi @john-bodley 
   
   This fix introduces a new problem when user exports CSV file from a cached Query.
   I've created a new issue #20919 
   
   The thing is, when Dataframe is created dinamically from cached data, it is not respecting column formats.
   This is a problem when decimal separator is configured by CSV_EXPORT, "sep" attribute
   
   I'm testing this, and it works well when changing:
   
   ```
   df = pd.DataFrame(
       data=obj["data"],
       dtype=object,
       columns=[c["name"] for c in obj["columns"]],
   )
   ```
   to
   ```
   df = pd.DataFrame(
       data=obj["data"],
       columns=[c["name"] for c in obj["columns"]],
   )
   ```
   
   Thank you


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org