[GitHub] [druid] clintropolis commented on a diff in pull request #12914: tighten up array handling, fix bug with array_slice output type inference

[GitBox <gi...@apache.org>]

clintropolis commented on code in PR #12914:
URL: https://github.com/apache/druid/pull/12914#discussion_r953255543


##########
core/src/main/java/org/apache/druid/math/expr/Evals.java:
##########
@@ -20,21 +20,22 @@
 package org.apache.druid.math.expr;
 
 import org.apache.druid.common.config.NullHandling;
-import org.apache.druid.java.util.common.logger.Logger;
 
 import javax.annotation.Nullable;
-import java.util.Arrays;
 import java.util.List;
 
 /**
  */
 public class Evals
 {
-  private static final Logger log = new Logger(Evals.class);
-
   public static boolean isAllConstants(Expr... exprs)
   {
-    return isAllConstants(Arrays.asList(exprs));
+    for (Expr expr : exprs) {

Review Comment:
   yeah, this change wasn't really related to anything, but it seemed a bit pointless to wrap it... though i guess probably not that expensive in the scheme of things since this is only used when flattening expressions in the `Parser`, so on second thought can just change it back



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org