You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/11/05 00:57:10 UTC

[GitHub] [incubator-kyuubi] turboFei opened a new pull request, #3765: Revert "[KYUUBI #3577] Transfer connection url when opening session"

turboFei opened a new pull request, #3765:
URL: https://github.com/apache/incubator-kyuubi/pull/3765

   This reverts commit 35f3917e5d506cdd8a7063003522590520a9ce64.
   
   <!--
   Thanks for sending a pull request!
   
   Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
     2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
   -->
   
   ### _Why are the changes needed?_
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you add a feature, you can talk about the use case of it.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   
   ### _How was this patch tested?_
   - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
   
   - [ ] Add screenshots for manual tests if appropriate
   
   - [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #3765: [KYUUBI #3577][FOLLOWUP] Set default connectionUrl to empty string to prevent the UT stuck for metadata request retry

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3765:
URL: https://github.com/apache/incubator-kyuubi/pull/3765#issuecomment-1304425635

   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/3765?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3765](https://codecov.io/gh/apache/incubator-kyuubi/pull/3765?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1fbd35e) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/c0ecb4bdc01932666b11dd8872da9f64ea6bff62?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c0ecb4b) will **decrease** coverage by `0.00%`.
   > The diff coverage is `50.00%`.
   
   > :exclamation: Current head 1fbd35e differs from pull request most recent head 523eef4. Consider uploading reports for the commit 523eef4 to get more accurate results
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3765      +/-   ##
   ============================================
   - Coverage     52.60%   52.59%   -0.01%     
     Complexity       13       13              
   ============================================
     Files           492      494       +2     
     Lines         27752    27784      +32     
     Branches       3832     3836       +4     
   ============================================
   + Hits          14599    14614      +15     
   - Misses        11764    11776      +12     
   - Partials       1389     1394       +5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/3765?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...bi/plugin/lineage/helper/SparkListenerHelper.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3765/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZW5zaW9ucy9zcGFyay9reXV1Ymktc3BhcmstbGluZWFnZS9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9wbHVnaW4vbGluZWFnZS9oZWxwZXIvU3BhcmtMaXN0ZW5lckhlbHBlci5zY2FsYQ==) | `33.33% <ø> (ø)` | |
   | [...in/lineage/helper/SparkSQLLineageParseHelper.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3765/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZW5zaW9ucy9zcGFyay9reXV1Ymktc3BhcmstbGluZWFnZS9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9wbHVnaW4vbGluZWFnZS9oZWxwZXIvU3BhcmtTUUxMaW5lYWdlUGFyc2VIZWxwZXIuc2NhbGE=) | `62.70% <0.00%> (ø)` | |
   | [...kyuubi/plugin/lineage/helper/SemanticVersion.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3765/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZW5zaW9ucy9zcGFyay9reXV1Ymktc3BhcmstbGluZWFnZS9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9wbHVnaW4vbGluZWFnZS9oZWxwZXIvU2VtYW50aWNWZXJzaW9uLnNjYWxh) | `39.28% <39.28%> (ø)` | |
   | [.../SparkOperationLineageQueryExecutionListener.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3765/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZW5zaW9ucy9zcGFyay9reXV1Ymktc3BhcmstbGluZWFnZS9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9wbHVnaW4vbGluZWFnZS9TcGFya09wZXJhdGlvbkxpbmVhZ2VRdWVyeUV4ZWN1dGlvbkxpc3RlbmVyLnNjYWxh) | `66.66% <50.00%> (ø)` | |
   | [.../plugin/lineage/events/OperationLineageEvent.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3765/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZW5zaW9ucy9zcGFyay9reXV1Ymktc3BhcmstbGluZWFnZS9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9wbHVnaW4vbGluZWFnZS9ldmVudHMvT3BlcmF0aW9uTGluZWFnZUV2ZW50LnNjYWxh) | `66.66% <100.00%> (+2.66%)` | :arrow_up: |
   | [...ache/spark/kyuubi/lineage/SparkContextHelper.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3765/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZW5zaW9ucy9zcGFyay9reXV1Ymktc3BhcmstbGluZWFnZS9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL3NwYXJrL2t5dXViaS9saW5lYWdlL1NwYXJrQ29udGV4dEhlbHBlci5zY2FsYQ==) | `100.00% <100.00%> (ø)` | |
   | [...main/scala/org/apache/kyuubi/ctl/util/Render.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3765/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWN0bC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jdGwvdXRpbC9SZW5kZXIuc2NhbGE=) | `96.05% <100.00%> (ø)` | |
   | [...he/kyuubi/ha/client/etcd/EtcdDiscoveryClient.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3765/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL2NsaWVudC9ldGNkL0V0Y2REaXNjb3ZlcnlDbGllbnQuc2NhbGE=) | `68.33% <0.00%> (-0.56%)` | :arrow_down: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] turboFei commented on pull request #3765: [KYUUBI #3577][FOLLOWUP] Set default connectionUrl to empty string to prevent the UT stuck for metadata request retry

Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #3765:
URL: https://github.com/apache/incubator-kyuubi/pull/3765#issuecomment-1304422648

   cc @pan3793 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] turboFei commented on pull request #3765: [KYUUBI #3577][FOLLOWUP] Set default connectionUrl to empty string to prevent the UT stuck for metadata request retry

Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #3765:
URL: https://github.com/apache/incubator-kyuubi/pull/3765#issuecomment-1304438049

   thanks, merging to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] turboFei closed pull request #3765: [KYUUBI #3577][FOLLOWUP] Set default connectionUrl to empty string to prevent the UT stuck for metadata request retry

Posted by GitBox <gi...@apache.org>.
turboFei closed pull request #3765: [KYUUBI #3577][FOLLOWUP] Set default connectionUrl to empty string to prevent the UT stuck for metadata request retry
URL: https://github.com/apache/incubator-kyuubi/pull/3765


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org