You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Rohit Yadav <ro...@citrix.com> on 2012/07/31 13:33:07 UTC
Review Request: Fix debug issue, class not found, use sane names
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6239/
-----------------------------------------------------------
Review request for cloudstack and edison su.
Description
-------
Patch fixes file names and imports wherever used, in files introduced in 73be77a4c1877ae7e3613c7562d562ad96cde7ee
I've renamed discover to discoverer to fix the issue. My ant debug fails with:
[java] ERROR [utils.component.ComponentLocator] (main:) Unable to load configuration for management-server from components.xml
[java] com.cloud.utils.exception.CloudRuntimeException: Unable to find class: com.cloud.hypervisor.kvm.discoverer.KvmServerDiscoverer
Diffs
-----
server/src/com/cloud/agent/manager/AgentManagerImpl.java 9fb9027
server/src/com/cloud/hypervisor/kvm/discover/KvmDummyResourceBase.java 4069f55
server/src/com/cloud/hypervisor/kvm/discover/KvmServerDiscoverer.java 7b2492b
server/src/com/cloud/hypervisor/kvm/discoverer/KvmDummyResourceBase.java PRE-CREATION
server/src/com/cloud/hypervisor/kvm/discoverer/KvmServerDiscoverer.java PRE-CREATION
server/src/com/cloud/resource/ResourceManagerImpl.java 7f00da9
Diff: https://reviews.apache.org/r/6239/diff/
Testing
-------
Thanks,
Rohit Yadav
Re: Review Request: Fix debug issue, class not found, use sane names
Posted by Prasanna Santhanam <Pr...@citrix.com>.
> On July 31, 2012, 12:06 p.m., Prasanna Santhanam wrote:
> > Ship It!
Edison, could you please review this as well? I haven't pushed the fix here.
- Prasanna
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6239/#review9639
-----------------------------------------------------------
On July 31, 2012, 11:33 a.m., Rohit Yadav wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6239/
> -----------------------------------------------------------
>
> (Updated July 31, 2012, 11:33 a.m.)
>
>
> Review request for cloudstack and edison su.
>
>
> Description
> -------
>
> Patch fixes file names and imports wherever used, in files introduced in 73be77a4c1877ae7e3613c7562d562ad96cde7ee
> I've renamed discover to discoverer to fix the issue. My ant debug fails with:
> [java] ERROR [utils.component.ComponentLocator] (main:) Unable to load configuration for management-server from components.xml
> [java] com.cloud.utils.exception.CloudRuntimeException: Unable to find class: com.cloud.hypervisor.kvm.discoverer.KvmServerDiscoverer
>
>
> Diffs
> -----
>
> server/src/com/cloud/agent/manager/AgentManagerImpl.java 9fb9027
> server/src/com/cloud/hypervisor/kvm/discover/KvmDummyResourceBase.java 4069f55
> server/src/com/cloud/hypervisor/kvm/discover/KvmServerDiscoverer.java 7b2492b
> server/src/com/cloud/hypervisor/kvm/discoverer/KvmDummyResourceBase.java PRE-CREATION
> server/src/com/cloud/hypervisor/kvm/discoverer/KvmServerDiscoverer.java PRE-CREATION
> server/src/com/cloud/resource/ResourceManagerImpl.java 7f00da9
>
> Diff: https://reviews.apache.org/r/6239/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rohit Yadav
>
>
Re: Review Request: Fix debug issue, class not found, use sane names
Posted by Prasanna Santhanam <Pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6239/#review9639
-----------------------------------------------------------
Ship it!
Ship It!
- Prasanna Santhanam
On July 31, 2012, 11:33 a.m., Rohit Yadav wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6239/
> -----------------------------------------------------------
>
> (Updated July 31, 2012, 11:33 a.m.)
>
>
> Review request for cloudstack and edison su.
>
>
> Description
> -------
>
> Patch fixes file names and imports wherever used, in files introduced in 73be77a4c1877ae7e3613c7562d562ad96cde7ee
> I've renamed discover to discoverer to fix the issue. My ant debug fails with:
> [java] ERROR [utils.component.ComponentLocator] (main:) Unable to load configuration for management-server from components.xml
> [java] com.cloud.utils.exception.CloudRuntimeException: Unable to find class: com.cloud.hypervisor.kvm.discoverer.KvmServerDiscoverer
>
>
> Diffs
> -----
>
> server/src/com/cloud/agent/manager/AgentManagerImpl.java 9fb9027
> server/src/com/cloud/hypervisor/kvm/discover/KvmDummyResourceBase.java 4069f55
> server/src/com/cloud/hypervisor/kvm/discover/KvmServerDiscoverer.java 7b2492b
> server/src/com/cloud/hypervisor/kvm/discoverer/KvmDummyResourceBase.java PRE-CREATION
> server/src/com/cloud/hypervisor/kvm/discoverer/KvmServerDiscoverer.java PRE-CREATION
> server/src/com/cloud/resource/ResourceManagerImpl.java 7f00da9
>
> Diff: https://reviews.apache.org/r/6239/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rohit Yadav
>
>
Re: Review Request: Fix debug issue, class not found, use sane names
Posted by Rohit Yadav <ro...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6239/#review9656
-----------------------------------------------------------
http://wiki.videolan.org/Git#Commit
- Rohit Yadav
On July 31, 2012, 11:33 a.m., Rohit Yadav wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6239/
> -----------------------------------------------------------
>
> (Updated July 31, 2012, 11:33 a.m.)
>
>
> Review request for cloudstack and edison su.
>
>
> Description
> -------
>
> Patch fixes file names and imports wherever used, in files introduced in 73be77a4c1877ae7e3613c7562d562ad96cde7ee
> I've renamed discover to discoverer to fix the issue. My ant debug fails with:
> [java] ERROR [utils.component.ComponentLocator] (main:) Unable to load configuration for management-server from components.xml
> [java] com.cloud.utils.exception.CloudRuntimeException: Unable to find class: com.cloud.hypervisor.kvm.discoverer.KvmServerDiscoverer
>
>
> Diffs
> -----
>
> server/src/com/cloud/agent/manager/AgentManagerImpl.java 9fb9027
> server/src/com/cloud/hypervisor/kvm/discover/KvmDummyResourceBase.java 4069f55
> server/src/com/cloud/hypervisor/kvm/discover/KvmServerDiscoverer.java 7b2492b
> server/src/com/cloud/hypervisor/kvm/discoverer/KvmDummyResourceBase.java PRE-CREATION
> server/src/com/cloud/hypervisor/kvm/discoverer/KvmServerDiscoverer.java PRE-CREATION
> server/src/com/cloud/resource/ResourceManagerImpl.java 7f00da9
>
> Diff: https://reviews.apache.org/r/6239/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rohit Yadav
>
>