[GitHub] [trafficserver] bryancall commented on a diff in pull request #9322: Add TLSCertSwitchSupport

["bryancall (via GitHub)" <gi...@apache.org>]

bryancall commented on code in PR #9322:
URL: https://github.com/apache/trafficserver/pull/9322#discussion_r1121994963


##########
iocore/net/SSLUtils.cc:
##########
@@ -418,17 +306,19 @@ ssl_client_hello_callback(SSL *s, int *al, void *arg)
     return SSL_CLIENT_HELLO_ERROR;
   }
 
-  SSLNetVConnection *netvc = SSLNetVCAccess(s);
-  if (!netvc || netvc->ssl != s) {
-    Debug("ssl.error", "ssl_client_hello_callback call back on stale netvc");
-    return SSL_CLIENT_HELLO_ERROR;
-  }
-
-  bool reenabled = netvc->callHooks(TS_EVENT_SSL_CLIENT_HELLO);
+  SSLNetVConnection *netvc = dynamic_cast<SSLNetVConnection *>(snis);

Review Comment:
   Looking over the PR - I am concerned that we are adding 3 dynamic casts.  Dynamic casts seem to be expensive and have shown up in perf top.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org