You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "Roman Shaposhnik (Created) (JIRA)" <ji...@apache.org> on 2011/10/03 22:56:34 UTC

[jira] [Created] (FLUME-770) setting FLUME_IDENT_STRING based on $USER is not robust

setting FLUME_IDENT_STRING based on $USER is not robust
-------------------------------------------------------

                 Key: FLUME-770
                 URL: https://issues.apache.org/jira/browse/FLUME-770
             Project: Flume
          Issue Type: Bug
          Components: Shell
    Affects Versions: v0.9.4
            Reporter: Roman Shaposhnik
            Assignee: Roman Shaposhnik
            Priority: Minor
             Fix For: v0.9.5


The following bit of code from flume-daemon.sh fails to produce the correct result under sudo-type of execution:

{noformat}
if [ "$FLUME_IDENT_STRING" = "" ]; then
  export FLUME_IDENT_STRING="$USER"
fi
{noformat}

This is because $USER is not always set for shell. A more robust solution would be to use the output of id -nu


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (FLUME-770) setting FLUME_IDENT_STRING based on $USER is not robust

Posted by "Jonathan Hsieh (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FLUME-770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121061#comment-13121061 ] 

Jonathan Hsieh commented on FLUME-770:
--------------------------------------

testing by running 

FLUME_HOME=. FLUME_LOG_DIR=. bin/flume-daemon.sh start node 

Looks good to me.  Thanks!
                
> setting FLUME_IDENT_STRING based on $USER is not robust
> -------------------------------------------------------
>
>                 Key: FLUME-770
>                 URL: https://issues.apache.org/jira/browse/FLUME-770
>             Project: Flume
>          Issue Type: Bug
>          Components: Shell
>    Affects Versions: v0.9.4
>            Reporter: Roman Shaposhnik
>            Assignee: Roman Shaposhnik
>            Priority: Minor
>             Fix For: v0.9.5
>
>         Attachments: FLUME-770.patch.txt
>
>
> The following bit of code from flume-daemon.sh fails to produce the correct result under sudo-type of execution:
> if [ "$FLUME_IDENT_STRING" = "" ]; then
>   export FLUME_IDENT_STRING="$USER"
> fi
> This is because $USER is not always set for shell. A more robust solution would be to use the output of id -nu

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (FLUME-770) setting FLUME_IDENT_STRING based on $USER is not robust

Posted by "Roman Shaposhnik (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FLUME-770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Roman Shaposhnik updated FLUME-770:
-----------------------------------

    Attachment: FLUME-770.patch.txt
    
> setting FLUME_IDENT_STRING based on $USER is not robust
> -------------------------------------------------------
>
>                 Key: FLUME-770
>                 URL: https://issues.apache.org/jira/browse/FLUME-770
>             Project: Flume
>          Issue Type: Bug
>          Components: Shell
>    Affects Versions: v0.9.4
>            Reporter: Roman Shaposhnik
>            Assignee: Roman Shaposhnik
>            Priority: Minor
>             Fix For: v0.9.5
>
>         Attachments: FLUME-770.patch.txt
>
>
> The following bit of code from flume-daemon.sh fails to produce the correct result under sudo-type of execution:
> if [ "$FLUME_IDENT_STRING" = "" ]; then
>   export FLUME_IDENT_STRING="$USER"
> fi
> This is because $USER is not always set for shell. A more robust solution would be to use the output of id -nu

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (FLUME-770) setting FLUME_IDENT_STRING based on $USER is not robust

Posted by "Jonathan Hsieh (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FLUME-770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Hsieh updated FLUME-770:
---------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)
    
> setting FLUME_IDENT_STRING based on $USER is not robust
> -------------------------------------------------------
>
>                 Key: FLUME-770
>                 URL: https://issues.apache.org/jira/browse/FLUME-770
>             Project: Flume
>          Issue Type: Bug
>          Components: Shell
>    Affects Versions: v0.9.4
>            Reporter: Roman Shaposhnik
>            Assignee: Roman Shaposhnik
>            Priority: Minor
>             Fix For: v0.9.5
>
>         Attachments: FLUME-770.patch.txt
>
>
> The following bit of code from flume-daemon.sh fails to produce the correct result under sudo-type of execution:
> if [ "$FLUME_IDENT_STRING" = "" ]; then
>   export FLUME_IDENT_STRING="$USER"
> fi
> This is because $USER is not always set for shell. A more robust solution would be to use the output of id -nu

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (FLUME-770) setting FLUME_IDENT_STRING based on $USER is not robust

Posted by "Roman Shaposhnik (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FLUME-770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Roman Shaposhnik updated FLUME-770:
-----------------------------------

    Description: 
The following bit of code from flume-daemon.sh fails to produce the correct result under sudo-type of execution:

if [ "$FLUME_IDENT_STRING" = "" ]; then
  export FLUME_IDENT_STRING="$USER"
fi

This is because $USER is not always set for shell. A more robust solution would be to use the output of id -nu


  was:
The following bit of code from flume-daemon.sh fails to produce the correct result under sudo-type of execution:

{noformat}
if [ "$FLUME_IDENT_STRING" = "" ]; then
  export FLUME_IDENT_STRING="$USER"
fi
{noformat}

This is because $USER is not always set for shell. A more robust solution would be to use the output of id -nu


    
> setting FLUME_IDENT_STRING based on $USER is not robust
> -------------------------------------------------------
>
>                 Key: FLUME-770
>                 URL: https://issues.apache.org/jira/browse/FLUME-770
>             Project: Flume
>          Issue Type: Bug
>          Components: Shell
>    Affects Versions: v0.9.4
>            Reporter: Roman Shaposhnik
>            Assignee: Roman Shaposhnik
>            Priority: Minor
>             Fix For: v0.9.5
>
>
> The following bit of code from flume-daemon.sh fails to produce the correct result under sudo-type of execution:
> if [ "$FLUME_IDENT_STRING" = "" ]; then
>   export FLUME_IDENT_STRING="$USER"
> fi
> This is because $USER is not always set for shell. A more robust solution would be to use the output of id -nu

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (FLUME-770) setting FLUME_IDENT_STRING based on $USER is not robust

Posted by "Roman Shaposhnik (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FLUME-770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Roman Shaposhnik updated FLUME-770:
-----------------------------------

    Status: Patch Available  (was: Open)
    
> setting FLUME_IDENT_STRING based on $USER is not robust
> -------------------------------------------------------
>
>                 Key: FLUME-770
>                 URL: https://issues.apache.org/jira/browse/FLUME-770
>             Project: Flume
>          Issue Type: Bug
>          Components: Shell
>    Affects Versions: v0.9.4
>            Reporter: Roman Shaposhnik
>            Assignee: Roman Shaposhnik
>            Priority: Minor
>             Fix For: v0.9.5
>
>         Attachments: FLUME-770.patch.txt
>
>
> The following bit of code from flume-daemon.sh fails to produce the correct result under sudo-type of execution:
> if [ "$FLUME_IDENT_STRING" = "" ]; then
>   export FLUME_IDENT_STRING="$USER"
> fi
> This is because $USER is not always set for shell. A more robust solution would be to use the output of id -nu

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira