You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "J?rg Henne (JIRA)" <ji...@codehaus.org> on 2006/03/24 15:39:11 UTC

[jira] Created: (MNG-2178) incorrect M2_HOME guess in mvn.bat

incorrect M2_HOME guess in mvn.bat
----------------------------------

         Key: MNG-2178
         URL: http://jira.codehaus.org/browse/MNG-2178
     Project: Maven 2
        Type: Bug

  Components: Bootstrap & Build  
    Versions: 2.0.2    
 Environment: WXP
    Reporter: Jörg Henne


mvn.bat contains the following lines:

:chkMHome
if not "%M2_HOME%"=="" goto valMHome

if "%OS%"=="Windows_NT" SET M2_HOME=%~dps0\..
if not "%M2_HOME%"=="" goto valMHome

Guessing M2_HOME=%~dps0\.. leads to complaints later on, since the script expects m2.bat in bin/...:

if exist "%M2_HOME%\bin\m2.bat" goto init

Hence, the line should read:

if "%OS%"=="Windows_NT" SET M2_HOME=%~dps0\..\..

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (MNG-2178) incorrect M2_HOME guess in mvn.bat

Posted by "Kenney Westerhof (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-2178?page=all ]

Kenney Westerhof updated MNG-2178:
----------------------------------

    Fix Version/s:     (was: 2.0.5)
                   2.0.6

> incorrect M2_HOME guess in mvn.bat
> ----------------------------------
>
>                 Key: MNG-2178
>                 URL: http://jira.codehaus.org/browse/MNG-2178
>             Project: Maven 2
>          Issue Type: Bug
>          Components: Bootstrap & Build
>    Affects Versions: 2.0.2
>         Environment: WXP
>            Reporter: Jörg Henne
>             Fix For: 2.0.6
>
>
> mvn.bat contains the following lines:
> :chkMHome
> if not "%M2_HOME%"=="" goto valMHome
> if "%OS%"=="Windows_NT" SET M2_HOME=%~dps0\..
> if not "%M2_HOME%"=="" goto valMHome
> Guessing M2_HOME=%~dps0\.. leads to complaints later on, since the script expects m2.bat in bin/...:
> if exist "%M2_HOME%\bin\m2.bat" goto init
> Hence, the line should read:
> if "%OS%"=="Windows_NT" SET M2_HOME=%~dps0\..\..

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Closed: (MNG-2178) incorrect M2_HOME guess in mvn.bat

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-2178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Casey closed MNG-2178.
---------------------------

    Resolution: Fixed

I can't actually test this fix, so if someone finds that it's still not working, reopen this.

> incorrect M2_HOME guess in mvn.bat
> ----------------------------------
>
>                 Key: MNG-2178
>                 URL: http://jira.codehaus.org/browse/MNG-2178
>             Project: Maven 2
>          Issue Type: Bug
>          Components: Bootstrap & Build
>    Affects Versions: 2.0.2
>         Environment: WXP
>            Reporter: Jörg Henne
>            Assignee: John Casey
>             Fix For: 2.0.9, 2.1-alpha-1
>
>
> mvn.bat contains the following lines:
> :chkMHome
> if not "%M2_HOME%"=="" goto valMHome
> if "%OS%"=="Windows_NT" SET M2_HOME=%~dps0\..
> if not "%M2_HOME%"=="" goto valMHome
> Guessing M2_HOME=%~dps0\.. leads to complaints later on, since the script expects m2.bat in bin/...:
> if exist "%M2_HOME%\bin\m2.bat" goto init
> Hence, the line should read:
> if "%OS%"=="Windows_NT" SET M2_HOME=%~dps0\..\..

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Commented: (MNG-2178) incorrect M2_HOME guess in mvn.bat

Posted by "Alexander Veit (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-2178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_86151 ] 

Alexander Veit commented on MNG-2178:
-------------------------------------

if "%OS%"=="Windows_NT" SET M2_HOME=%~dp0.. seems to be correct.

This bug is probably more severe than it might seem, since child processes inherit the malformed path.

> incorrect M2_HOME guess in mvn.bat
> ----------------------------------
>
>                 Key: MNG-2178
>                 URL: http://jira.codehaus.org/browse/MNG-2178
>             Project: Maven 2
>          Issue Type: Bug
>          Components: Bootstrap & Build
>    Affects Versions: 2.0.2
>         Environment: WXP
>            Reporter: Jörg Henne
>             Fix For: 2.0.x
>
>
> mvn.bat contains the following lines:
> :chkMHome
> if not "%M2_HOME%"=="" goto valMHome
> if "%OS%"=="Windows_NT" SET M2_HOME=%~dps0\..
> if not "%M2_HOME%"=="" goto valMHome
> Guessing M2_HOME=%~dps0\.. leads to complaints later on, since the script expects m2.bat in bin/...:
> if exist "%M2_HOME%\bin\m2.bat" goto init
> Hence, the line should read:
> if "%OS%"=="Windows_NT" SET M2_HOME=%~dps0\..\..

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Updated: (MNG-2178) incorrect M2_HOME guess in mvn.bat

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-2178?page=all ]

John Casey updated MNG-2178:
----------------------------

    Fix Version: 2.0.5

> incorrect M2_HOME guess in mvn.bat
> ----------------------------------
>
>          Key: MNG-2178
>          URL: http://jira.codehaus.org/browse/MNG-2178
>      Project: Maven 2
>         Type: Bug

>   Components: Bootstrap & Build
>     Versions: 2.0.2
>  Environment: WXP
>     Reporter: Jörg Henne
>      Fix For: 2.0.5

>
>
> mvn.bat contains the following lines:
> :chkMHome
> if not "%M2_HOME%"=="" goto valMHome
> if "%OS%"=="Windows_NT" SET M2_HOME=%~dps0\..
> if not "%M2_HOME%"=="" goto valMHome
> Guessing M2_HOME=%~dps0\.. leads to complaints later on, since the script expects m2.bat in bin/...:
> if exist "%M2_HOME%\bin\m2.bat" goto init
> Hence, the line should read:
> if "%OS%"=="Windows_NT" SET M2_HOME=%~dps0\..\..

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (MNG-2178) incorrect M2_HOME guess in mvn.bat

Posted by "Vincent Siveton (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-2178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vincent Siveton updated MNG-2178:
---------------------------------

    Fix Version/s:     (was: 2.0.x)
                   2.1-alpha-1
                   2.0.9

> incorrect M2_HOME guess in mvn.bat
> ----------------------------------
>
>                 Key: MNG-2178
>                 URL: http://jira.codehaus.org/browse/MNG-2178
>             Project: Maven 2
>          Issue Type: Bug
>          Components: Bootstrap & Build
>    Affects Versions: 2.0.2
>         Environment: WXP
>            Reporter: Jörg Henne
>             Fix For: 2.0.9, 2.1-alpha-1
>
>
> mvn.bat contains the following lines:
> :chkMHome
> if not "%M2_HOME%"=="" goto valMHome
> if "%OS%"=="Windows_NT" SET M2_HOME=%~dps0\..
> if not "%M2_HOME%"=="" goto valMHome
> Guessing M2_HOME=%~dps0\.. leads to complaints later on, since the script expects m2.bat in bin/...:
> if exist "%M2_HOME%\bin\m2.bat" goto init
> Hence, the line should read:
> if "%OS%"=="Windows_NT" SET M2_HOME=%~dps0\..\..

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Commented: (MNG-2178) incorrect M2_HOME guess in mvn.bat

Posted by "Thai Ha (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-2178?page=comments#action_62943 ] 

Thai Ha commented on MNG-2178:
------------------------------

I believe that this issue should be fixed as below:

if "%OS%"=="Windows_NT" SET M2_HOME=%~dp0..

This fix should be applied to Maven 2.0.3 too because Maven 2.0.3 is using (%~dp0\..) and the slash is redundant.

Note:
If you have Ant 1.6.5, you can open ant.bat and see (line 25) set DEFAULT_ANT_HOME=%~dp0..



> incorrect M2_HOME guess in mvn.bat
> ----------------------------------
>
>          Key: MNG-2178
>          URL: http://jira.codehaus.org/browse/MNG-2178
>      Project: Maven 2
>         Type: Bug

>   Components: Bootstrap & Build
>     Versions: 2.0.2
>  Environment: WXP
>     Reporter: Jörg Henne

>
>
> mvn.bat contains the following lines:
> :chkMHome
> if not "%M2_HOME%"=="" goto valMHome
> if "%OS%"=="Windows_NT" SET M2_HOME=%~dps0\..
> if not "%M2_HOME%"=="" goto valMHome
> Guessing M2_HOME=%~dps0\.. leads to complaints later on, since the script expects m2.bat in bin/...:
> if exist "%M2_HOME%\bin\m2.bat" goto init
> Hence, the line should read:
> if "%OS%"=="Windows_NT" SET M2_HOME=%~dps0\..\..

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira