You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/12/17 22:13:34 UTC

[GitHub] [beam] pabloem opened a new pull request #13578: [release-2.27.0][cherry-pick] Adding combiner packing optimization for Portable Runner

pabloem opened a new pull request #13578:
URL: https://github.com/apache/beam/pull/13578


   **Please** add a meaningful description for your change here
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
   
   Post-Commit Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   
   Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
   --- | --- | --- | --- | --- | --- | ---
   Go | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
   Java | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/badge/icon)](https://ci-beam
 .apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [![Build Status](https://ci-beam.a
 pache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
   Python | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[![Build Status](https://ci-beam
 .apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
   XLang | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Dataflow/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Dataflow/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
   
   Pre-Commit Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   
   --- |Java | Python | Go | Website | Whitespace | Typescript
   --- | --- | --- | --- | --- | --- | ---
   Non-portable | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) <br>[![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/be
 am_PreCommit_Go_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/)
   Portable | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | --- | --- | ---
   
   See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
   
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #13578: [release-2.27.0][cherry-pick] Adding combiner packing optimization for Portable Runner

Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #13578:
URL: https://github.com/apache/beam/pull/13578#issuecomment-749330587


   Run Python 3.8 PostCommit


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #13578: [release-2.27.0][cherry-pick] Adding combiner packing optimization for Portable Runner

Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #13578:
URL: https://github.com/apache/beam/pull/13578#issuecomment-749312755






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] commented on pull request #13578: [release-2.27.0][cherry-pick] Adding combiner packing optimization for Portable Runner

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13578:
URL: https://github.com/apache/beam/pull/13578#issuecomment-747748075


   # [Codecov](https://codecov.io/gh/apache/beam/pull/13578?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`release-2.27.0@5f253b6`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/13578/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/13578?src=pr&el=tree)
   
   ```diff
   @@                Coverage Diff                @@
   ##             release-2.27.0   #13578   +/-   ##
   =================================================
     Coverage                  ?   82.70%           
   =================================================
     Files                     ?      466           
     Lines                     ?    57518           
     Branches                  ?        0           
   =================================================
     Hits                      ?    47573           
     Misses                    ?     9945           
     Partials                  ?        0           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13578?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13578?src=pr&el=footer). Last update [5f253b6...2202581](https://codecov.io/gh/apache/beam/pull/13578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #13578: [release-2.27.0][cherry-pick] Adding combiner packing optimization for Portable Runner

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13578:
URL: https://github.com/apache/beam/pull/13578#issuecomment-747748075


   # [Codecov](https://codecov.io/gh/apache/beam/pull/13578?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`release-2.27.0@5f253b6`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/13578/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/13578?src=pr&el=tree)
   
   ```diff
   @@                Coverage Diff                @@
   ##             release-2.27.0   #13578   +/-   ##
   =================================================
     Coverage                  ?   82.70%           
   =================================================
     Files                     ?      466           
     Lines                     ?    57518           
     Branches                  ?        0           
   =================================================
     Hits                      ?    47573           
     Misses                    ?     9945           
     Partials                  ?        0           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13578?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13578?src=pr&el=footer). Last update [5f253b6...2202581](https://codecov.io/gh/apache/beam/pull/13578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #13578: [release-2.27.0][cherry-pick] Adding combiner packing optimization for Portable Runner

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13578:
URL: https://github.com/apache/beam/pull/13578#issuecomment-747748075


   # [Codecov](https://codecov.io/gh/apache/beam/pull/13578?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`release-2.27.0@5f253b6`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/13578/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/13578?src=pr&el=tree)
   
   ```diff
   @@                Coverage Diff                @@
   ##             release-2.27.0   #13578   +/-   ##
   =================================================
     Coverage                  ?   82.71%           
   =================================================
     Files                     ?      466           
     Lines                     ?    57518           
     Branches                  ?        0           
   =================================================
     Hits                      ?    47574           
     Misses                    ?     9944           
     Partials                  ?        0           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13578?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13578?src=pr&el=footer). Last update [5f253b6...2202581](https://codecov.io/gh/apache/beam/pull/13578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #13578: [release-2.27.0][cherry-pick] Adding combiner packing optimization for Portable Runner

Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #13578:
URL: https://github.com/apache/beam/pull/13578#issuecomment-749576310


   ([failing job](https://pantheon.corp.google.com/dataflow/jobs/us-central1/2020-12-21_20_44_59-2909807063375353538;step=;bottomTab=JOB_LOGS;expandBottomPanel=false;logsSeverity=ERROR?project=apache-beam-testing))


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #13578: [release-2.27.0][cherry-pick] Adding combiner packing optimization for Portable Runner

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13578:
URL: https://github.com/apache/beam/pull/13578#issuecomment-747748075


   # [Codecov](https://codecov.io/gh/apache/beam/pull/13578?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`release-2.27.0@5f253b6`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/13578/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/13578?src=pr&el=tree)
   
   ```diff
   @@                Coverage Diff                @@
   ##             release-2.27.0   #13578   +/-   ##
   =================================================
     Coverage                  ?   82.71%           
   =================================================
     Files                     ?      466           
     Lines                     ?    57518           
     Branches                  ?        0           
   =================================================
     Hits                      ?    47574           
     Misses                    ?     9944           
     Partials                  ?        0           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13578?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13578?src=pr&el=footer). Last update [5f253b6...2202581](https://codecov.io/gh/apache/beam/pull/13578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #13578: [release-2.27.0][cherry-pick] Adding combiner packing optimization for Portable Runner

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13578:
URL: https://github.com/apache/beam/pull/13578#issuecomment-747748075


   # [Codecov](https://codecov.io/gh/apache/beam/pull/13578?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`release-2.27.0@5f253b6`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/13578/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/13578?src=pr&el=tree)
   
   ```diff
   @@                Coverage Diff                @@
   ##             release-2.27.0   #13578   +/-   ##
   =================================================
     Coverage                  ?   82.70%           
   =================================================
     Files                     ?      466           
     Lines                     ?    57518           
     Branches                  ?        0           
   =================================================
     Hits                      ?    47573           
     Misses                    ?     9945           
     Partials                  ?        0           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13578?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13578?src=pr&el=footer). Last update [5f253b6...2202581](https://codecov.io/gh/apache/beam/pull/13578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #13578: [release-2.27.0][cherry-pick] Adding combiner packing optimization for Portable Runner

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13578:
URL: https://github.com/apache/beam/pull/13578#issuecomment-747748075


   # [Codecov](https://codecov.io/gh/apache/beam/pull/13578?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`release-2.27.0@5f253b6`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/13578/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/13578?src=pr&el=tree)
   
   ```diff
   @@                Coverage Diff                @@
   ##             release-2.27.0   #13578   +/-   ##
   =================================================
     Coverage                  ?   82.71%           
   =================================================
     Files                     ?      466           
     Lines                     ?    57518           
     Branches                  ?        0           
   =================================================
     Hits                      ?    47574           
     Misses                    ?     9944           
     Partials                  ?        0           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13578?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13578?src=pr&el=footer). Last update [5f253b6...2202581](https://codecov.io/gh/apache/beam/pull/13578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #13578: [release-2.27.0][cherry-pick] Adding combiner packing optimization for Portable Runner

Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #13578:
URL: https://github.com/apache/beam/pull/13578#issuecomment-749734938


   Verified these tests locally. The are failing due to the docker container `apache/beam_java8_sdk:2.27.0.dev` being missing


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #13578: [release-2.27.0][cherry-pick] Adding combiner packing optimization for Portable Runner

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13578:
URL: https://github.com/apache/beam/pull/13578#issuecomment-747748075


   # [Codecov](https://codecov.io/gh/apache/beam/pull/13578?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`release-2.27.0@5f253b6`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/13578/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/13578?src=pr&el=tree)
   
   ```diff
   @@                Coverage Diff                @@
   ##             release-2.27.0   #13578   +/-   ##
   =================================================
     Coverage                  ?   82.70%           
   =================================================
     Files                     ?      466           
     Lines                     ?    57518           
     Branches                  ?        0           
   =================================================
     Hits                      ?    47573           
     Misses                    ?     9945           
     Partials                  ?        0           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13578?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13578?src=pr&el=footer). Last update [5f253b6...2202581](https://codecov.io/gh/apache/beam/pull/13578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #13578: [release-2.27.0][cherry-pick] Adding combiner packing optimization for Portable Runner

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13578:
URL: https://github.com/apache/beam/pull/13578#issuecomment-747748075


   # [Codecov](https://codecov.io/gh/apache/beam/pull/13578?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`release-2.27.0@5f253b6`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/13578/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/13578?src=pr&el=tree)
   
   ```diff
   @@                Coverage Diff                @@
   ##             release-2.27.0   #13578   +/-   ##
   =================================================
     Coverage                  ?   82.71%           
   =================================================
     Files                     ?      466           
     Lines                     ?    57518           
     Branches                  ?        0           
   =================================================
     Hits                      ?    47574           
     Misses                    ?     9944           
     Partials                  ?        0           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13578?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13578?src=pr&el=footer). Last update [5f253b6...2202581](https://codecov.io/gh/apache/beam/pull/13578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #13578: [release-2.27.0][cherry-pick] Adding combiner packing optimization for Portable Runner

Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #13578:
URL: https://github.com/apache/beam/pull/13578#issuecomment-749260960


   Run Python 3.8 PostCommit
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem merged pull request #13578: [release-2.27.0][cherry-pick] Adding combiner packing optimization for Portable Runner

Posted by GitBox <gi...@apache.org>.
pabloem merged pull request #13578:
URL: https://github.com/apache/beam/pull/13578


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #13578: [release-2.27.0][cherry-pick] Adding combiner packing optimization for Portable Runner

Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #13578:
URL: https://github.com/apache/beam/pull/13578#issuecomment-749585940






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #13578: [release-2.27.0][cherry-pick] Adding combiner packing optimization for Portable Runner

Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #13578:
URL: https://github.com/apache/beam/pull/13578#issuecomment-747848886


   Run Python 3.8 PostCommit


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #13578: [release-2.27.0][cherry-pick] Adding combiner packing optimization for Portable Runner

Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #13578:
URL: https://github.com/apache/beam/pull/13578#issuecomment-749575871


   @robertwb @chamikaramj I'm seeing some validation errors with this cherry-pick - any ideas?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #13578: [release-2.27.0][cherry-pick] Adding combiner packing optimization for Portable Runner

Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #13578:
URL: https://github.com/apache/beam/pull/13578#issuecomment-748523244


   Run Python 3.8 PostCommit
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #13578: [release-2.27.0][cherry-pick] Adding combiner packing optimization for Portable Runner

Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #13578:
URL: https://github.com/apache/beam/pull/13578#issuecomment-747733804






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #13578: [release-2.27.0][cherry-pick] Adding combiner packing optimization for Portable Runner

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13578:
URL: https://github.com/apache/beam/pull/13578#issuecomment-747748075


   # [Codecov](https://codecov.io/gh/apache/beam/pull/13578?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`release-2.27.0@5f253b6`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/13578/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/13578?src=pr&el=tree)
   
   ```diff
   @@                Coverage Diff                @@
   ##             release-2.27.0   #13578   +/-   ##
   =================================================
     Coverage                  ?   82.71%           
   =================================================
     Files                     ?      466           
     Lines                     ?    57518           
     Branches                  ?        0           
   =================================================
     Hits                      ?    47574           
     Misses                    ?     9944           
     Partials                  ?        0           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13578?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13578?src=pr&el=footer). Last update [5f253b6...2202581](https://codecov.io/gh/apache/beam/pull/13578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org