You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/06/17 00:13:42 UTC
[GitHub] [fineract] percyashu opened a new pull request #1075: FINERACT-822 Enforce StringSplitter check
percyashu opened a new pull request #1075:
URL: https://github.com/apache/fineract/pull/1075
FINERACT-822
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] percyashu commented on a change in pull request #1075: FINERACT-822 Enforce StringSplitter check
Posted by GitBox <gi...@apache.org>.
percyashu commented on a change in pull request #1075:
URL: https://github.com/apache/fineract/pull/1075#discussion_r442173825
##########
File path: fineract-provider/src/main/java/org/apache/fineract/infrastructure/security/utils/ColumnValidator.java
##########
@@ -122,6 +122,7 @@ public void validateSqlInjection(String schema, String... conditions) {
return tableColumnMap;
}
+ @SuppressWarnings("StringSplitter")
Review comment:
Using the Splitter implementation in this method causes an errors in some integration test, I looked into but wasnt making any inroads to find out what was causing this. Will create an issue on issue tracker to remove the annotation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on a change in pull request #1075: FINERACT-822 Enforce StringSplitter check
Posted by GitBox <gi...@apache.org>.
awasum commented on a change in pull request #1075:
URL: https://github.com/apache/fineract/pull/1075#discussion_r442125309
##########
File path: fineract-provider/src/main/java/org/apache/fineract/infrastructure/security/utils/ColumnValidator.java
##########
@@ -122,6 +122,7 @@ public void validateSqlInjection(String schema, String... conditions) {
return tableColumnMap;
}
+ @SuppressWarnings("StringSplitter")
Review comment:
Why did you suppress this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #1075: FINERACT-822 Enforce StringSplitter check
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1075:
URL: https://github.com/apache/fineract/pull/1075#issuecomment-645933576
@vorburger merge this when you can. Or maybe you want to take another quick look to make sure am not missing something. @ptuomola @xurror @thesmallstar take a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1075: FINERACT-822 Enforce StringSplitter check
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1075:
URL: https://github.com/apache/fineract/pull/1075#issuecomment-645596500
@awasum will you be doing a more detailed review if this PR? (Your GSoC student.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger merged pull request #1075: FINERACT-822 Enforce StringSplitter check
Posted by GitBox <gi...@apache.org>.
vorburger merged pull request #1075:
URL: https://github.com/apache/fineract/pull/1075
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger edited a comment on pull request #1075: FINERACT-822 Enforce StringSplitter check
Posted by GitBox <gi...@apache.org>.
vorburger edited a comment on pull request #1075:
URL: https://github.com/apache/fineract/pull/1075#issuecomment-645596500
@awasum will you be doing a more detailed review of this PR? (Your GSoC student.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on a change in pull request #1075: FINERACT-822 Enforce StringSplitter check
Posted by GitBox <gi...@apache.org>.
awasum commented on a change in pull request #1075:
URL: https://github.com/apache/fineract/pull/1075#discussion_r442125309
##########
File path: fineract-provider/src/main/java/org/apache/fineract/infrastructure/security/utils/ColumnValidator.java
##########
@@ -122,6 +122,7 @@ public void validateSqlInjection(String schema, String... conditions) {
return tableColumnMap;
}
+ @SuppressWarnings("StringSplitter")
Review comment:
Why this you suppress this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org