[jira] [Commented] (GROOVY-8321) !instanceof treated incorrectly in type checker

["Daniel Sun (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GROOVY-8321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592750#comment-16592750 ] 

Daniel Sun commented on GROOVY-8321:
------------------------------------

We can get compilation error on master:


{code:java}
[Static type checking] - Cannot find matching method java.lang.Object#toUpperCase(). Please check if the declared type is correct and if the method exists.
 at line: 6, column: 13
{code}


{code:java}
[42, 'bar'].each { doit(it) }

@groovy.transform.TypeChecked
doit(arg) {
  if (arg !instanceof String) {
    println arg.toUpperCase() // MME: Integer.toUpperCase()
  } else {
    // println arg.toUpperCase() // [STC] [Static type checking] - Cannot find Object#toUpperCase()
    println 'is a number'
  }
}
{code}


> !instanceof treated incorrectly in type checker
> -----------------------------------------------
>
>                 Key: GROOVY-8321
>                 URL: https://issues.apache.org/jira/browse/GROOVY-8321
>             Project: Groovy
>          Issue Type: Bug
>          Components: Static Type Checker
>    Affects Versions: 2.6.0-alpha-1
>            Reporter: Paul King
>            Priority: Major
>
> Currently in:
> https://github.com/apache/groovy/blob/183b8fbf0248a2dceffbba684e50c3c2c060e46c/src/main/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java#L703
> The `instanceof` and `!instanceof` operators are treated the same when in fact the exact opposite is required.
> Consider the following code where the `instanceof` has been _accidentally_ replaced with `!instanceof`. 
> {code}
> [42, 'bar'].each { doit(it) }
> @groovy.transform.TypeChecked
> doit(arg) {
>   if (arg !instanceof String) {
>     println arg.toUpperCase() // MME: Integer.toUpperCase()
>   } else {
>     // println arg.toUpperCase() // [STC] [Static type checking] - Cannot find Object#toUpperCase()
>     println 'is a number'
>   }
> }
> {code}
> We'd now expect the `toUpperCase` call to fail compilation but it succeeds and then fails at runtime.
> Bonus points if the commented line in the else clause can be made to work.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)