You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "junichi11 (via GitHub)" <gi...@apache.org> on 2023/11/17 04:58:19 UTC
[PR] PHP: Improve the performance for Go to Declaration [netbeans]
junichi11 opened a new pull request, #6712:
URL: https://github.com/apache/netbeans/pull/6712
- https://github.com/apache/netbeans/issues/3933
- https://github.com/apache/netbeans/issues/6634
- Don't add empty type names to avoid getting types from an index using them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] PHP: Improve the performance for Go to Declaration [netbeans]
Posted by "KacerCZ (via GitHub)" <gi...@apache.org>.
KacerCZ commented on PR #6712:
URL: https://github.com/apache/netbeans/pull/6712#issuecomment-1819475507
@junichi11 Today I was using dev build with this patch for regular development, cache was cleared before starting.
Navigation was faster than in 20-rc4 on same project.
Thank you for your work.
@czukowski Unless some critical bug is found in 20-rc4, no more changes will be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] PHP: Improve the performance for Go to Declaration [netbeans]
Posted by "tmysik (via GitHub)" <gi...@apache.org>.
tmysik commented on PR #6712:
URL: https://github.com/apache/netbeans/pull/6712#issuecomment-1838234293
@mvorisek
In short - it should not work (once a release is done, all module versions and dependencies are increased, typically). However, as @junichi11 wrote, you should be able to download the fresh dev build, that now contains just a minimum changes in comparison to the latest release (yes, I noticed the bug you just reported).
Please note that the auto-update in dev builds can be broken; this is expected and if this happens to you, simply download a new, fresh build, it should work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] PHP: Improve the performance for Go to Declaration [netbeans]
Posted by "mvorisek (via GitHub)" <gi...@apache.org>.
mvorisek commented on PR #6712:
URL: https://github.com/apache/netbeans/pull/6712#issuecomment-1838098064
I know. My question is if the (fixed) nb21 php module from nightly build can be used with regular nb20 install.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] PHP: Improve the performance for Go to Declaration [netbeans]
Posted by "junichi11 (via GitHub)" <gi...@apache.org>.
junichi11 merged PR #6712:
URL: https://github.com/apache/netbeans/pull/6712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] PHP: Improve the performance for Go to Declaration [netbeans]
Posted by "junichi11 (via GitHub)" <gi...@apache.org>.
junichi11 commented on PR #6712:
URL: https://github.com/apache/netbeans/pull/6712#issuecomment-1819917968
@terax6669 @czukowski @KacerCZ Thank you for testing it!
> If there's still a chance to squeeze this into NB20
Unfortunately, we cannot merge this into NB20. (I wish I could have fixed it sooner, but it was too late.)
At least, we can merge it into the next version :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] PHP: Improve the performance for Go to Declaration [netbeans]
Posted by "tmysik (via GitHub)" <gi...@apache.org>.
tmysik commented on PR #6712:
URL: https://github.com/apache/netbeans/pull/6712#issuecomment-1817393178
@junichi11 Sure, up to you, of course 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] PHP: Improve the performance for Go to Declaration [netbeans]
Posted by "terax6669 (via GitHub)" <gi...@apache.org>.
terax6669 commented on PR #6712:
URL: https://github.com/apache/netbeans/pull/6712#issuecomment-1816393747
Try to rename a class or a property in the project I sent you for testing.
I'm using the dev build now and I can see that alt+f7 (see usages) is not working as well, disappeared from the context menu.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] PHP: Improve the performance for Go to Declaration [netbeans]
Posted by "terax6669 (via GitHub)" <gi...@apache.org>.
terax6669 commented on PR #6712:
URL: https://github.com/apache/netbeans/pull/6712#issuecomment-1816572410
Nevermind, after going into options NetBeans did some PHP initialization and it's working now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] PHP: Improve the performance for Go to Declaration [netbeans]
Posted by "tmysik (via GitHub)" <gi...@apache.org>.
tmysik commented on PR #6712:
URL: https://github.com/apache/netbeans/pull/6712#issuecomment-1817377065
@terax6669
Several unexpected exceptions can happen sooner or later when using the dev builds of NetBeans. From time to time, it could be a good idea to (a) download a fresh build of NetBeans from the website and/or (b) clean (delete) the userdir (please note that you will lose your configuration, so using configuration export and import might be useful).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] PHP: Improve the performance for Go to Declaration [netbeans]
Posted by "junichi11 (via GitHub)" <gi...@apache.org>.
junichi11 commented on PR #6712:
URL: https://github.com/apache/netbeans/pull/6712#issuecomment-1817268721
@terax6669 It's not related to this. So, could you report it as a new issue? (But it's strange... NPE should be occurred there...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] PHP: Improve the performance for Go to Declaration [netbeans]
Posted by "junichi11 (via GitHub)" <gi...@apache.org>.
junichi11 commented on PR #6712:
URL: https://github.com/apache/netbeans/pull/6712#issuecomment-1837778056
NB21 is the next release version. Please use it as it is without copying it into NB20 when NB21 is released.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] PHP: Improve the performance for Go to Declaration [netbeans]
Posted by "junichi11 (via GitHub)" <gi...@apache.org>.
junichi11 commented on PR #6712:
URL: https://github.com/apache/netbeans/pull/6712#issuecomment-1838208676
I'm not sure whether it works correctly. If you want to do it, please do it at your own risk.
Usually, in such a case, please use the dev build version (after the php-nb21-features branch is merged into the master). Or, please wait until NB21 is released.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] PHP: Improve the performance for Go to Declaration [netbeans]
Posted by "haidubogdan (via GitHub)" <gi...@apache.org>.
haidubogdan commented on PR #6712:
URL: https://github.com/apache/netbeans/pull/6712#issuecomment-1821032250
On **windows 11** with medium-large sized projects
I'm not seeing any issues so far. It seems stable, the declaration info, find usage, go to method actions are more consistent overall.
For me the indexing process seems to be a little slower (maybe as a dev build the application doesn't use all the processor threads ? or something has changed on nb 20 compared to nb 19).
The same slowness is on changing **git** branches (reindex), in the sense that it takes some time until the declaration origin of methods or class is discovered by the project.
I don't think the slowness is related to the fix, but I would have to wait for the release of netbeans 20 to compare with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] PHP: Improve the performance for Go to Declaration [netbeans]
Posted by "junichi11 (via GitHub)" <gi...@apache.org>.
junichi11 commented on PR #6712:
URL: https://github.com/apache/netbeans/pull/6712#issuecomment-1816309395
> this new build breaks refactoring.
I'm not sure if you don't write what you are doing exactly. (I can't reproduce it.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] PHP: Improve the performance for Go to Declaration [netbeans]
Posted by "terax6669 (via GitHub)" <gi...@apache.org>.
terax6669 commented on PR #6712:
URL: https://github.com/apache/netbeans/pull/6712#issuecomment-1816899684
I keep using the dev build throughout the day and I just noticed a red icon on my status bar. I don't know when it occured and if it's related to the PR, but I'll paste my IDE log here.
```
WARNING [org.netbeans.modules.csl.hints.infrastructure.SuggestionsTask]
java.lang.NullPointerException: Cannot invoke "org.openide.filesystems.FileObject.canWrite()" because "fileObject" is null
at org.netbeans.modules.php.editor.verification.IntroduceSuggestion$IntroduceFixVisitor.visit(IntroduceSuggestion.java:291)
at org.netbeans.modules.php.editor.parser.astnodes.FieldAccess.accept(FieldAccess.java:58)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultVisitor.scan(DefaultVisitor.java:143)
at org.netbeans.modules.php.editor.verification.IntroduceSuggestion$IntroduceFixVisitor.scan(IntroduceSuggestion.java:185)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultVisitor.visit(DefaultVisitor.java:786)
at org.netbeans.modules.php.editor.parser.astnodes.ArrayDimension.accept(ArrayDimension.java:64)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultVisitor.scan(DefaultVisitor.java:143)
at org.netbeans.modules.php.editor.verification.IntroduceSuggestion$IntroduceFixVisitor.scan(IntroduceSuggestion.java:185)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultVisitor.visit(DefaultVisitor.java:158)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultTreePathVisitor.visit(DefaultTreePathVisitor.java:171)
at org.netbeans.modules.php.editor.parser.astnodes.ArrayAccess.accept(ArrayAccess.java:63)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultVisitor.scan(DefaultVisitor.java:143)
at org.netbeans.modules.php.editor.verification.IntroduceSuggestion$IntroduceFixVisitor.scan(IntroduceSuggestion.java:185)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultVisitor.visit(DefaultVisitor.java:182)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultTreePathVisitor.visit(DefaultTreePathVisitor.java:199)
at org.netbeans.modules.php.editor.parser.astnodes.Assignment.accept(Assignment.java:105)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultVisitor.scan(DefaultVisitor.java:143)
at org.netbeans.modules.php.editor.verification.IntroduceSuggestion$IntroduceFixVisitor.scan(IntroduceSuggestion.java:185)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultVisitor.visit(DefaultVisitor.java:340)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultTreePathVisitor.visit(DefaultTreePathVisitor.java:370)
at org.netbeans.modules.php.editor.parser.astnodes.ExpressionStatement.accept(ExpressionStatement.java:51)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultVisitor.scan(DefaultVisitor.java:143)
at org.netbeans.modules.php.editor.verification.IntroduceSuggestion$IntroduceFixVisitor.scan(IntroduceSuggestion.java:185)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultVisitor.scan(DefaultVisitor.java:150)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultVisitor.visit(DefaultVisitor.java:212)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultTreePathVisitor.visit(DefaultTreePathVisitor.java:237)
at org.netbeans.modules.php.editor.parser.astnodes.Block.accept(Block.java:70)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultVisitor.scan(DefaultVisitor.java:143)
at org.netbeans.modules.php.editor.verification.IntroduceSuggestion$IntroduceFixVisitor.scan(IntroduceSuggestion.java:185)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultVisitor.visit(DefaultVisitor.java:422)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultTreePathVisitor.visit(DefaultTreePathVisitor.java:454)
at org.netbeans.modules.php.editor.parser.astnodes.IfStatement.accept(IfStatement.java:85)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultVisitor.scan(DefaultVisitor.java:143)
at org.netbeans.modules.php.editor.verification.IntroduceSuggestion$IntroduceFixVisitor.scan(IntroduceSuggestion.java:185)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultVisitor.scan(DefaultVisitor.java:150)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultVisitor.visit(DefaultVisitor.java:212)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultTreePathVisitor.visit(DefaultTreePathVisitor.java:237)
at org.netbeans.modules.php.editor.parser.astnodes.Block.accept(Block.java:70)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultVisitor.scan(DefaultVisitor.java:143)
at org.netbeans.modules.php.editor.verification.IntroduceSuggestion$IntroduceFixVisitor.scan(IntroduceSuggestion.java:185)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultVisitor.visit(DefaultVisitor.java:371)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultTreePathVisitor.visit(DefaultTreePathVisitor.java:398)
at org.netbeans.modules.php.editor.parser.astnodes.ForEachStatement.accept(ForEachStatement.java:96)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultVisitor.scan(DefaultVisitor.java:143)
at org.netbeans.modules.php.editor.verification.IntroduceSuggestion$IntroduceFixVisitor.scan(IntroduceSuggestion.java:185)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultVisitor.scan(DefaultVisitor.java:150)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultVisitor.visit(DefaultVisitor.java:212)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultTreePathVisitor.visit(DefaultTreePathVisitor.java:237)
at org.netbeans.modules.php.editor.parser.astnodes.Block.accept(Block.java:70)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultVisitor.scan(DefaultVisitor.java:143)
at org.netbeans.modules.php.editor.verification.IntroduceSuggestion$IntroduceFixVisitor.scan(IntroduceSuggestion.java:185)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultVisitor.visit(DefaultVisitor.java:422)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultTreePathVisitor.visit(DefaultTreePathVisitor.java:454)
at org.netbeans.modules.php.editor.parser.astnodes.IfStatement.accept(IfStatement.java:85)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultVisitor.scan(DefaultVisitor.java:143)
at org.netbeans.modules.php.editor.verification.IntroduceSuggestion$IntroduceFixVisitor.scan(IntroduceSuggestion.java:185)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultVisitor.scan(DefaultVisitor.java:150)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultVisitor.visit(DefaultVisitor.java:212)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultTreePathVisitor.visit(DefaultTreePathVisitor.java:237)
at org.netbeans.modules.php.editor.parser.astnodes.Block.accept(Block.java:70)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultVisitor.scan(DefaultVisitor.java:143)
at org.netbeans.modules.php.editor.verification.IntroduceSuggestion$IntroduceFixVisitor.scan(IntroduceSuggestion.java:185)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultVisitor.visit(DefaultVisitor.java:396)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultTreePathVisitor.visit(DefaultTreePathVisitor.java:419)
at org.netbeans.modules.php.editor.parser.astnodes.FunctionDeclaration.accept(FunctionDeclaration.java:144)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultVisitor.scan(DefaultVisitor.java:143)
at org.netbeans.modules.php.editor.verification.IntroduceSuggestion$IntroduceFixVisitor.scan(IntroduceSuggestion.java:185)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultVisitor.visit(DefaultVisitor.java:485)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultTreePathVisitor.visit(DefaultTreePathVisitor.java:531)
at org.netbeans.modules.php.editor.parser.astnodes.MethodDeclaration.accept(MethodDeclaration.java:73)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultVisitor.scan(DefaultVisitor.java:143)
at org.netbeans.modules.php.editor.verification.IntroduceSuggestion$IntroduceFixVisitor.scan(IntroduceSuggestion.java:185)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultVisitor.scan(DefaultVisitor.java:150)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultVisitor.visit(DefaultVisitor.java:212)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultTreePathVisitor.visit(DefaultTreePathVisitor.java:237)
at org.netbeans.modules.php.editor.parser.astnodes.Block.accept(Block.java:70)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultVisitor.scan(DefaultVisitor.java:143)
at org.netbeans.modules.php.editor.verification.IntroduceSuggestion$IntroduceFixVisitor.scan(IntroduceSuggestion.java:185)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultVisitor.visit(DefaultVisitor.java:252)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultTreePathVisitor.visit(DefaultTreePathVisitor.java:279)
at org.netbeans.modules.php.editor.parser.astnodes.ClassDeclaration.accept(ClassDeclaration.java:140)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultVisitor.scan(DefaultVisitor.java:143)
at org.netbeans.modules.php.editor.verification.IntroduceSuggestion$IntroduceFixVisitor.scan(IntroduceSuggestion.java:185)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultVisitor.scan(DefaultVisitor.java:150)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultVisitor.visit(DefaultVisitor.java:212)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultTreePathVisitor.visit(DefaultTreePathVisitor.java:237)
at org.netbeans.modules.php.editor.parser.astnodes.Block.accept(Block.java:70)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultVisitor.scan(DefaultVisitor.java:143)
at org.netbeans.modules.php.editor.verification.IntroduceSuggestion$IntroduceFixVisitor.scan(IntroduceSuggestion.java:185)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultVisitor.visit(DefaultVisitor.java:686)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultTreePathVisitor.visit(DefaultTreePathVisitor.java:143)
at org.netbeans.modules.php.editor.parser.astnodes.NamespaceDeclaration.accept(NamespaceDeclaration.java:88)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultVisitor.scan(DefaultVisitor.java:143)
at org.netbeans.modules.php.editor.verification.IntroduceSuggestion$IntroduceFixVisitor.scan(IntroduceSuggestion.java:185)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultVisitor.scan(DefaultVisitor.java:150)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultVisitor.visit(DefaultVisitor.java:517)
at org.netbeans.modules.php.editor.parser.astnodes.visitors.DefaultTreePathVisitor.visit(DefaultTreePathVisitor.java:573)
at org.netbeans.modules.php.editor.parser.astnodes.Program.accept(Program.java:67)
at org.netbeans.modules.php.editor.verification.IntroduceSuggestion.invoke(IntroduceSuggestion.java:146)
at org.netbeans.modules.php.editor.verification.PHPHintsProvider$RulesRunnerImpl.adjustAndInvoke(PHPHintsProvider.java:221)
at org.netbeans.modules.php.editor.verification.PHPHintsProvider$RulesRunnerImpl.run(PHPHintsProvider.java:202)
at org.netbeans.modules.php.editor.verification.PHPHintsProvider.computeSuggestions(PHPHintsProvider.java:102)
at org.netbeans.modules.csl.hints.infrastructure.SuggestionsTask$1.run(SuggestionsTask.java:131)
at org.netbeans.modules.parsing.impl.TaskProcessor.callUserTask(TaskProcessor.java:586)
at org.netbeans.modules.parsing.api.ParserManager$UserTaskAction.run(ParserManager.java:132)
at org.netbeans.modules.parsing.api.ParserManager$UserTaskAction.run(ParserManager.java:116)
at org.netbeans.modules.parsing.impl.TaskProcessor$2.call(TaskProcessor.java:181)
at org.netbeans.modules.parsing.impl.TaskProcessor$2.call(TaskProcessor.java:178)
at org.netbeans.modules.masterfs.filebasedfs.utils.FileChangedManager.priorityIO(FileChangedManager.java:153)
at org.netbeans.modules.masterfs.providers.ProvidedExtensions.priorityIO(ProvidedExtensions.java:335)
at org.netbeans.modules.parsing.nb.DataObjectEnvFactory.runPriorityIO(DataObjectEnvFactory.java:118)
at org.netbeans.modules.parsing.impl.Utilities.runPriorityIO(Utilities.java:67)
at org.netbeans.modules.parsing.impl.TaskProcessor.runUserTask(TaskProcessor.java:178)
Caused: org.netbeans.modules.parsing.spi.ParseException
at org.netbeans.modules.parsing.impl.TaskProcessor.runUserTask(TaskProcessor.java:186)
at org.netbeans.modules.parsing.api.ParserManager.parse(ParserManager.java:83)
[catch] at org.netbeans.modules.csl.hints.infrastructure.SuggestionsTask.run(SuggestionsTask.java:97)
at org.netbeans.modules.csl.hints.infrastructure.SuggestionsTask.run(SuggestionsTask.java:54)
at org.netbeans.modules.parsing.impl.TaskProcessor.callParserResultTask(TaskProcessor.java:561)
at org.netbeans.modules.parsing.impl.TaskProcessor$RequestPerformer.run(TaskProcessor.java:786)
at org.openide.util.lookup.Lookups.executeWith(Lookups.java:288)
at org.netbeans.modules.parsing.impl.TaskProcessor$RequestPerformer.execute(TaskProcessor.java:702)
at org.netbeans.modules.parsing.impl.TaskProcessor$CompilationJob.run(TaskProcessor.java:663)
at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:572)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
at org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:1420)
at org.netbeans.modules.openide.util.GlobalLookup.execute(GlobalLookup.java:45)
at org.openide.util.lookup.Lookups.executeWith(Lookups.java:287)
at org.openide.util.RequestProcessor$Processor.run(RequestProcessor.java:2035)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] PHP: Improve the performance for Go to Declaration [netbeans]
Posted by "junichi11 (via GitHub)" <gi...@apache.org>.
junichi11 commented on PR #6712:
URL: https://github.com/apache/netbeans/pull/6712#issuecomment-1817391159
@tmysik Thank you for your review! I'll wait a little while because someone else might test it with the dev version.
https://github.com/apache/netbeans/suites/18271218545/artifacts/1056392947
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] PHP: Improve the performance for Go to Declaration [netbeans]
Posted by "terax6669 (via GitHub)" <gi...@apache.org>.
terax6669 commented on PR #6712:
URL: https://github.com/apache/netbeans/pull/6712#issuecomment-1816268684
Compared against 20-4c4, this new build breaks refactoring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] PHP: Improve the performance for Go to Declaration [netbeans]
Posted by "czukowski (via GitHub)" <gi...@apache.org>.
czukowski commented on PR #6712:
URL: https://github.com/apache/netbeans/pull/6712#issuecomment-1818722122
@junichi11 I'm testing it with a project containing 50k+ PHP classes, the navigation is instantaneous, brilliant! I haven't seen any issues with it so far. If there's still a chance to squeeze this into NB20, I'd say go for it, the improvement is too large to ignore 😁
Thanks for all the hard work!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] PHP: Improve the performance for Go to Declaration [netbeans]
Posted by "czukowski (via GitHub)" <gi...@apache.org>.
czukowski commented on PR #6712:
URL: https://github.com/apache/netbeans/pull/6712#issuecomment-1820790387
I guess I'll hold onto this dev build then, for the time being 😊
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] PHP: Improve the performance for Go to Declaration [netbeans]
Posted by "junichi11 (via GitHub)" <gi...@apache.org>.
junichi11 commented on PR #6712:
URL: https://github.com/apache/netbeans/pull/6712#issuecomment-1824148977
Thank you, guys! Merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] PHP: Improve the performance for Go to Declaration [netbeans]
Posted by "mvorisek (via GitHub)" <gi...@apache.org>.
mvorisek commented on PR #6712:
URL: https://github.com/apache/netbeans/pull/6712#issuecomment-1837498655
Can a nb21 module be copied into nb20 install, is the API compatible/standardized?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists