You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/31 14:24:26 UTC

[GitHub] [arrow-rs] Dandandan commented on a change in pull request #644: Remove UB in `value` method

Dandandan commented on a change in pull request #644:
URL: https://github.com/apache/arrow-rs/pull/644#discussion_r680365383



##########
File path: arrow/src/array/array_boolean.rs
##########
@@ -100,7 +100,7 @@ impl BooleanArray {
     ///
     /// Note this doesn't do any bound checking, for performance reason.
     pub fn value(&self, i: usize) -> bool {
-        debug_assert!(i < self.len());

Review comment:
       UB 1




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org