[GitHub] [spark] cloud-fan commented on a change in pull request #30852: [SPARK-33847][SQL] Simplify CaseWhen if elseValue is None

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #30852:
URL: https://github.com/apache/spark/pull/30852#discussion_r547717138



##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/ReplaceNullWithFalseInPredicateSuite.scala
##########
@@ -222,10 +223,14 @@ class ReplaceNullWithFalseInPredicateSuite extends PlanTest {
         Literal(null, IntegerType),
         Literal(3)),
       FalseLiteral)
-    testFilter(originalCond = condition, expectedCond = condition)
-    testJoin(originalCond = condition, expectedCond = condition)
-    testDelete(originalCond = condition, expectedCond = condition)
-    testUpdate(originalCond = condition, expectedCond = condition)
+    val expectedCond = If(

Review comment:
       We need to update the test name. Now it's `inability to replace null in non-boolean branches of If`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org