You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by og...@apache.org on 2009/02/05 17:56:40 UTC
svn commit: r741180 -
/maven/mercury/trunk/mercury-repo/mercury-repo-virtual/src/test/java/org/apache/maven/mercury/repository/virtual/VirtualRepositoryReaderTest.java
Author: ogusakov
Date: Thu Feb 5 16:56:40 2009
New Revision: 741180
URL: http://svn.apache.org/viewvc?rev=741180&view=rev
Log:
removed checking for clean test repo - windows is holding on to it
Modified:
maven/mercury/trunk/mercury-repo/mercury-repo-virtual/src/test/java/org/apache/maven/mercury/repository/virtual/VirtualRepositoryReaderTest.java
Modified: maven/mercury/trunk/mercury-repo/mercury-repo-virtual/src/test/java/org/apache/maven/mercury/repository/virtual/VirtualRepositoryReaderTest.java
URL: http://svn.apache.org/viewvc/maven/mercury/trunk/mercury-repo/mercury-repo-virtual/src/test/java/org/apache/maven/mercury/repository/virtual/VirtualRepositoryReaderTest.java?rev=741180&r1=741179&r2=741180&view=diff
==============================================================================
--- maven/mercury/trunk/mercury-repo/mercury-repo-virtual/src/test/java/org/apache/maven/mercury/repository/virtual/VirtualRepositoryReaderTest.java (original)
+++ maven/mercury/trunk/mercury-repo/mercury-repo-virtual/src/test/java/org/apache/maven/mercury/repository/virtual/VirtualRepositoryReaderTest.java Thu Feb 5 16:56:40 2009
@@ -82,8 +82,9 @@
_testBase = new File( "./target/repo" );
FileUtil.delete( _testBase );
-
- if( _testBase.exists() )
+
+// windows does not like it
+ if( ! Util.isWindows() && _testBase.exists() )
throw new Exception( "cannot clean folder " + _testBase.getAbsolutePath() );
_testBase.mkdirs();
Re: svn commit: r741180 - /maven/mercury/trunk/mercury-repo/mercury-repo-virtual/src/test/java/org/apache/maven/mercury/repository/virtual/VirtualRepositoryReaderTest.java
Posted by Oleg Gusakov <ol...@gmail.com>.
Thanks Benjamin !
I put [MERCURY-69] off till I fix more urgent issues, that's why this
workaround. Will get to it as soon as I can :)
Benjamin Bentmann wrote:
> Hi Oleg,
>
>> Author: ogusakov
>> Date: Thu Feb 5 16:56:40 2009
>> New Revision: 741180
>>
>> URL: http://svn.apache.org/viewvc?rev=741180&view=rev
>> Log:
>> removed checking for clean test repo - windows is holding on to it
>
> Failures to remove files/directories usually indicate file handle
> leaks (e.g. MERCURY-69). Eventually, we should try to track these down.
>
>
> Benjamin
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r741180 - /maven/mercury/trunk/mercury-repo/mercury-repo-virtual/src/test/java/org/apache/maven/mercury/repository/virtual/VirtualRepositoryReaderTest.java
Posted by Benjamin Bentmann <be...@udo.edu>.
Hi Oleg,
> Author: ogusakov
> Date: Thu Feb 5 16:56:40 2009
> New Revision: 741180
>
> URL: http://svn.apache.org/viewvc?rev=741180&view=rev
> Log:
> removed checking for clean test repo - windows is holding on to it
Failures to remove files/directories usually indicate file handle leaks
(e.g. MERCURY-69). Eventually, we should try to track these down.
Benjamin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org